Spec URL: http://pmackinn.fedorapeople.org/pig/pig.spec SRPM URL: http://pmackinn.fedorapeople.org/pig/pig-0.12.0-1.fc21.src.rpm Description: Apache Pig is a platform for analyzing large data sets that consists of a high-level language for expressing data analysis programs, coupled with infrastructure for evaluating these programs. The salient property of Pig programs is that their structure is amenable to substantial parallelization, which in turns enables them to handle very large data sets. Fedora Account System Username: pmackinn
This initial version omits the pig executable script for the time being. However, the jar artifact helps to unblock some other forthcoming reviews while the executable script is being developed.
Is there a reason why you can't use an upstream tarball and delete jars in %prep?
(In reply to Will Benton from comment #2) > Is there a reason why you can't use an upstream tarball and delete jars in > %prep? (cf. https://fedoraproject.org/wiki/Packaging:SourceURL — when upstream provides a tarball, we need to use that unless it contains some prohibited code.)
Well, mid-air collision :) Fails to build due to missing dependencies but looks to me that rawhide is not in a good shape. http://koji.fedoraproject.org/koji/taskinfo?taskID=6476037
Spec URL: http://pmackinn.fedorapeople.org/pig/pig.spec SRPM URL: http://pmackinn.fedorapeople.org/pig/pig-0.12.0-1.fc21.src.rpm Fixes: - added missing maven-local dep (for ivy-local) - switched to tarball source from Apache; bundled jars are removed in %prep - removed spurious URL ref to Hive project
Thanks for making the tarball change, Pete. I only turned up a couple of minor issues in the review. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local See: https://fedoraproject.org/wiki/Packaging:Java ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. - add %{_sysconfdir}/%{name} (not just all of the files therein) to %files [!]: Package must own all directories that it creates. - as above [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. - you don't need an explicit jpackage-utils requirement if you're using maven-local [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [-]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. - I'm assuming this is due to missing test deps; can you justify in a comment? [!]: Packages should try to preserve timestamps of original installed files. - add "-p" to install invocations where appropriate, please [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. - all warnings appear spurious [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pig-0.12.0-1.fc21.noarch.rpm pig-javadoc-0.12.0-1.fc21.noarch.rpm pig-0.12.0-1.fc21.src.rpm pig.noarch: W: name-repeated-in-summary C Pig pig.noarch: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization pig.noarch: W: non-conffile-in-etc /etc/pig/log4j.properties pig.noarch: W: non-conffile-in-etc /etc/pig/pig.properties pig.src: W: name-repeated-in-summary C Pig pig.src: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization pig.src:91: W: macro-in-comment %{buildroot} pig.src:91: W: macro-in-comment %{_bindir} pig.src:92: W: macro-in-comment %{name} pig.src:92: W: macro-in-comment %{buildroot} pig.src:92: W: macro-in-comment %{_bindir} pig.src:107: W: macro-in-comment %{buildroot} pig.src:107: W: macro-in-comment %{_datadir} pig.src:107: W: macro-in-comment %{name} pig.src:108: W: macro-in-comment %{buildroot} pig.src:108: W: macro-in-comment %{_datadir} pig.src:108: W: macro-in-comment %{name} pig.src:109: W: macro-in-comment %{_bindir} pig.src:109: W: macro-in-comment %{buildroot} pig.src:109: W: macro-in-comment %{_datadir} pig.src:109: W: macro-in-comment %{name} pig.src:115: W: macro-in-comment %{_bindir} pig.src:115: W: macro-in-comment %{name} pig.src:116: W: macro-in-comment %{_datadir} pig.src:116: W: macro-in-comment %{name} 3 packages and 0 specfiles checked; 0 errors, 25 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint pig-javadoc pig pig.noarch: W: name-repeated-in-summary C Pig pig.noarch: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization pig.noarch: W: non-conffile-in-etc /etc/pig/log4j.properties pig.noarch: W: non-conffile-in-etc /etc/pig/pig.properties 2 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- pig-javadoc (rpmlib, GLIBC filtered): jpackage-utils pig (rpmlib, GLIBC filtered): jpackage-utils Provides -------- pig-javadoc: pig-javadoc pig: mvn(org.apache.pig:pig) pig Source checksums ---------------- http://www.apache.org/dist/pig/pig-0.12.0/pig-0.12.0-src.tar.gz : CHECKSUM(SHA256) this package : ade8fc3cd443f2a34ab6256290691e2c97da91ab6bbb4d37632aa69c82369a70 CHECKSUM(SHA256) upstream package : ade8fc3cd443f2a34ab6256290691e2c97da91ab6bbb4d37632aa69c82369a70 Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1060277 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG
Spec URL: http://pmackinn.fedorapeople.org/pig/pig.spec SRPM URL: http://pmackinn.fedorapeople.org/pig/pig-0.12.0-1.fc21.src.rpm
Spec URL: http://pmackinn.fedorapeople.org/pig/pig.spec SRPM URL: http://pmackinn.fedorapeople.org/pig/pig-0.12.0-1.fc21.src.rpm Corrected a recently changed (in rawhide) netty3 dependency.
Pete, thanks for making the changes we discussed. The spec looks good and everything builds in Rawhide after your most recent dependency updates. I also appreciate that the latest specs use macros instead of magic version numbers in %build. Koji link: http://koji.fedoraproject.org/koji/taskinfo?taskID=6517739 Review granted.
New Package SCM Request ======================= Package Name: pig Short Description: A platform for analyzing large data sets Owners: pmackinn Branches: InitialCC: java-sig
Git done (by process-git-requests).