Bug 1060316 - RFE: Use virConnectGetCPUModelNames
Summary: RFE: Use virConnectGetCPUModelNames
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Giuseppe Scrivano
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-31 18:54 UTC by Cole Robinson
Modified: 2014-03-13 18:05 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-13 18:05:30 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Cole Robinson 2014-01-31 18:54:46 UTC 
virt-manager depends on parsing the local cpu_map.xml file that libvirt ships to get a list of CPU model names. This file is meant to be private to libvirt so we shouldn't be doing that.

There's an API now called virConnectGetCPUModelNames which we should be using to get this info, on new enough libvirt.
Comment 1 Giuseppe Scrivano 2014-03-13 18:05:30 UTC 
closed by commit:

commit 81696a514441f2320ea10299e1852795f8cb1682
Author: Giuseppe Scrivano <gscrivan>
Date:   Thu Mar 13 12:52:51 2014 +0100

    virtinst: use libvirt getCPUModelNames when available
    
    Read the list of CPU models trough getCPUModelNames instead of
    accessing directly the file cpu_map.xml.
    
    Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1060316
    
    Signed-off-by: Giuseppe Scrivano <gscrivan>
Note You need to log in before you can comment on or make changes to this bug.