Spec URL: http://mcepl.fedorapeople.org/tmp/python-pycalendar.spec SRPM URL: http://mcepl.fedorapeople.org/tmp/python-pycalendar-2-0.0.20140201svn214.el7.src.rpm Description: Python-based iCalendar (RFC 5545) and vCard (RFC 2426) library that allows iCalendar and vCard data to be parsed, manipulated and generated using an API that closely resembles the object models of iCalendar and vCard. The library includes options to validate input data, and also output data in XML format. The package also includes a tool to parse Olson timezone database information to generate iCalendar compatible timezone definitions. Fedora Account System Username: mcepl Builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6479806
Updated SPEC file http://mcepl.fedorapeople.org/tmp/python-pycalendar.spec Updated SRPM http://mcepl.fedorapeople.org/tmp/python-pycalendar-2-0.1.20140201svn214.el7.src.rpm
fedora-review doesn't flag anything major, neither does manual inspection. Few tidbits: - https://fedoraproject.org/wiki/Packaging:Python#Macros: suggests adding a python2_sitearch definition. probably doesn't affect this package but I'd recommend following the docs for consistency - URL and Source aren't column aligned like the rest of the fields - tarball has src/pycalendar/tests but its unclear how they are expected to be invoked. might want to consider figuring it out and running them in a %check section But none of those are blocking issues IMO, so setting fedora-review+
Drop rm -rf $RPM_BUILD_ROOT Source discussion: I checked the BSD ports of caldav(https://github.com/rvanlaar/caldavports/), it has a version 2.0, then I searched on pypi and found: https://pypi.python.org/pypi/pycalendar/2.0 Which may be potentially the same as https://pypi.python.org/pypi/Py-Calendar Would you like to check it?
(In reply to Christopher Meng from comment #3) > Drop > > rm -rf $RPM_BUILD_ROOT > so that's no longer required for EPEL? Is that another side effect of using newer rpmbuild as Michael mentioned here: https://bugzilla.redhat.com/show_bug.cgi?id=1003089#c32
(In reply to Cole Robinson from comment #4) > (In reply to Christopher Meng from comment #3) > > Drop > > > > rm -rf $RPM_BUILD_ROOT > > > > so that's no longer required for EPEL? Is that another side effect of using > newer rpmbuild as Michael mentioned here: > > https://bugzilla.redhat.com/show_bug.cgi?id=1003089#c32 No, drop this line is harmless.
see bug 1060440 comment 16