Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1060685

Summary: Cinder sample config sections are incorrect
Product: Red Hat OpenStack Reporter: Fabio Massimo Di Nitto <fdinitto>
Component: openstack-cinderAssignee: Flavio Percoco <fpercoco>
Status: CLOSED ERRATA QA Contact: Yogev Rabl <yrabl>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0CC: ddomingo, eharney, fpercoco, jruzicka, nlevinki, scohen, yeylon
Target Milestone: rcKeywords: ZStream
Target Release: 5.0 (RHEL 7)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-cinder-2014.1-4.el6ost Doc Type: Bug Fix
Doc Text:
This release corrects the default location of the 'memcached_servers' option in the default /etc/cinder/cinder.conf configuration file. In previous releases, this option was incorrectly listed under DEFAULT; the Block Storage service expects 'memcached_servers' to be in the [keystone_authtoken] section, where it now appears.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-08 15:31:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabio Massimo Di Nitto 2014-02-03 11:10:23 UTC
In default config file in havana, memcached_servers option is part of the DEFAULT section, but the code only read it from [keystone_authtoken] section.

It is clearly misleading. Please fix the default config file to report it in the right section.

Also, cinder should really Requires: python-memcached otherwise it just doesn´t work, or warn that memcached will not work (check the error when importing the module)

Comment 2 Eric Harney 2014-02-03 14:35:16 UTC
For Havana, it looks like the option is read from the DEFAULT section, as it's registered as a normal global option?

http://git.openstack.org/cgit/openstack/cinder/tree/cinder/common/config.py?h=stable%2Fhavana#n170

I don't see any import of the memcache module in Cinder, but it looks like the keystoneclient package might be missing a dependency on python-memcached.

Comment 3 Fabio Massimo Di Nitto 2014-02-03 14:38:33 UTC
(In reply to Eric Harney from comment #2)
> For Havana, it looks like the option is read from the DEFAULT section, as
> it's registered as a normal global option?

No it´s not. Flavio Percoco and I just did a debugging session and it´s not read from DEFAULT.

> 
> http://git.openstack.org/cgit/openstack/cinder/tree/cinder/common/config.
> py?h=stable%2Fhavana#n170
> 
> I don't see any import of the memcache module in Cinder, but it looks like
> the keystoneclient package might be missing a dependency on python-memcached.

It was installed.

Comment 4 Eric Harney 2014-02-03 14:46:57 UTC
(In reply to Fabio Massimo Di Nitto from comment #3)
Ah, looks like the sample config generator was broken in Cinder Havana and this was fixed in Icehouse.

https://review.openstack.org/#/c/61736/

There doesn't seem to be much reason to backport the new sample config generator to RHOS 4... we need to decide if it's worth carrying a downstream patch that just cleans up the sample config.

It doesn't look like this bug affects Icehouse / RHOS 5.

Comment 5 Flavio Percoco 2014-02-04 07:36:37 UTC
IMHO, this could be simply fixed in the -dist config file.

Also, as mentioned on IRC, I don't think python-memcached should be a hard dependency for cinder.

Comment 6 Fabio Massimo Di Nitto 2014-02-04 07:59:03 UTC
(In reply to Flavio Percoco from comment #5)
> IMHO, this could be simply fixed in the -dist config file.
> 
> Also, as mentioned on IRC, I don't think python-memcached should be a hard
> dependency for cinder.

Agree, as long as the example config file is correct, there is no need to change the whole code to read it from DEFAULT.

Comment 9 Yogev Rabl 2014-06-16 07:18:14 UTC
verified in: 

python-cinderclient-1.0.8-1.el7ost.noarch
openstack-cinder-2014.1-4.el7ost.noarch
python-cinder-2014.1-4.el7ost.noarch
python-oslo-config-1.2.1-1.el7ost.noarch
python-oslo-messaging-1.3.0.2-2.el7ost.noarch
python-oslo-rootwrap-1.0.0-2.el7ost.noarch

Comment 12 errata-xmlrpc 2014-07-08 15:31:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-0852.html

Comment 13 Red Hat Bugzilla 2023-09-14 02:03:05 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days