Spec URL: http://xor.cryptomilk.org/rpm/nss_wrapper/nss_wrapper.spec SRPM URL: http://xor.cryptomilk.org/rpm/nss_wrapper/nss_wrapper-1.0.0-1.fc20.src.rpm Description: There are projects which provide daemons needing to be able to create, modify and delete unix users. Or just switch user ids to interact with the system e.g. a user space file server. To be able to test that you need the privilege to modify the passwd and groups file. With nss_wrapper it is possible to define your own passwd and groups file which will be used by software to act correctly while under test. Fedora Account System Username: asn NOTE: This is a special library you load with LD_PRELOAD. There is no header file and it will not be linked against any library!
Spec URL: http://xor.cryptomilk.org/rpm/nss_wrapper/nss_wrapper.spec SRPM URL: http://xor.cryptomilk.org/rpm/nss_wrapper/nss_wrapper-1.0.1-1.fc20.src.rpm ChangeLog of 1.0.1: * Added --libs to pkg-config. * Added socket_wrapper-config.cmake * Fixed a bug packaging the obj directory.
Spec URL: http://xor.cryptomilk.org/rpm/nss_wrapper/nss_wrapper.spec SRPM URL: http://xor.cryptomilk.org/rpm/nss_wrapper/nss_wrapper-1.0.1-2.fc20.src.rpm - Remove Group - Remove glibc-devel build requirement - Do not create a subpackage.
This package is very similar to socket_wrapper I already reviwed. I'll also take a look at nss_wrapper.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ----> As discussed in bug #1060909, this is probably the best way to go and allow the preloading (which is the point of the wrappers) easily. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. ----> Yes, the package is licensed with a BSD license [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/remote/jhrozek/rpmbuild/SRPMS/nss_wrapper/licensecheck.txt ----> Yes, COPYING contains a BSD license text [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/pkgconfig(socket_wrapper, pkgconfig, libsocket_wrapper), /usr/lib64/cmake(socket_wrapper, cmake, libsocket_wrapper) ----> This allows the package to be installed even without pkgconfig or cmake [x]: %build honors applicable compiler flags or justifies otherwise. ----> Yes, the %cmake macro expands to using the right CFLAGS [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. ----> Installing the library into %libdir might seem strange a bit, but uid_wrapper is an exception in this regard. See discussion in bug #1060909 for more details. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ----> I don't think this Requires is needed, there is a perl script, not a module ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. Note: uid_wrapper : /usr/lib64/pkgconfig/uid_wrapper.pc [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nss_wrapper-1.0.1-2.fc20.x86_64.rpm nss_wrapper-1.0.1-2.fc20.src.rpm nss_wrapper.x86_64: W: spelling-error %description -l en_US passwd -> passed, password nss_wrapper.x86_64: W: spelling-error %description -l en_US nss -> ass, nos, nus nss_wrapper.x86_64: W: spelling-error %description -l en_US dns -> dens, dins, dons nss_wrapper.x86_64: W: spelling-error %description -l en_US versa -> avers, verse, verso nss_wrapper.x86_64: W: spelling-error %description -l en_US devel -> delve, devil, revel nss_wrapper.x86_64: W: shared-lib-calls-exit /usr/lib64/libnss_wrapper.so.0.0.1 exit.5 nss_wrapper.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libnss_wrapper.so nss_wrapper.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/nss_wrapper.pc nss_wrapper.x86_64: W: no-manual-page-for-binary nss_wrapper.pl nss_wrapper.src: W: spelling-error %description -l en_US passwd -> passed, password nss_wrapper.src: W: spelling-error %description -l en_US nss -> ass, nos, nus nss_wrapper.src: W: spelling-error %description -l en_US dns -> dens, dins, dons nss_wrapper.src: W: spelling-error %description -l en_US versa -> avers, verse, verso nss_wrapper.src: W: spelling-error %description -l en_US devel -> delve, devil, revel 2 packages and 0 specfiles checked; 0 errors, 14 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nss_wrapper nss_wrapper.x86_64: W: spelling-error %description -l en_US passwd -> passed, password nss_wrapper.x86_64: W: spelling-error %description -l en_US nss -> ass, nos, nus nss_wrapper.x86_64: W: spelling-error %description -l en_US dns -> dens, dins, dons nss_wrapper.x86_64: W: spelling-error %description -l en_US versa -> avers, verse, verso nss_wrapper.x86_64: W: spelling-error %description -l en_US devel -> delve, devil, revel nss_wrapper.x86_64: W: shared-lib-calls-exit /usr/lib64/libnss_wrapper.so.0.0.1 exit.5 nss_wrapper.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libnss_wrapper.so nss_wrapper.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/nss_wrapper.pc nss_wrapper.x86_64: W: no-manual-page-for-binary nss_wrapper.pl 1 packages and 0 specfiles checked; 0 errors, 9 warnings. # echo 'rpmlint-done:' Requires -------- nss_wrapper (rpmlib, GLIBC filtered): /sbin/ldconfig /usr/bin/perl /usr/bin/pkg-config libc.so.6()(64bit) libdl.so.2()(64bit) libnss_wrapper.so.0()(64bit) perl(Cwd) perl(Getopt::Long) perl(strict) rtld(GNU_HASH) Provides -------- nss_wrapper: libnss_wrapper.so.0()(64bit) nss_wrapper nss_wrapper(x86-64) pkgconfig(nss_wrapper) Unversioned so-files -------------------- nss_wrapper: /usr/lib64/libnss_wrapper.so Source checksums ---------------- https://ftp.samba.org/pub/cwrap/nss_wrapper-1.0.1.tar.gz : CHECKSUM(SHA256) this package : c46498e1119bfc4bf8f7ce6db4b1bcff969043ab2ce04c54fdec29a2bf9034f2 CHECKSUM(SHA256) upstream package : c46498e1119bfc4bf8f7ce6db4b1bcff969043ab2ce04c54fdec29a2bf9034f2 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --rpm-spec -n nss_wrapper-1.0.1-2.fc20.src.rpm Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++, Perl Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
In short, I don't have any issues with the package. It's very similar to socket_wrapper which already passed a review, so it went quite smooth.
New Package SCM Request ======================= Package Name: nss_wrapper Short Description: A wrapper for the user, group and hosts NSS API Owners: asn Branches: f20 epel7 InitialCC: jhrozek
Git done (by process-git-requests).
Package Change Request ====================== Package Name: nss_wrapper New Branches: el6 Owners: asn jhrozek
nss_wrapper-1.0.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nss_wrapper-1.0.2-2.el6
nss_wrapper-1.0.2-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
nss_wrapper-1.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.