Spec URL: http://galileo.fedorapeople.org/aether-connector-okhttp/0.0.10-0.1/aether-connector-okhttp.spec SRPM URL: http://galileo.fedorapeople.org/aether-connector-okhttp/0.0.10-0.1/aether-connector-okhttp-0.0.10-0.1.fc21.src.rpm Description: A repository connector implementation based on Square's OkHttp. Fedora Account System Username: galileo Unreleased version packaged because we have okhttp-1.2.1
This will be a dependency for eclipse-m2e-core 1.5.x
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' Please, remove aether-connector-okhttp-0.0.10-92f183b.tar.gz ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/license-header.txt [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 64 files have unknown license. Detailed output of licensecheck in /home/gil/1060915-aether-connector- okhttp/licensecheck.txt Apache (v2.0) and EPLv1.0 aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/java/io/tesla/aether/okhttp/ssl/CertificateUtils.java aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/java/io/tesla/aether/okhttp/ssl/SslContextFactory.java Apache (v2.0) aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/java/io/tesla/aether/wagon/OkHttpsWagon.java [x]: License file installed when any subpackage combination is installed. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Please open a bug to include it [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in aether- connector-okhttp-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: aether-connector-okhttp-0.0.10-0.1.fc21.noarch.rpm aether-connector-okhttp-javadoc-0.0.10-0.1.fc21.noarch.rpm aether-connector-okhttp-0.0.10-0.1.fc21.src.rpm aether-connector-okhttp.noarch: W: incoherent-version-in-changelog 1.2.1-1 ['0.0.10-0.1.fc21', '0.0.10-0.1'] 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint aether-connector-okhttp-javadoc aether-connector-okhttp aether-connector-okhttp.noarch: W: incoherent-version-in-changelog 1.2.1-1 ['0.0.10-0.1.fc21', '0.0.10-0.1'] 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- aether-connector-okhttp-javadoc (rpmlib, GLIBC filtered): jpackage-utils aether-connector-okhttp (rpmlib, GLIBC filtered): java jpackage-utils mvn(com.google.guava:guava) mvn(com.squareup.okhttp:okhttp) mvn(javax.inject:javax.inject) mvn(org.apache.maven.wagon:wagon-provider-api) mvn(org.eclipse.aether:aether-api) mvn(org.eclipse.aether:aether-impl) mvn(org.eclipse.aether:aether-spi) mvn(org.eclipse.aether:aether-util) mvn(org.slf4j:slf4j-api) Provides -------- aether-connector-okhttp-javadoc: aether-connector-okhttp-javadoc aether-connector-okhttp: aether-connector-okhttp mvn(io.tesla.aether:aether-connector-okhttp) Source checksums ---------------- https://github.com/tesla/aether-connector-okhttp/archive/92f183b496e7d628d50f07339d4880d4efffbc70/aether-connector-okhttp-0.0.10-92f183b.tar.gz : CHECKSUM(SHA256) this package : 7bd8e781965b1b82c2013ba651cde2fcff37d3eda07b4d04cb4d38ad5c014f6c CHECKSUM(SHA256) upstream package : 7bd8e781965b1b82c2013ba651cde2fcff37d3eda07b4d04cb4d38ad5c014f6c Jar and class files in source ----------------------------- ./aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/test/files/aether-spi-0.9.0.M2.jar Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1060915 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' Please, remove aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/test/files/aether-spi-0.9.0.M2.jar [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/license-header.txt [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 64 files have unknown license. Detailed output of licensecheck in /home/gil/1060915-aether-connector- okhttp/licensecheck.txt Apache (v2.0) and EPLv1.0 aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/java/io/tesla/aether/okhttp/ssl/CertificateUtils.java aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/java/io/tesla/aether/okhttp/ssl/SslContextFactory.java Apache (v2.0) aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/java/io/tesla/aether/wagon/OkHttpsWagon.java [?]: Package contains no bundled libraries without FPC exception. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Please open a bug to include it [!]: Package does not include license text files separate from upstream.
Please FIX aether-connector-okhttp.noarch: W: incoherent-version-in-changelog 1.2.1-1 ['0.0.10-0.1.fc21', '0.0.10-0.1']
Now is available aether-connector-okhttp 0.0.11. Please consider upgrading
Spec URL: http://galileo.fedorapeople.org/aether-connector-okhttp/0.0.11-1/aether-connector-okhttp.spec SRPM URL: http://galileo.fedorapeople.org/aether-connector-okhttp/0.0.11-1/aether-connector-okhttp-0.0.11-1.fc21.src.rpm Hi Gil, thanks for the review. Sorry to waste your time with the issues. I think I've got them sorted now: (In reply to gil cattaneo from comment #3) > - Bundled jar/class files should be removed before build > Note: Jar files in source (see attachment) > See: http://fedoraproject.org/wiki/Packaging:Java#Pre- > built_JAR_files_.2F_Other_bundled_software' > Please, remove > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/test/ > files/aether-spi-0.9.0.M2.jar Done. > [!]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/license- > header.txt I've included this now, but should this file be included? It's not what I would consider "the text of the license". > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Apache (v2.0)", "Unknown or generated". 64 files have unknown license. > Detailed output of licensecheck in /home/gil/1060915-aether-connector- > okhttp/licensecheck.txt > > Apache (v2.0) and EPLv1.0 > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/ > java/io/tesla/aether/okhttp/ssl/CertificateUtils.java > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/ > java/io/tesla/aether/okhttp/ssl/SslContextFactory.java > > Apache (v2.0) > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/ > java/io/tesla/aether/wagon/OkHttpsWagon.java > I've removed/unbundled the first two here, and added jetty-util as a dep. The last is Apache and EPL also, even though it's just reported as Apache here. I've changed the license field to: EPL and (ASL 2.0 and EPL). I think this is now correct, isn't it? > [?]: Package contains no bundled libraries without FPC exception. > I've removed the io/tesla/aether/okhttp/ssl/ package since the 2 files there were forked from jetty-util. > [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > Please open a bug to include it https://github.com/tesla/aether-connector-okhttp/pull/1 > [!]: Package does not include license text files separate from upstream. As I understand it, we'll still need to include EPL until upstream accept it. Is this correct or should I remove it? (In reply to gil cattaneo from comment #4) > Please FIX aether-connector-okhttp.noarch: W: > incoherent-version-in-changelog 1.2.1-1 ['0.0.10-0.1.fc21', '0.0.10-0.1'] Done. (In reply to gil cattaneo from comment #5) > Now is available aether-connector-okhttp 0.0.11. > Please consider upgrading Done.
(In reply to Gerard Ryan from comment #6) Hi Gerard no problems. thanks for your work > > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/license- > > header.txt > I've included this now, but should this file be included? It's not what I > would consider "the text of the license". my bad, ... i have drawn the wrong conclusions... if you want remove it ... license-header.txt should be considered as notice ... or no ... ?? > https://github.com/tesla/aether-connector-okhttp/pull/1 > As I understand it, we'll still need to include EPL until upstream accept > it. Is this correct or should I remove it? as you want Please add BuildRequires: mvn(org.eclipse.jetty:jetty-util) [ERROR] Failed to execute goal on project aether-connector-okhttp: Could not resolve dependencies for project io.tesla.aether:aether-connector-okhttp:jar:0.0.11: Cannot access central (http://repo.maven.apache.org/maven2) in offline mode and the artifact org.eclipse.jetty:jetty-util:jar:any has not been downloaded from it before. -> [Help 1]
Spec URL: http://galileo.fedorapeople.org/aether-connector-okhttp/0.0.11-2/aether-connector-okhttp.spec SRPM URL: http://galileo.fedorapeople.org/aether-connector-okhttp/0.0.11-2/aether-connector-okhttp-0.0.11-2.fc21.src.rpm (In reply to gil cattaneo from comment #7) > Please add > > BuildRequires: mvn(org.eclipse.jetty:jetty-util) > > [ERROR] Failed to execute goal on project aether-connector-okhttp: Could not > resolve dependencies for project > io.tesla.aether:aether-connector-okhttp:jar:0.0.11: Cannot access central > (http://repo.maven.apache.org/maven2) in offline mode and the artifact > org.eclipse.jetty:jetty-util:jar:any has not been downloaded from it before. > -> [Help 1] Ah, that was silly. I was sure I had added it. It's there now and builds in a clean rawhide mock environment (I had been using a dirty one to save time). Thanks again for your time! :)
now it seems okay APPROVED
New Package SCM Request ======================= Package Name: aether-connector-okhttp Short Description: OkHttp Aether Connector Owners: galileo Branches: f20 InitialCC: java-sig
Git done (by process-git-requests).