Bug 1060924 - Review Request: rubygem-unicode - Unicode normalization library for Ruby
Summary: Review Request: rubygem-unicode - Unicode normalization library for Ruby
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ken Dreyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1003402
TreeView+ depends on / blocked
 
Reported: 2014-02-03 23:23 UTC by Dan Callaghan
Modified: 2015-01-07 19:31 UTC (History)
2 users (show)

Fixed In Version: rubygem-unicode-0.4.4.1-2.fc21
Clone Of:
Environment:
Last Closed: 2015-01-06 06:12:01 UTC
Type: ---
Embargoed:
ktdreyer: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Dan Callaghan 2014-02-03 23:23:00 UTC
Spec URL: http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode.spec
SRPM URL: http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode-0.4.4-1.fc19.src.rpm
Description: Unicode normalization library for Ruby.
Fedora Account System Username: dcallagh

Comment 1 Ken Dreyer 2014-05-28 01:17:49 UTC
Hi Dan, I can take this one.

Mind conditionalizing the Requires and Provides to follow the latest Ruby Packaging Guidelines? For example:

  %if 0%{?fc19} || 0%{?fc20} || 0%{?el7}
  Requires:       ruby
  Requires:       ruby(rubygems)
  %endif

  %if 0%{?fc19} || 0%{?fc20} || 0%{?el7}
  Provides: rubygem(%{gem_name}) = %{version}
  %endif

Also, I'm getting a build failure on Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6900143

"mv: cannot stat '/builddir/build/BUILDROOT/rubygem-unicode-0.4.4-1.fc21.x86_64/usr/share/gems/gems/unicode-0.4.4/lib/unicode': No such file or directory"

Comment 2 Dan Callaghan 2014-05-29 06:42:47 UTC
Hmm Rubygem packaging might have moved on since I posted this. I will take a look and fix it up. Thanks for taking the review, Ken.

Comment 3 Dan Callaghan 2014-06-05 01:02:15 UTC
(In reply to Ken Dreyer from comment #1)
> Mind conditionalizing the Requires and Provides to follow the latest Ruby
> Packaging Guidelines? For example:
> 
>   %if 0%{?fc19} || 0%{?fc20} || 0%{?el7}
>   Requires:       ruby
>   Requires:       ruby(rubygems)
>   %endif
> 
>   %if 0%{?fc19} || 0%{?fc20} || 0%{?el7}
>   Provides: rubygem(%{gem_name}) = %{version}
>   %endif

I conditionalized the rubygem Requires/Provides. The requirement on ruby is still needed though, since this is a C extension so it's only compatible with MRI.

> Also, I'm getting a build failure on Rawhide:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=6900143
> 
> "mv: cannot stat
> '/builddir/build/BUILDROOT/rubygem-unicode-0.4.4-1.fc21.x86_64/usr/share/
> gems/gems/unicode-0.4.4/lib/unicode': No such file or directory"

Looks like on F21+ rubygems has been made smarter about installing C extensions to %{_libdir} so I have conditionalized the paths here as well.

I also updated to 0.4.4.1 of the gem, which is just a change to add license metadata to the gemspec.

http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode.spec
http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode-0.4.4.1-1.fc21.src.rpm

Comment 4 Ken Dreyer 2014-06-06 02:33:40 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Instead of packaging all of %{gem_instdir} in one go, please break the %files
  lists out and use "%{gem_libdir}", "%exclude %{gem_cache}", "%doc
  %{gem_docdir}" like other gems in Fedora. %{gem_docdir} should go into a -doc
  subpackage.

- Please run the test suite during %check or add a note in the comments to
  explain why the test suite does not work.

- Mind filing a bug upstream about shipping the license text? "If the source
  package does not include license text(s) as a separate file from upstream,
  the packager SHOULD query upstream to include it." Also, Ruby's license.txt
  contains references to a file called "LEGAL" which isn't really relevant to
  the unicode gem, or the "BSDL" file, which is not included in the RPM. It
  would be great to just get that sorted out upstream in the gem.

- Source1 can use HTTPS.


===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
     See note above in "Issues" about using the gem_ RPM macros.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exists
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: gems should require rubygems package
[x]: Gem package must define %{gem_name} macro.
[x]: Package does not contain Requires: ruby(abi).

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[!]: Test suite of the library should be run.
[!]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros: %{gem_libdir}, %exclude
     %{gem_cache}, %doc %{gem_docdir}
[x]: Gem package should exclude cached Gem.
[x]: Gem should use %gem_install macro.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-unicode-0.4.4.1-1.fc21.x86_64.rpm
          rubygem-unicode-0.4.4.1-1.fc21.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint rubygem-unicode
1 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
rubygem-unicode (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcrypt.so.1()(64bit)
    libdl.so.2()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libruby.so.2.1()(64bit)
    rtld(GNU_HASH)
    ruby
    ruby(rubygems)


Provides
--------
rubygem-unicode:
    rubygem(unicode)
    rubygem-unicode
    rubygem-unicode(x86-64)


Unversioned so-files
--------------------
rubygem-unicode: /usr/lib64/gems/ruby/unicode-0.4.4.1/unicode/unicode_native.so

Source checksums
----------------
https://rubygems.org/gems/unicode-0.4.4.1.gem :
  CHECKSUM(SHA256) this package     : 83011859e68928aa34cfec34fbb17ee54d74a64a7b258b10ee023e637dec88cf
  CHECKSUM(SHA256) upstream package : 83011859e68928aa34cfec34fbb17ee54d74a64a7b258b10ee023e637dec88cf
http://www.ruby-lang.org/en/about/license.txt :
  CHECKSUM(SHA256) this package     : 5572bf03c3c8c4770e8153038f5f54faad9c3db9900864a7c82a19de4434d74b
  CHECKSUM(SHA256) upstream package : 5572bf03c3c8c4770e8153038f5f54faad9c3db9900864a7c82a19de4434d74b


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1060924 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 5 Dan Callaghan 2014-07-14 11:57:44 UTC
Sorry it's taken me so long to get back to this.

(In reply to Ken Dreyer from comment #4)
> Issues:
> =======
> - Instead of packaging all of %{gem_instdir} in one go, please break the
> %files
>   lists out and use "%{gem_libdir}", "%exclude %{gem_cache}", "%doc
>   %{gem_docdir}" like other gems in Fedora. %{gem_docdir} should go into a
> -doc
>   subpackage.

Hmm. So I don't want to include the gem docs, they have no content. The gem also installs all its sources and .o files under ext/unicode/ which I assume is undesirable.

So I found it was easier to just selectively install the stuff we want during %install, and then just put %{gem_instdir} and %{gem_extdir_mir} in %files. That seemed easier than installing all the gem contents in %install and then %exclude'ing all the extraneous stuff in %files. But I can change it to do that if you think it's important.

> - Please run the test suite during %check or add a note in the comments to
>   explain why the test suite does not work.

test.rb isn't a test suite, it seems to be more for visual testing. But I can still run it during %check, to at least make sure the module can be loaded.

> - Mind filing a bug upstream about shipping the license text? "If the source
>   package does not include license text(s) as a separate file from upstream,
>   the packager SHOULD query upstream to include it." Also, Ruby's license.txt
>   contains references to a file called "LEGAL" which isn't really relevant to
>   the unicode gem, or the "BSDL" file, which is not included in the RPM. It
>   would be great to just get that sorted out upstream in the gem.

Filed:

https://github.com/blackwinter/unicode/issues/7

> - Source1 can use HTTPS.

Fixed.

http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode.spec
http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode-0.4.4.1-2.fc22.src.rpm

Comment 6 Ken Dreyer 2014-12-06 20:15:22 UTC
(In reply to Dan Callaghan from comment #5)
> So I found it was easier to just selectively install the stuff we want
> during %install, and then just put %{gem_instdir} and %{gem_extdir_mir} in
> %files. That seemed easier than installing all the gem contents in %install
> and then %exclude'ing all the extraneous stuff in %files. But I can change
> it to do that if you think it's important.

Ok, I don't see this as critical, and I think that was the only remaining issue. Looks good to me - APPROVED.

Thanks very much for your patience on this bug Dan. I really wish I'd responded sooner. I had my first child in July and changed jobs last month so it's been a busy latter half of this year :)

Comment 7 Dan Callaghan 2014-12-19 04:39:06 UTC
No worries Ken, thanks for the review :-)

Comment 8 Dan Callaghan 2014-12-19 04:45:01 UTC
New Package SCM Request
=======================
Package Name: rubygem-unicode
Short Description: Unicode normalization library for Ruby
Upstream URL: http://www.yoshidam.net/Ruby.html#unicode
Owners: dcallagh
Branches: f20 f21 epel7
InitialCC:

Comment 9 Gwyn Ciesla 2014-12-19 13:33:53 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2014-12-23 03:00:35 UTC
rubygem-unicode-0.4.4.1-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/rubygem-unicode-0.4.4.1-2.fc21

Comment 11 Fedora Update System 2014-12-23 03:01:01 UTC
rubygem-unicode-0.4.4.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/rubygem-unicode-0.4.4.1-2.fc20

Comment 12 Fedora Update System 2014-12-23 03:01:33 UTC
rubygem-unicode-0.4.4.1-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/rubygem-unicode-0.4.4.1-2.el7

Comment 13 Fedora Update System 2014-12-23 18:33:33 UTC
rubygem-unicode-0.4.4.1-2.fc21 has been pushed to the Fedora 21 testing repository.

Comment 14 Fedora Update System 2015-01-06 06:09:06 UTC
rubygem-unicode-0.4.4.1-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 15 Fedora Update System 2015-01-06 06:12:01 UTC
rubygem-unicode-0.4.4.1-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 16 Mamoru TASAKA 2015-01-07 07:21:33 UTC
F-21 and above needs gem.build_complete (see bug 1179543)

Comment 17 Fedora Update System 2015-01-07 19:31:28 UTC
rubygem-unicode-0.4.4.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.