Description of problem: The feature request is to implement the Online crash consistent snapshot feature for glusterfs volumes, which can then be used to provide a point-in-time view of the entire volume with backup and restore capabilities of the volume(s). Using this feature, an admin can take scheduled or unscheduled snapshots of and thereby backup a Glusterfs volume. This also provides a check-point in time to restore to, if and when necessary. In virtual machine hosted environment, this feature also provides a mechanism to take snapshots of the vm-disks. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: http://www.gluster.org/community/documentation/index.php/Features/snapshot https://forge.gluster.org/snapshot/pages/Home
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#1) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#2) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#3) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#4) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#5) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#6) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature.) posted (#7) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#8) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#9) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#10) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#11) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#12) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#13) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#14) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#15) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#16) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#17) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#18) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#19) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7128 (gluster: GlusterFS Volume Snapshot Feature) posted (#20) for review on master by Avra Sengupta (asengupt)
COMMIT: http://review.gluster.org/7128 committed in master by Vijay Bellur (vbellur) ------ commit 29bccc2ed18eedc40e83d2f0d35327037a322384 Author: Avra Sengupta <asengupt> Date: Wed Feb 19 16:30:11 2014 +0530 gluster: GlusterFS Volume Snapshot Feature This is the initial patch for the Snapshot feature. Current patch includes following features: * Snapshot create * Snapshot delete * Snapshot restore * Snapshot list * Snapshot info * Snapshot status * Snapshot config Change-Id: I2f46920c0d61c515f6a60e0f8b46fff886d9f6a9 BUG: 1061685 Signed-off-by: shishir gowda <sgowda> Signed-off-by: Sachin Pandit <spandit> Signed-off-by: Vijaikumar M <vmallika> Signed-off-by: Raghavendra Bhat <raghavendra> Signed-off-by: Rajesh Joseph <rjoseph> Signed-off-by: Joseph Fernandes <josferna> Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/7128 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list.) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#1) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#2) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/7483 (mgmt/glusterd: autodeletion of snaps upon create whenver snap limit exceeds) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#3) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#4) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#5) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/7483 (mgmt/glusterd: autodeletion of snaps upon create whenver snap limit exceeds) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7494 (mgmt/glusterd: handle postvalidate carefully when prevalidate fails) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#1) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#6) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#2) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#3) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#4) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list) posted (#4) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#4) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.) posted (#4) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list.) posted (#5) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot) posted (#5) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list) posted (#5) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#7) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#8) for review on master by Joseph Fernandes (josferna)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list) posted (#6) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot) posted (#6) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.) posted (#6) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list.) posted (#7) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot) posted (#7) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list) posted (#7) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#5) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list) posted (#8) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#8) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7524 (glusterd: Rename the export dictionary as peer_data) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7525 (glusterd/snapshot: Compare and update snapshots during peer handshake) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#6) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot) posted (#7) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot.) posted (#1) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot) posted (#8) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot) posted (#9) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot) posted (#10) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot) posted (#11) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot.) posted (#2) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot) posted (#12) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#3) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot..) posted (#13) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#3) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list) posted (#9) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#9) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.) posted (#9) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7525 (glusterd/snapshot: Compare and update snapshots during peer handshake) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7524 (glusterd: Rename the export dictionary as peer_data) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7550 (glusterd: Fetch brick mount_dirs during brick create) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7551 (glusterd/snashot: Perform missed snap creates) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7550 (glusterd: Fetch brick mount_dirs during brick create) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7551 (glusterd/snashot: Perform missed snap creates) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list) posted (#10) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#10) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.) posted (#10) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7525 (glusterd/snapshot: Compare and update snapshots during peer handshake) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7524 (glusterd: Rename the export dictionary as peer_data) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot..) posted (#14) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#4) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7558 (glusterd: Allow symlink parent for snap_mount_folder) posted (#1) for review on master by Harshavardhana (harsha)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot..) posted (#15) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#5) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot..) posted (#16) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#6) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7561 (glusterd/snapshot : Barrier code integration with snapshot codebase.) posted (#1) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7454 (glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list) posted (#11) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#11) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7453 (glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.) posted (#11) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7525 (glusterd/snapshot: Compare and update snapshots during peer handshake) posted (#4) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7524 (glusterd: Rename the export dictionary as peer_data) posted (#4) for review on master by Avra Sengupta (asengupt)
COMMIT: http://review.gluster.org/7453 committed in master by Vijay Bellur (vbellur) ------ commit 0af287791f0d50b5d2975cb2e2c902c797b05860 Author: Avra Sengupta <asengupt> Date: Wed Apr 2 05:39:22 2014 +0000 glusterd/snapshot-handshake: Perform handshake of missed_snaps_list. In a handshake, create a union of the missed_snap_lists of the two peers. If an entry is present, its no op. If an entry is pendng, and the peer entry is done, mark own entry as done. If an entry is done, and the peer ertry is pending, its a no-op. If its a new entry, add it. Change-Id: Idbfa49cc34871631ba8c7c56d915666311024887 BUG: 1061685 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/7453 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot..) posted (#17) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#7) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#18) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#8) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7561 (glusterd/snapshot : Barrier code integration with snapshot codebase.) posted (#2) for review on master by Sachin Pandit (spandit)
COMMIT: http://review.gluster.org/7454 committed in master by Vijay Bellur (vbellur) ------ commit d7b3e068290c41b13ecd664771814202d7d26881 Author: Avra Sengupta <asengupt> Date: Mon Apr 7 05:25:28 2014 +0000 glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list Persisting missing snapshot info on disk as well as in memory in the following format: -------------NODE-UUID--------------:--------------SNAP-UUID-------------=---------SNAP-VOL-ID------------:BRICKNUM:-------BRICKPATH--------:OPERATION:STATUS 927cb5fe-63da-48f5-82f6-e6a09ddc81c4:8258b18f-d408-483d-8239-204039dc6397=a17b4fe42c5a45f7a916438643edaa13: 3 :/brick/brick-dirs/brick3: 1 : 1 927cb5fe-63da-48f5-82f6-e6a09ddc81c4:8258b18f-d408-483d-8239-204039dc6397=a17b4fe42c5a45f7a916438643edaa13: 3 :/brick/brick-dirs/brick3: 3 : 1 927cb5fe-63da-48f5-82f6-e6a09ddc81c4:8258b18f-d408-483d-8239-204039dc6397=83a3cc05453b46b2a7eda4c9a9208638: 3 :/brick/brick-dirs/brick3: 1 : 1 This data will be stored on disk at /var/lib/glusterd/snaps/missed_snaps_list In memory we maintain the data as a list of glusterd_missed_snap_info in conf, the key for this list are the first two fields, i.e NODE-UUID:SNAP-UUID. For every NODE-UUID:SNAP-UUID, there can be multiple operations missed on multiple bricks. So we maintain a list of glusterd_snap_op_t for every node of glusterd_missed_snap_info This list is maintained or updated during snapshot create, delete, and restore operations which are the only operations that if missed, are recorded in this list. During snapshot create, if a node is down, or a brick is down, we don't receive their mount point infos. snap_status of such bricks is marked as -1, and their brick details are added to this list. During snapshot delete, we check from originator node, if any other nodes, holding bricks of the said snap are down. Those are also added to the list. Also if the node is up, but the snapshot was pending for a snap brick, and its snap_status is -1, we add that to the list too. When a subsequent delete entry is processed for an already existing create entry, we just mark the create entries status as done (2), and don't add the delete entry to the list. During snapshot restore, we check from originator node, if any other nodes, holding bricks of the said snap are down. Those are also added to the list. Also if the node is up, but the snapshot was pending for a snap brick, and its snap_status is -1, we add that to the list too. Like delete when a subsequent restore entry is processed for an already existing create entry, we just mark the create entries status as done (2), and don't add the restore entry to the list. Change-Id: I54f63e28d3c40555d0f84528f38227103171f594 BUG: 1061685 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/7454 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#4) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7561 (glusterd/snapshot : Barrier code integration with snapshot codebase.) posted (#3) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7452 (glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.) posted (#12) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7525 (glusterd/snapshot: Compare and update snapshots during peer handshake) posted (#5) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7524 (glusterd: Rename the export dictionary as peer_data) posted (#5) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7577 (glusterd/snapshot : Clean up of old barrier code.) posted (#1) for review on master by Sachin Pandit (spandit)
COMMIT: http://review.gluster.org/7452 committed in master by Vijay Bellur (vbellur) ------ commit b46d0ba04901ebca81d0f477e3e9ac6ba8607946 Author: Avra Sengupta <asengupt> Date: Thu Apr 3 03:36:28 2014 +0000 glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot. The lvm snapshots of the bricks are mounted at /var/run/gluster/snaps/ or /run/gluster/snaps. These paths being on a tempfs, on reboot are removed. So when glusterd starts, we need to recreate these paths, activate the respective logical volumes (lvm snapshots of the bricks), and mount these logical volumes at their respective paths. Change-Id: Ic5ef61e79a25d9830df717c592391965fe09db62 BUG: 1061685 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/7452 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/7524 committed in master by Vijay Bellur (vbellur) ------ commit a7c8d514c0487019d218c327deb52f7d09645875 Author: Avra Sengupta <asengupt> Date: Mon Apr 21 03:32:00 2014 +0000 glusterd: Rename the export dictionary as peer_data During a glusterd handshake, a dictionary is passed among the peers which contains, info of volumes, global opts, and now also info of snaps and list of missed snaps As it now contains more than just volume specific data, renaming the dict in the code-base from "vols" to "peer_data" Change-Id: Ib457172789ddd0d8978b08bceab0988c48e9eea7 BUG: 1061685 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/7524 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/7525 committed in master by Vijay Bellur (vbellur) ------ commit 54a5a42848870ee17b923c6c37d65fdfe4a5fec9 Author: Avra Sengupta <asengupt> Date: Tue Apr 22 00:52:57 2014 +0000 glusterd/snapshot: Compare and update snapshots during peer handshake During a peer-handshake, after the volumes have synced, and the list of missed snapshots have synced, the node will perform the pending deletes and restores on this list. At this point, the current snapshot list in the node will be updated, and hence in case of conflicts arising during snapshot handshake, the peer hosting the bricks will be given precedence Likewise, if there will be a conflict, and both peers will be in the same state, i.e either both would be hosting bricks or both would not be hosting bricks, then a decision can't be taken and a peer-reject will happen. glusterd_compare_and_update_snap() implements the following algorithm to perform the above task: Step 1: Start. Step 2: Check if the peer is missing a delete on the said snap. If yes, goto step 6. Step 3: Check if there is a conflict between the peer's data and the local snap. If no, goto step 5. Step 4: As there is a conflict, check if both the peer and the local nodes are hosting bricks. Based on the results perform the following: Peer Hosts Bricks Local Node Hosts Bricks Action Yes Yes Goto Step 7 No No Goto Step 7 Yes No Goto Step 8 No Yes Goto Step 6 Step 5: Check if the local node is missing the peer's data. If yes, goto step 9. Step 6: It's a no-op. Goto step 10 Step 7: Peer Reject. Goto step 10 Step 8: Delete local node's data. Step 9: Accept Peer Data. Step 10: Stop Change-Id: I79be0f0f5f2a4f5c72277a4e77c2be732af432e1 BUG: 1061685 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/7525 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#5) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#19) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#9) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#20) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#10) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#21) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#11) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#22) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#12) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7582 (glusterd/snapshot: Move read-only xlator to client graph) posted (#3) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#9) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#9) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#23) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#13) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7495 (glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.) posted (#24) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7527 (glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot) posted (#14) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7561 (glusterd/snapshot : Barrier code integration with snapshot codebase.) posted (#4) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7561 (glusterd/snapshot : Barrier code integration with snapshot codebase.) posted (#5) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7561 (glusterd/snapshot : Barrier code integration with snapshot codebase.) posted (#6) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7561 (glusterd/snapshot : Barrier code integration with snapshot codebase.) posted (#7) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#6) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7558 (glusterd: Allow symlink parent for snap_mount_folder) posted (#2) for review on master by Harshavardhana (harsha)
REVIEW: http://review.gluster.org/7550 (glusterd: Fetch brick mount_dirs during brick create) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7551 (glusterd/snashot: Perform missed snap creates) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7550 (glusterd: Fetch brick mount_dirs during brick create.) posted (#4) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7551 (glusterd/snashot: Perform missed snap creates) posted (#4) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#3) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#7) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7494 (mgmt/glusterd: handle postvalidate carefully when prevalidate fails) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
COMMIT: http://review.gluster.org/7577 committed in master by Vijay Bellur (vbellur) ------ commit d09b327a2796152eb80074169e17359394ae7cf8 Author: Sachin Pandit <spandit> Date: Mon Apr 28 05:58:41 2014 +0530 glusterd/snapshot : Clean up of old barrier code. As a new barrier translator is introduced, we dont require the old barrier code. Hence cleaning thar up. Change-Id: Ieedca6f33a746898f0d2332fda1f1d4c86fff98f BUG: 1061685 Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/7577 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaushal M <kaushal> Reviewed-by: Vijaikumar Mallikarjuna <vmallika> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#8) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7550 (glusterd: Fetch brick mount_dirs during brick create.) posted (#5) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7551 (glusterd/snashot: Perform missed snap creates) posted (#5) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#10) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#11) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#9) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#10) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7476 (glusterd/snapshot: Activation and De-activation of snapshot) posted (#12) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#11) for review on master by Raghavendra Bhat (raghavendra)
COMMIT: http://review.gluster.org/7561 committed in master by Vijay Bellur (vbellur) ------ commit 12f1fab930dc0f6f103bae03fab981409ed31b4e Author: Sachin Pandit <spandit> Date: Wed Apr 30 00:41:56 2014 +0530 glusterd/snapshot : Barrier code integration with snapshot codebase. As we have new barrier translator in place, we are making use of that during snapshot phase. During snapshot create (pre-commit), we enable the barrier feature and after the commit we disable it. Change-Id: I94212b1c06b0d9b12255ee98313e2d8549b34b17 BUG: 1061685 Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/7561 Reviewed-by: Kaushal M <kaushal> Reviewed-by: Atin Mukherjee <amukherj> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/7495 committed in master by Vijay Bellur (vbellur) ------ commit d12a77cb3263f79f66f48a3b9205746b7d3b50f1 Author: Sachin Pandit <spandit> Date: Tue Apr 22 08:09:18 2014 +0530 glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot. geo-rep status and conf files needs to be copied before taking a snapshot. The idea here is, when the snapshot is restored, these config and status files needs to be placed back in geo-replication folder so that geo-replication can start with the same state it was when taking a snapshot. Details : Before a snapshot is taken, Copy the status and config files present in /var/lib/glusterd/geo-replication/. The files copied are gsyncd.conf and status files of each session belonging to a volume whose snapshot is about to be taken. Change-Id: I0234ecd846883350c59777c2505290729de0ce05 BUG: 1061685 Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/7495 Reviewed-by: Kotresh HR <khiremat> Reviewed-by: Vijaikumar Mallikarjuna <vmallika> Reviewed-by: Rajesh Joseph <rjoseph> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/7527 committed in master by Vijay Bellur (vbellur) ------ commit b3031351b0e69195413f5f5b9cad2752e3eb713d Author: Sachin Pandit <spandit> Date: Sat Apr 26 14:06:47 2014 +0530 glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot Quota config and cksum file needs to be copied before taking a snapshot, so that when a snapshot is restored these files is copied back to the original place, and the restored snap volume can make use of these quota files. Before taking a snapshot the quota files are copied to /var/lib/glusterd/snaps/<snapname>/quota/ Change-Id: Id175f28d4ee47be64d7491c6aae81a1794928490 BUG: 1061685 Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/7527 Reviewed-by: Vijaikumar Mallikarjuna <vmallika> Reviewed-by: Raghavendra G <rgowdapp> Reviewed-by: Rajesh Joseph <rjoseph> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/7550 (glusterd: Fetch brick mount_dirs during brick create.) posted (#6) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7551 (glusterd/snashot: Perform missed snap creates) posted (#6) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7548 (glusterd/snapshot: Restore cleanup) posted (#5) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7550 (glusterd: Fetch brick mount_dirs during brick create.) posted (#7) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7551 (glusterd/snashot: Perform missed snap creates) posted (#7) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#12) for review on master by Raghavendra Bhat (raghavendra)
COMMIT: http://review.gluster.org/7582 committed in master by Vijay Bellur (vbellur) ------ commit b189bb33edc2582e53923dec51bdef0f118c3d36 Author: Rajesh Joseph <rjoseph> Date: Mon Apr 28 19:14:20 2014 +0530 glusterd/snapshot: Move read-only xlator to client graph read-only xlator is moved from server graph to client graph so that AFR & DHT healing can take place at server Change-Id: I140ec962330c59d3b44f9bc8084a1544a1fd6c54 BUG: 1061685 Signed-off-by: Rajesh Joseph <rjoseph> Reviewed-on: http://review.gluster.org/7582 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Reviewed-by: Sachin Pandit <spandit> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/7476 committed in master by Vijay Bellur (vbellur) ------ commit 0f56f0ce2d2e18fbb2eedf14e93b5a592f0005c3 Author: Joseph Fernandes <josferna> Date: Mon Apr 14 19:18:41 2014 +0530 glusterd/snapshot: Activation and De-activation of snapshot Previously, snapshots by default were activated on creation and there was no option to activate or deactivate them on demand. This will allow the user to activate and deactivate on demand. The CLI goes as follows 1) Activate the snap using a command "gluster snapshot activate <snapname> [force]" 2) Deactivate the snap using a command "gluster snapshot deactivate <snapname>" Note: Even now the snapshot will be activated during creation. Change-Id: I0946d800780f26c63fa1fcaf29aabc900140448f BUG: 1061685 Signed-off-by: Joseph Fernandes <josferna> Reviewed-on: http://review.gluster.org/7476 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijaikumar Mallikarjuna <vmallika> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/7548 committed in master by Vijay Bellur (vbellur) ------ commit 66f560e0071db84d430f38b996364f6b8c4f0f6d Author: Rajesh Joseph <rjoseph> Date: Wed Apr 23 18:36:34 2014 +0530 glusterd/snapshot: Restore cleanup If restores fails for some reason then we should revert the restore operation. To do so we take the backup of vols folder before doing a restore and if the restore fails then we revert the changes done. Change-Id: I97f72aec3a34fc122bf137beb336e94db3a04dff BUG: 1061685 Signed-off-by: Rajesh Joseph <rjoseph> Reviewed-on: http://review.gluster.org/7548 Reviewed-by: Santosh Pradhan <spradhan> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/7494 committed in master by Vijay Bellur (vbellur) ------ commit c6f4504c12d35359986a08da222193057946570a Author: Raghavendra Bhat <raghavendra> Date: Tue Apr 15 17:48:16 2014 +0530 mgmt/glusterd: handle postvalidate carefully when prevalidate fails * Also changed the order of peers retrieval and snapshot retrieval upon glusterd start, so that the snapshot bricks can be properly resolved while cleaning up the snapshots. Change-Id: I120704e4412a9cadb8d90a9b7969f2b4a1196bc5 BUG: 1061685 Signed-off-by: Raghavendra Bhat <raghavendra> Reviewed-on: http://review.gluster.org/7494 Reviewed-by: Kaushal M <kaushal> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/7558 committed in master by Anand Avati (avati) ------ commit 853d198e8e4e4aa5ef933432480b585ebd836533 Author: Harshavardhana <harsha> Date: Fri Apr 25 01:26:30 2014 -0700 glusterd: Allow symlink parent for snap_mount_folder If '/var' is a symlink which is on OSX, 'glusterd' initialization fails which is not necessary fix it. Change-Id: I83adc16cfc0e0deaa18acf74ba99299ba4a21d60 BUG: 1061685 Signed-off-by: Harshavardhana <harsha> Reviewed-on: http://review.gluster.org/7558 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati>
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#13) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#10) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7550 (glusterd: Fetch brick mount_dirs during brick create.) posted (#8) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7551 (glusterd/snashot: Perform missed snap creates) posted (#8) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#4) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#5) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#11) for review on master by Vijaikumar Mallikarjuna (vmallika)
COMMIT: http://review.gluster.org/7550 committed in master by Krishnan Parthasarathi (kparthas) ------ commit f846e54b8844decbc8bd73840e7d35b2dcaed2e0 Author: Avra Sengupta <asengupt> Date: Wed Apr 23 04:26:24 2014 +0000 glusterd: Fetch brick mount_dirs during brick create. Fetch the mount directory path for a brick, during volume create, add-brick, and replace-brick. When a snap-create is missed, use this mount directory information to create the brick path for the missed snap brick. Change-Id: Iad3eec96a32cf340f26bdf3f28e2f529e4b77e31 BUG: 1061685 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/7550 Reviewed-by: Rajesh Joseph <rjoseph> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
COMMIT: http://review.gluster.org/7551 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 86fccad56d2ffd6c65e1571ff87dbf625b8ce55e Author: Avra Sengupta <asengupt> Date: Tue Apr 22 10:27:23 2014 +0000 glusterd/snashot: Perform missed snap creates When a brick is started, and the glusterfsd process requests for volfile, the brick_name is sent in the req dict. In glusterd, after fetching the spec the brick_name is looked up in the missed_snap_list, and any missing snap creates on the same brick are performed. After this, the glusterd responds back with the specfile. Also collate brick data from the node's hosting the bricks during restore. In case the data is absent, the local node's data is used. This is needed to ensure that, during a restore we collect the information created when a missed snap create is performed. Change-Id: I47cefdeba96f2702be810965734cf0fac61d3d2d BUG: 1061685 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/7551 Reviewed-by: Santosh Pradhan <spradhan> Reviewed-by: Rajesh Joseph <rjoseph> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
REVIEW: http://review.gluster.org/7665 (glusterd/snapshot: volume gets deleted if restore fails) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#12) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7665 (glusterd/snapshot: volume gets deleted if restore fails) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#13) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#14) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#15) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7665 (glusterd/snapshot: volume gets deleted if restore fails) posted (#4) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#14) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#16) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#17) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7463 (mgmt/glusterd: quorum check before taking the snapshot) posted (#18) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#6) for review on master by Raghavendra Bhat (raghavendra)
COMMIT: http://review.gluster.org/7463 committed in master by Kaushal M (kaushal) ------ commit b47b46d98a5e1d3e6e9eb9bde4f81b745f2ac09d Author: Raghavendra Bhat <raghavendra> Date: Mon Apr 14 11:24:12 2014 +0530 mgmt/glusterd: quorum check before taking the snapshot without force option: quorum fails if glusterds are not in quorum. If glusterd are in quorum, then volume quorum (i.e quorum of the bricks) is checked. volume quorum fails even if one of the bricks are down. with force option: even though the glusterds are not in quorum, and some bricks are down, the quorum check of the volume (i.e bricks) is done and if the volume quorum is met, snapshot is taken. Change-Id: I06971e45d5cf09880032ef038bfe011e6c244268 BUG: 1061685 Signed-off-by: Raghavendra Bhat <raghavendra> Reviewed-on: http://review.gluster.org/7463 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Kaushal M <kaushal>
REVIEW: http://review.gluster.org/7665 (glusterd/snapshot: volume gets deleted if restore fails) posted (#5) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#15) for review on master by Rajesh Joseph (rjoseph)
REVIEW: http://review.gluster.org/7665 (glusterd/snapshot: volume gets deleted if restore fails) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#16) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#7) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#8) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/7665 (glusterd/snapshot: volume gets deleted if restore fails) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7461 (glusterd/snapshot: Execute lvm snapshots in parallel) posted (#17) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#9) for review on master by Rajesh Joseph (rjoseph)
COMMIT: http://review.gluster.org/7461 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 5dda1d4e00b8235656b7e4e8de35f599bf033148 Author: Vijaikumar M <vmallika> Date: Mon May 5 12:43:26 2014 +0530 glusterd/snapshot: Execute lvm snapshots in parallel Back-end LVM Snapshot is executed parallely as synop task This helps is gaining performance when there are more bricks in a node. This patch also removes unwanted logs printed in snapshot cleanup Change-Id: I3174cb4547ebb670eca37a98eb9d75ecb0672a90 BUG: 1061685 Signed-off-by: Vijaikumar M <vmallika> Reviewed-on: http://review.gluster.org/7461 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
COMMIT: http://review.gluster.org/7665 committed in master by Krishnan Parthasarathi (kparthas) ------ commit d74c10603196a57c5fa033aaeb55f93f7ef7b4be Author: Rajesh Joseph <rjoseph> Date: Mon May 5 14:34:55 2014 +0530 glusterd/snapshot: volume gets deleted if restore fails If the restore command fails in pre-validate phase then main volume gets deleted. Fix: Perform cleanup only when pre-validate passes. Change-Id: I7128c8582c3dd166a5683babb7e136ad0b56f0ac BUG: 1061685 Signed-off-by: Rajesh Joseph <rjoseph> Reviewed-on: http://review.gluster.org/7665 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
REVIEW: http://review.gluster.org/7587 (mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit) posted (#10) for review on master by Raghavendra Bhat (raghavendra)
COMMIT: http://review.gluster.org/7587 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 26a4b5c98e9e50ace28a9bed97f04ecea262e11d Author: Raghavendra Bhat <raghavendra> Date: Tue Apr 29 00:14:54 2014 +0530 mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit Change-Id: I2d6ebae3ced1910f2dee43eeb9fc430e9f31073f BUG: 1061685 Signed-off-by: Raghavendra Bhat <raghavendra> Reviewed-on: http://review.gluster.org/7587 Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
REVIEW: http://review.gluster.org/8019 (mgmt/glusterd: mark the snapshot as decommision before removing it) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/8019 (mgmt/glusterd: mark the snapshot as decommision before removing it) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
REVIEW: http://review.gluster.org/8060 (docs : Admin document updation for snapshot commands.) posted (#1) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/8060 (docs : Admin document updation for snapshot commands.) posted (#2) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/8060 (docs : Admin document updation for snapshot commands.) posted (#3) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/8060 (docs : Admin document updation for snapshot commands.) posted (#4) for review on master by Sachin Pandit (spandit)
COMMIT: http://review.gluster.org/8060 committed in master by Vijay Bellur (vbellur) ------ commit 2783fbed2a6a8481eadbab8ca5ad03513f7f54f4 Author: Sachin Pandit <spandit> Date: Fri Jun 13 08:55:31 2014 +0530 docs : Admin document updation for snapshot commands. Change-Id: I8460e7feed7e1b0cf37e735852f5c269adfadd77 BUG: 1061685 Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/8060 Reviewed-by: Rajesh Joseph <rjoseph> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/8165 (glusterd/snapshot: verify for lvm commands) posted (#1) for review on master by Harshavardhana (harsha)
REVIEW: http://review.gluster.org/8165 (glusterd/snapshot: verify for lvm commands) posted (#2) for review on master by Harshavardhana (harsha)
COMMIT: http://review.gluster.org/8165 committed in master by Harshavardhana (harsha) ------ commit 39209965366f9bbc1d485532496fc265874c7527 Author: Harshavardhana <harsha> Date: Tue Jun 24 15:00:59 2014 -0700 glusterd/snapshot: verify for lvm commands On non-Linux platforms we need to verify the run time availability of LVM specific commands and fail accordingly with a message. Change-Id: Ie1e3870648f01ee129e390e2240c66e0c6249b90 BUG: 1061685 Signed-off-by: Harshavardhana <harsha> Reviewed-on: http://review.gluster.org/8165 Reviewed-by: Raghavendra Bhat <raghavendra> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Sachin Pandit <spandit>
*** Bug 1091833 has been marked as a duplicate of this bug. ***
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html [2] http://supercolony.gluster.org/pipermail/gluster-users/
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report. glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html [2] http://supercolony.gluster.org/mailman/listinfo/gluster-users