Bug 1062215 - Review Request: perl-MetaCPAN-API-Tiny - A Tiny API client for MetaCPAN
Summary: Review Request: perl-MetaCPAN-API-Tiny - A Tiny API client for MetaCPAN
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-06 13:11 UTC by Paul Howarth
Modified: 2014-03-10 15:53 UTC (History)
2 users (show)

Fixed In Version: perl-MetaCPAN-API-Tiny-1.131730-3.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-10 15:53:51 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2014-02-06 13:11:40 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-MetaCPAN-API-Tiny/branches/fedora/perl-MetaCPAN-API-Tiny.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-MetaCPAN-API-Tiny/perl-MetaCPAN-API-Tiny-1.131730-2.fc21.src.rpm

Description:

This is the Tiny version of MetaCPAN::API. It implements a compatible API with
a few notable exceptions:

Attributes are direct hash access

 * The attributes defined using Mo(o|u)se are now accessed via the blessed hash
   directly. There are no accessors defined to access this elements.

Exception handling

 * Instead of using Try::Tiny, raw evals are used. This could potentially cause
   issues, so just be aware.

Testing

 * Test::Fatal was replaced with an eval implementation of exception().
   Test::TinyMocker usage is retained, but may be absorbed since it is pure
   perl.


Fedora Account System Username: pghmcfc

Comment 2 Petr Pisar 2014-02-25 14:54:26 UTC
URL and Source0 are usable. Ok.
Source archive is original (SHA-256: d43505879a0f1a476dccd8a2517e68d87b05ad473287c7788f8dbd6f8d3a9bbe). Ok.
Summary verified from lib/MetaCPAN/API/Tiny.pm. Ok.
Description verified from lib/MetaCPAN/API/Tiny.pm. Ok.
No XS code, noarch BuildArch is Ok.
License verified from LICENSE, README, lib/MetaCPAN/API/Tiny.pm. Ok.
All tests pass. Ok.

$ rpmlint perl-MetaCPAN-API-Tiny.spec ../SRPMS/perl-MetaCPAN-API-Tiny-1.131730-3.fc21.src.rpm ../RPMS/noarch/perl-MetaCPAN-API-Tiny-1.131730-3.fc21.noarch.rpm
perl-MetaCPAN-API-Tiny.src: W: spelling-error %description -l en_US se -> SE, tie, es
perl-MetaCPAN-API-Tiny.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-MetaCPAN-API-Tiny.src: W: spelling-error %description -l en_US evals -> vales, evils, ovals
perl-MetaCPAN-API-Tiny.src: W: spelling-error %description -l en_US eval -> veal, vela, val
perl-MetaCPAN-API-Tiny.src: W: spelling-error %description -l en_US TinyMocker -> Tiny Mocker, Tiny-mocker, Tinkertoy
perl-MetaCPAN-API-Tiny.noarch: W: spelling-error %description -l en_US se -> SE, tie, es
perl-MetaCPAN-API-Tiny.noarch: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-MetaCPAN-API-Tiny.noarch: W: spelling-error %description -l en_US evals -> vales, evils, ovals
perl-MetaCPAN-API-Tiny.noarch: W: spelling-error %description -l en_US eval -> veal, vela, val
perl-MetaCPAN-API-Tiny.noarch: W: spelling-error %description -l en_US TinyMocker -> Tiny Mocker, Tiny-mocker, Tinkertoy
2 packages and 1 specfiles checked; 0 errors, 10 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-MetaCPAN-API-Tiny-1.131730-3.fc21.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Feb 25 15:46 /usr/share/doc/perl-MetaCPAN-API-Tiny
-rw-r--r--    1 root    root                      306 Jun 22  2013 /usr/share/doc/perl-MetaCPAN-API-Tiny/Changes
-rw-r--r--    1 root    root                    18416 Jun 22  2013 /usr/share/doc/perl-MetaCPAN-API-Tiny/LICENSE
-rw-r--r--    1 root    root                      327 Jun 22  2013 /usr/share/doc/perl-MetaCPAN-API-Tiny/README
-rw-r--r--    1 root    root                     3458 Feb 25 15:46 /usr/share/man/man3/MetaCPAN::API::Tiny.3pm.gz
drwxr-xr-x    2 root    root                        0 Feb 25 15:46 /usr/share/perl5/vendor_perl/MetaCPAN
drwxr-xr-x    2 root    root                        0 Feb 25 15:46 /usr/share/perl5/vendor_perl/MetaCPAN/API
-rw-r--r--    1 root    root                    10893 Jun 22  2013 /usr/share/perl5/vendor_perl/MetaCPAN/API/Tiny.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-MetaCPAN-API-Tiny-1.131730-3.fc21.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(HTTP::Tiny)
      1 perl(JSON::PP)
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-MetaCPAN-API-Tiny-1.131730-3.fc21.noarch.rpm | sort | uniq -c
      1 perl(MetaCPAN::API::Tiny) = 1.131730
      1 perl-MetaCPAN-API-Tiny = 1.131730-3.fc21
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-MetaCPAN-API-Tiny-1.131730-3.fc21.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6569488). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Resolution: Package APPROVED.

Comment 3 Paul Howarth 2014-02-25 15:06:58 UTC
New Package SCM Request
=======================
Package Name: perl-MetaCPAN-API-Tiny
Short Description: A Tiny API client for MetaCPAN
Owners: pghmcfc
Branches: f19 f20 epel7
InitialCC: perl-sig

Thanks for the review Petr.

Comment 4 Gwyn Ciesla 2014-02-25 15:24:48 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-02-25 16:14:17 UTC
perl-MetaCPAN-API-Tiny-1.131730-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-MetaCPAN-API-Tiny-1.131730-3.fc20

Comment 6 Fedora Update System 2014-02-25 16:14:33 UTC
perl-MetaCPAN-API-Tiny-1.131730-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-MetaCPAN-API-Tiny-1.131730-3.fc19

Comment 7 Fedora Update System 2014-03-07 06:29:32 UTC
perl-MetaCPAN-API-Tiny-1.131730-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 8 Fedora Update System 2014-03-07 06:37:46 UTC
perl-MetaCPAN-API-Tiny-1.131730-3.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.