Description of problem:
When using spell check tool, the replaced word suggested by it does not take place after leaving Zanata page. So, even when this word is fixed at the time, after leaving Zanata page, the changes don't take place
Version-Release number of selected component (if applicable):
All projects located at https://translate.jboss.org/webtrans/translate
Replacing a word suggested by the spell checker
Steps to Reproduce:
1. Replace a word through spell checker suggestion
2. Leave the Zanata page
3. Return to the same page and check again the string where the word was originally replaced
The word suggested by spelling check is NOT replaced
The word suggested by spelling check is replaced
This feature does not work, and is also damaging to user data (presenting the correct data but failing to save it).
The underlying technology - CodeMirror - does not receive a notification that something has changed. The best course of action is to set the plain text to default and codemirror as an option, but with caveats (no spell check).
"Setting plain text as default", IMHO, only apply for new users.
Do we have any plan to migrate the existing users?
There's no migration - it's not a data issue. It's a presentation issue that, if someone desperately needs the tag highlighting for, can enable if desired.
I just hope the users of the codemirror editor don't assume that the lack of red underlines means that their spelling is perfect.
(In reply to Damian Jansen from comment #4)
> There's no migration - it's not a data issue. It's a presentation issue
> that, if someone desperately needs the tag highlighting for, can enable if
Problem is, even when you change default, it does not help the existing users.
How do you tell the existing users that spell check does not work with Code mirror?
Changes discussed in meeting:
- remove option to enable or disable spellchecking
- restore option to use syntax highlighting editor (use user preference)
- option does not need to be saved automatically when toggling with the tooltip
- show warnings as tooltip on the syntax highlighting editor selection option (and optionally as a popup), warning about:
- spellcheck issues with syntax highlighting editor
- unicode issues with syntax highlighting editor
(In reply to David Mason from comment #8)
> Changes discussed in meeting:
> - remove option to enable or disable spellchecking
(because spellcheck will be permanently disabled for codemirror)
> - restore option to use syntax highlighting editor (use user preference)
> - option does not need to be saved automatically when toggling with the
Toggling with the tooltip???
Using the keyboard shortcut should toggle the option in the editor options panel.
Option does not need to be auto-saved as a user preference *as part of this story*.
> - show warnings as tooltip on the syntax highlighting editor selection
> option (and optionally as a popup), warning about:
We shouldn't hide the warnings behind a tooltip; we should add an extra line if we need it.
> - spellcheck issues with syntax highlighting editor
actually no spell check at all
> - unicode issues with syntax highlighting editor
I imagined something like
[x] use syntax-highlighting editor
(Not recommended: no spellcheck, some Unicode issues)
Which reminds me: we should have analytics to find out how often codemirror is actually used. But not as part of this story.
as a workaround, user now is able to use ctrl-alt-h or ctrl-x then h to toggle between syntax highlight or plain text editor for current active row. It's a lot quicker to access good/working parts of both editor.
comment 11 has an error. the shortcut will be ctrl-alt-h or alt-x then h.
Tested with Zanata 3.4.0-SNAPSHOT (git-server-3.3.1-250-gfd7452f)
The functionality is there, however,
After pressing alt-x, the 'h' did not show in attention dialog.
Created attachment 891721 [details]
"Toggle syntax highlighter" was not shown in attention menu
fixed in latest commit
VERIFIED with Zanata 3.4.0-SNAPSHOT (git-server-3.3.1-257-gb0acc77)
*** Bug 1024130 has been marked as a duplicate of this bug. ***