Spec URL: http://bgilbert.fedorapeople.org/openslide-python.spec SRPM URL: http://bgilbert.fedorapeople.org/openslide-python-0.5.1-1.fc20.src.rpm Description: The OpenSlide library allows programs to access virtual slide files regardless of the underlying image format. This package allows Python programs to use OpenSlide. Fedora Account System Username: bgilbert
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6505877 rpmlint output: openslide-python.spec: W: invalid-url Source0: https://github.com/openslide/openslide-python/releases/download/v0.5.1/openslide-python-0.5.1.tar.xz HTTP Error 403: Forbidden invalid-url is a false positive: GET works but HEAD does not (Amazon S3 limitation). wget works fine.
Having some troubles running fedora-review on my centos box. May have to file some bugs there.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python *** Please see https://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once Use the with_python3 mechanism to allow this to work on EL6. [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openslide- python3 [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openslide-python-0.5.1-1.fc21.noarch.rpm openslide-python3-0.5.1-1.fc21.noarch.rpm openslide-python-0.5.1-1.fc21.src.rpm openslide-python.src: W: invalid-url Source0: https://github.com/openslide/openslide-python/releases/download/v0.5.1/openslide-python-0.5.1.tar.xz HTTP Error 403: Forbidden 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint openslide-python3 openslide-python 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- openslide-python3 (rpmlib, GLIBC filtered): openslide python(abi) python3-pillow openslide-python (rpmlib, GLIBC filtered): openslide python(abi) python-pillow Provides -------- openslide-python3: openslide-python3 openslide-python: openslide-python Source checksums ---------------- https://github.com/openslide/openslide-python/releases/download/v0.5.1/openslide-python-0.5.1.tar.xz : CHECKSUM(SHA256) this package : 25c91f151cc2cf263c222f02abf7746dedc4f30214a7e724241967898868a383 CHECKSUM(SHA256) upstream package : 25c91f151cc2cf263c222f02abf7746dedc4f30214a7e724241967898868a383
Thanks for the review. %with_python3: Done. (Note that OpenSlide Python requires OpenSlide >= 3.4.0, which I don't expect will ever be packaged for EPEL 6 due to the EPEL updates policy. But the EL 7 beta doesn't seem to have Python 3 either.) %check: The package doesn't have a test suite. Even if it did, running it would be impractical due to the size of the test data. spec and SRPM updated. New scratch builds: rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6515712 epel7: http://koji.fedoraproject.org/koji/taskinfo?taskID=6515714
LGTM
New Package SCM Request ======================= Package Name: openslide-python Short Description: Python bindings for the OpenSlide library Owners: bgilbert Branches: f19 f20 epel7 InitialCC:
Git done (by process-git-requests).