Bug 1020066 introduced quoting and escaping of arguments passed to the execute operation of a script server resource. The implementation sets quoting to disabled by default in order preserve the legacy behavior. However, we should set this to true by default for any newly created resources. This is because all supported platforms support quoting of command-line arguments and users just expect quoting to work. The legacy behavior provides no purpose outside of custom script implementations that users may have implemented to workaround this deficiency. For those legacy resources, it makes sense that we leave things as they are. However, for any new resources, we should start doing this the right way. As this will be a change in default behavior this change should only be made at a minor or major release with proper documentation in the release notes. Therefore, I have captured this BZ as the official request and tracking to make this change pending the product teams approval.
Clearing needinfo, was a mistake
Fixed in master commit ac9a5507af34a31947f92265a9ce62755102257e Author: Thomas Segismont <tsegismo> Date: Mon Sep 15 11:53:55 2014 +0200 Changed "quotingEnabled" attribute default value Made ScriptDiscoveryComponent implement ResourceUpgradeFacet Tracking upgraded resources with an hidden plugin config property ("quotingEnabledNeedsUpgrade") Logging message when a Script Server component is started and "quotingEnabled" property is missing Updated the "getConfiguredEscapeCharacter" method of the Script Server component class
branch: release/jon3.3.x link: https://github.com/rhq-project/rhq/commit/69bc9048b time: 2014-09-24 15:00:53 +0200 commit: 69bc9048b19cb7d93a76a60a7bac0617ca4a4c25 author: Thomas Segismont - tsegismo message: Bug 1062789 - Set quoting to enabled for newly created script server resources Changed "quotingEnabled" attribute default value Made ScriptDiscoveryComponent implement ResourceUpgradeFacet Tracking upgraded resources with an hidden plugin config property ("quotingEnabledNeedsUpgrade") Logging message when a Script Server component is started and "quotingEnabled" property is missing Updated the "getConfiguredEscapeCharacter" method of the Script Server component class (cherry picked from commit ac9a5507af34a31947f92265a9ce62755102257e) Signed-off-by: Libor Zoubek <lzoubek>
Moving to ON_QA as available for test with build: https://brewweb.devel.redhat.com/buildinfo?buildID=388959
Verified on JON 3.3 ER04 Imported new script server resource and verified that 'Enable Quoting of Arguments' has value Yes. Verified that the quoting of arguments work in execute operation on script server resource.