Bug 1063039 - Review Request: rubygem-em-http-request - EventMachine based, async HTTP Request client
Review Request: rubygem-em-http-request - EventMachine based, async HTTP Requ...
Status: CLOSED DEFERRED
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Mo Morsi
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2014-02-09 12:59 EST by Nitesh Narayan Lal
Modified: 2016-02-08 08:56 EST (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-07-22 02:42:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmorsi: fedora‑review?


Attachments (Terms of Use)

  None (edit)
Description Nitesh Narayan Lal 2014-02-09 12:59:35 EST
Spec URL: http://niteshnarayan.fedorapeople.org/SPECS/rubygem-em-http-request-1.1.2.spec
SRPM URL: http://niteshnarayan.fedorapeople.org/SRPMS/rubygem-em-http-request-1.1.2-1.fc19.src.rpm 
Description: EventMachine based, async HTTP Request client
Fedora Account System Username:
niteshnarayan
Comment 1 Mo Morsi 2014-02-20 09:20:24 EST
Taking this one. Couple of preliminary things:

- this depends on rubygem-http_parser.rb which isn't in Fedora, that will need to be built & pushed before this can be officially built in koji. Will wait till we sort out that gem before running the builds for this

- There seems to be an extraneous %gem_install in the %check section, please remove

- Please consider rm'ing the directories which you currently %exclude in the file list. Would result in a much cleaner / consolidated files list

- Upstream indicates the project is licensed under the MIT license in the README but there is no separate license file. Please file an issue w/ the upstream project to include this

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

- Note while it doesn't directly impact this gem, this upstream issue is related:

https://github.com/igrigorik/em-websocket/pull/110
Comment 2 Miroslav Suchý 2015-07-21 11:01:39 EDT
Nitash, any progress here?
Comment 3 Nitesh Narayan Lal 2015-07-21 13:07:05 EDT
Nope unfortunately I am surrounded by loads of day job and other responsibilities. I didn't get time to continue this further, sorry for that.

Note You need to log in before you can comment on or make changes to this bug.