Spec URL: http://niteshnarayan.fedorapeople.org/SPECS/rubygem-em-websocket-0.5.0.spec SRPM URL: http://niteshnarayan.fedorapeople.org/SRPMS/rubygem-em-websocket-0.5.0-1.fc19.src.rpm Description: EventMachine based WebSocket server Fedora Account System Username:
This package won't build with mock. %check section must be after %install.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: b6255d70a4afa8222d5c6c5a05ef12f4 em-websocket-0.5.0.gem b6255d70a4afa8222d5c6c5a05ef12f4 em-websocket-0.5.0.gem.new OK - Package needs ExcludeArch OK - BuildRequires correct OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package obey's FHS standard FAILS - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. FAILS - No rpmlint output. FAILS - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) SHOULD Items: FAILS - Should build in mock. FAILS - Should build on all supported archs FAILS - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Group tag is deprecated since F17, you shouldn't use it anymore. 2. The package doesn't build in mock (check %check section). 3. Provides tag is missing. You need this: Provides: rubygem(%{gem_name}) = %{version} 3. em-http-request seems to be a Require, and it isn't in Fedora 4. You must remove binary extension sources and build leftovers. Add this: # Remove the binary extension sources and build leftovers. rm -f %{buildroot}/%{gem_instdir}/Rakefile rm -f %{buildroot}/%{gem_instdir}/em-websocket.gemspec rpmlint output: $ rpmlint rubygem-em-websocket-0.5.0-1.fc19.src.rpm rubygem-em-websocket.src: E: invalid-spec-name rubygem-em-websocket.src:56: W: mixed-use-of-spaces-and-tabs (spaces: line 56, tab: line 51) 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
Additionally: - http_parser.rb is not yet in fedora / needs to be submitted - related, this upstream issue affects the em-websocket & em-http-request submission: https://github.com/igrigorik/em-websocket/pull/110 - If a new release isn't cut w/ the updated dependency we will have to patch em-websocket to include the upstream patches satisfying the dep - Didn't see an external license file, would be nice to file an issue upstream requesting this: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text Thanks
Final changes made: SPEC:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-em-socksify.spec SRPM:http://niteshnarayan.fedorapeople.org/SRPMS/rubygem-em-socksify-0.3.0-8.fc20.src.rpm
Please disregard the earlier comment, there is still work to be done here.
Any progress here?
Nope unfortunately I am surrounded by loads of day job and other responsibilities. I didn't get time to continue this further, sorry for that.