Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1063064

Summary: [engine][network] Allow big ranges in MacPoolManager
Product: [Retired] oVirt Reporter: Mike Kolesnik <mkolesni>
Component: ovirt-engine-coreAssignee: Martin Mucha <mmucha>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4CC: bugs, gklein, iheim, lvernia, masayag, mburman, mpavlik, obasan, rbalakri, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: network
Fixed In Version: ovirt-engine-3.5.0_beta Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1077284 (view as bug list) Environment:
Last Closed: 2014-10-17 12:31:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1077284    

Description Mike Kolesnik 2014-02-09 19:55:30 UTC 
Description of problem:
When trying to initialize a large range, for example 00:1A:4A:01:00:00-00:1A:4A:FF:FF:FF, with a large MaxMacsCountInPool value, an OOM error would occur.


Version-Release number of selected component (if applicable):


How reproducible:
100%


Steps to Reproduce:
1. engine-config -s MaxMacsCountInPool=16777216
2. engine-config -s MacPoolRanges=00:1A:4A:01:00:00-00:1A:4A:FF:FF:FF
3. start the engine

Actual results:
You will see in the log something similar to 
2014-02-09 19:57:44,368 INFO  [org.ovirt.engine.core.bll.network.MacPoolManager] (org.ovirt.thread.pool-4-thread-1) MacPoolManager(4dccea71): Start initializing

Later the initialization would fail (no log for this though) and you would start seeing OutOfMemoryError popping up during the application run.

Expected results:
The MacPoolManager should finish initializing (shouldn't take very long).


Additional info:
The internal implementation of MacPoolManager should be changed to something more CU & memory efficient that a set containing all unallocated MACs.
Comment 1 Sandro Bonazzola 2014-10-17 12:31:05 UTC 
oVirt 3.5 has been released and should include the fix for this issue.