Bug 1063112 - Client push in dryRun mode should not invoke CopyTrans
Summary: Client push in dryRun mode should not invoke CopyTrans
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Zanata
Classification: Retired
Component: Component-Maven, Component-zanata-client
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.3
Assignee: Sean Flanigan
QA Contact: Zanata-QA Mailling List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-10 03:24 UTC by Sean Flanigan
Modified: 2014-03-20 05:47 UTC (History)
2 users (show)

Fixed In Version: 3.3.0-SNAPSHOT (20140218-0947)
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-03-20 05:47:28 UTC
Embargoed:

Attachments (Terms of Use)
Screenshot showing CopyTrans invoked in dry run mode (112.91 KB, image/png)
2014-02-10 03:24 UTC, Sean Flanigan 		no flags Details
View All

Description Sean Flanigan 2014-02-10 03:24:57 UTC 
Created attachment 861225 [details]
Screenshot showing CopyTrans invoked in dry run mode

Description of problem:
When copyTrans was split out into a separate REST call, we failed to disable copyTrans when the dryRun option is set.  Dry run should skip all mutation operations (local or remote), so copyTrans should be skipped.

Version-Release number of selected component (if applicable):
Probably 3.2, but we should check when the REST call was first split out.

How reproducible:
100%

Steps to Reproduce:
1. push source documents, using the dryRun option
2. observe log messages

Actual results:
"Running Copy Trans for..."

Expected results:
"Skipping Copy Trans for..." (or similar)

Additional info:
Comment 1 Sean Flanigan 2014-02-11 04:57:13 UTC 
https://github.com/zanata/zanata-client/pull/12

Also backported to client 3.2.1-SNAPSHOT as https://github.com/zanata/zanata-client/commit/76a3972f9ce89bcf91626105820f4e123de7c272
Comment 2 Damian Jansen 2014-02-19 06:22:16 UTC 
Verified at 1bf60cc19d6941929f586c3e8d62390fbb41644d
Comment 3 Sean Flanigan 2014-03-20 05:47:28 UTC 
Closing VERIFIED bugs for Zanata server 3.3.2.
Note You need to log in before you can comment on or make changes to this bug.