Bug 1063471 - RFE: virt-install: replace --force with fine grained --skipcheck collide=on,sizesparse=off,...
Summary: RFE: virt-install: replace --force with fine grained --skipcheck collide=on,s...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-10 19:43 UTC by Cole Robinson
Modified: 2015-04-11 23:50 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-04-11 23:50:09 UTC
Embargoed:


Attachments (Terms of Use)

Description Cole Robinson 2014-02-10 19:43:01 UTC
There are a few validation checks that virt-install does which are generally useful, but users may want to override in certain situations. When these checks fail, they tell the user 'use --force to override'. However --force is a heavy hammer that may disable other checks the user doesn't want to skip.

We should deprecate --force and add a more fine grained option --skipcheck, which can be used to disable specific checks. Then the error message can say 'use --skipcheck FOO=off' and won't disable possibly useful validation.

Additionally, any disabled checks should be converted to logging.warn just so they are documented somewhere.

Comment 1 Cole Robinson 2015-04-11 23:50:09 UTC
commit 93f826a8b2ca21e9cb91a870acef1c37f43dfda3
Author: Cole Robinson <crobinso>
Date:   Sat Apr 11 19:25:46 2015 -0400

    cli: Replace add --check option (bz 1063471)
    
    For fine grained enabling/disabling validation checks. Use this to
    replace the heavy handed --force option.


Note You need to log in before you can comment on or make changes to this bug.