Bug 1063488
| Summary: | After smartcard reader is removed coolkey returns a spurious error from C_GetTokenEvent(). | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Roshni <rpattath> | ||||||||
| Component: | coolkey | Assignee: | Bob Relyea <rrelyea> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Asha Akkiangady <aakkiang> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 7.0 | CC: | aakkiang, mclasen, rmainz, rrelyea, rstrode | ||||||||
| Target Milestone: | rc | Keywords: | Regression | ||||||||
| Target Release: | 7.1 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | coolkey-1.1.0-28.el7 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-03-05 11:12:09 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1113520 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Roshni
2014-02-10 20:47:37 UTC
Roshni, Just to be clear, after step 3, you replace the smart card reader and card, correct? Otherwise you are getting exactly what we expect (removing the reader is exactly the same as removing the smart card). bob After Step 3, I re-insert the smartcard reader into the usb slot with the same card that locked the screen. It does not detect the card and prompt for the pin and login fails if I provide the smartcard pin. Testcase for the bug https://tcms.engineering.redhat.com/case/339222/?from_plan=11622 So this is readily reproducible. You don't even need to force smartcard. It looks like the problem is this code:
+ this._smartcardManager.connect('smartcard-inserted',•
+ Lang.bind(this, function(token) {•
+ if (this._isLocked && token.UsedToLogin)•
+ this._liftShield(true, 0);•
+ }));•
the problem is function should have two parametrs (so it should be function(manager, token) not just function(token)). Since we were neglecting the manager parameter, a manager object was getting stuffed into the token parameter. UsedToLogin was thus always evaulating to undefined.
I don't know how this bug snuck past my initial testing of the code. I can only guess I refactored things before landing the final patch and forgot to retest that particular code path. Anyway, will build fix now.
Created attachment 915870 [details]
Comment
(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).
For that amount of data, an attachment would be preferred. Created attachment 875944 [details]
content of /var/log/messages
/var/log/messages is added as an attachment to the bug
Created attachment 876003 [details]
output of /usr/libexec/gnome-settings-daemon --debug
So this line is interesting: (gnome-settings-daemon:4798): smartcard-plugin-WARNING **: smartcard event function failed. It means the smartcard driver is returning an error unexpectedly. I added a bit of code to gnome-settings-daemon-3.8.6.1-8.el7 to try to cope with this sort of scenario. Please try upgrading gnome-settings-daemon. See bug 1061785 for more details. Does not see the issue with gnome-settings-daemon-3.8.6.1-8.el7, because of the warning message in comment 12, changing the component to coolkey. Roshni, do you mean you no longer see the issue? Is this still a blocker? If we have a spurious error from coolkey that isn't causing an issue we should just move it to 7.1. bob r+ dev ack for 7.1 (Asha's change and my comment collided. Bob, I do not see the issue after updating to gnome-settings-daemon-3.8.6.1-8.el7 Thanks Roshni, I've updated the comment to match the current problem this bug describes. fixed in coolkey-1.1.0-28.el7 Verified on coolkey-1.1.0-28.el7 by executing the steps in comment 0 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0504.html |