Bug 1063916

Setting target release to current version for consideration and review. please
do not push non-RFE bugs to an undefined target release to make sure bugs are
reviewed for relevancy, fix, closure, etc.

(In reply to Dafna Ron from comment #0)
> Created attachment 861852 [details]
> logs
> 
> Description of problem:
> 
> I created a new master domain and there was a typo in the access list for 1
> out of my two hosts which meant that the host could not see the vg. 
> the master domain was created any way and the host became non-operational. 
> I think that in the past, when we created a domain and it was not visible
> from all hosts during the create, we would fail action and not move the host
> to non-operational. 

The behaviour that checks visibility is for extending an existing domain, not creating a new one.
When creating the first (master) domain there are no hosts which are functional so there is no point in limiting this.
In addition, we are getting rid of the master domain which will change the entire flow here.

> 
> Version-Release number of selected component (if applicable):
> 
> ovirt-engine-backend-3.4.0-0.7.beta2.el6.noarch
> 
> How reproducible:
> 
> 100%
> 
> Steps to Reproduce:
> 1. in two hosts cluster expose a new iscsi lun to only one of the hosts
> 2. in webadmin -> new domain dialogue -> select the host that can see the
> lun and discover target -> create the domain
> 3.
> 
> Actual results:
> 
> we create the domain even when its not visible from both hosts and move the
> second host to non-operational. 
> 
> Expected results:
> 
> we should fail the command if we cannot see the lun from all hosts during
> create storage command.
> 
> Additional info:
> logs
> 
> in the engine log, I can see creating the domain: 
> 2014-02-11 09:40:58,956 INFO 
> [org.ovirt.engine.core.bll.storage.AddSANStorageDomainCommand]
> (ajp--127.0.0.1-8702-11) [4c4e847c] Running command:
> AddSANStorageDomainCommand internal: false. Entities affected :  ID:
> aaa00000-0000-0000-000
> 0-123456789aaa Type: System
> 2014-02-11 09:40:58,972 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateVGVDSCommand]
> (ajp--127.0.0.1-8702-11) [4c4e847c] START, CreateVGVDSCommand(HostName =
> orange-vdsf, HostId = 638b1f60-8095-4dab-9143-d835a0ece16e, storageDoma
> inId=bb179c25-dd30-48ef-81ca-fefd5c5ca094, deviceList=[3514f0c59af400017],
> force=false), log id: 410bb23f
> 
> Sync runs on create pool but I can't see any actual sync to the second host: 
> 
> 2014-02-11 09:41:05,060 INFO 
> [org.ovirt.engine.core.bll.storage.AttachStorageDomainToPoolCommand]
> (ajp--127.0.0.1-8702-4) [68829ce8] Running command:
> AttachStorageDomainToPoolCommand internal: false. Entities affected :  ID:
> bb179c25-dd30-48ef-81ca-fefd5c5ca094 Type: Storage
> 2014-02-11 09:41:05,072 INFO 
> [org.ovirt.engine.core.bll.storage.AddStoragePoolWithStoragesCommand]
> (ajp--127.0.0.1-8702-4) [1a648fcb] Lock Acquired to object EngineLock
> [exclusiveLocks= key: 53771658-e350-42bc-b505-22d11dca7678 value: POOL
> , sharedLocks= ]
> 2014-02-11 09:41:05,081 INFO 
> [org.ovirt.engine.core.bll.storage.AddStoragePoolWithStoragesCommand]
> (ajp--127.0.0.1-8702-4) [1a648fcb] Running command:
> AddStoragePoolWithStoragesCommand internal: true. Entities affected :  ID:
> 53771658-e350-42bc-b505-22d11dca7678 Type: StoragePool
> 2014-02-11 09:41:05,182 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.ConnectStorageServerVDSCommand]
> (ajp--127.0.0.1-8702-4) [1a648fcb] START,
> ConnectStorageServerVDSCommand(HostName = orange-vdsf, HostId =
> 638b1f60-8095-4dab-9143-d835a0ece16e, storagePoolId =
> 53771658-e350-42bc-b505-22d11dca7678, storageType = ISCSI, connectionList =
> [{ id: 70ca14d2-e488-481f-9f9f-c212b7244e07, connection: 10.35.162.3, iqn:
> iqn.2008-05.com.xtremio:001e675b8ee1, vfsType: null, mountOptions: null,
> nfsVersion: null, nfsRetrans: null, nfsTimeo: null };]), log id: 62e25e6f
> 2014-02-11 09:41:05,265 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.ConnectStorageServerVDSCommand]
> (ajp--127.0.0.1-8702-4) [1a648fcb] FINISH, ConnectStorageServerVDSCommand,
> return: {70ca14d2-e488-481f-9f9f-c212b7244e07=0}, log id: 62e25e6f
> 2014-02-11 09:41:05,267 INFO 
> [org.ovirt.engine.core.bll.storage.SyncLunsInfoForIscsiStorageDomainCommand]
> (ajp--127.0.0.1-8702-4) [2ae15a7a] Running command:
> SyncLunsInfoForIscsiStorageDomainCommand internal: true. Entities affected :
> ID: bb179c25-dd30-48ef-81ca-fefd5c5ca094 Type: Storage
> 
> Only during Activate storage domain we actually try to get vg info on the
> second host: 
> 
> 2014-02-11 09:41:31,453 INFO 
> [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand]
> (ajp--127.0.0.1-8702-4) [2fed8cf2] Lock Acquired to object EngineLock
> [exclusiveLocks= key: bb179c25-dd30-48ef-81ca-fefd5c5ca094 value: STORAGE
> , sharedLocks= ]
> 2014-02-11 09:41:31,462 INFO 
> [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand]
> (ajp--127.0.0.1-8702-4) [2fed8cf2] Running command:
> ActivateStorageDomainCommand internal: true. Entities affected :  ID:
> bb179c25-dd30-48ef-81ca-fefd5c5ca094 Type: Storage
> 2014-02-11 09:41:31,476 INFO 
> [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand]
> (ajp--127.0.0.1-8702-4) [2fed8cf2] Lock freed to object EngineLock
> [exclusiveLocks= key: bb179c25-dd30-48ef-81ca-fefd5c5ca094 value: STORAGE
> , sharedLocks= ]
> 2014-02-11 09:41:31,477 INFO 
> [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand]
> (ajp--127.0.0.1-8702-4) [2fed8cf2] ActivateStorage Domain. Before Connect
> all hosts to pool. Time:2/11/14 9:41 AM
> 2014-02-11 09:41:31,486 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.ConnectStorageServerVDSCommand]
> (org.ovirt.thread.pool-6-thread-12) [2fed8cf2] START,
> ConnectStorageServerVDSCommand(HostName = orange-vdsf, HostId =
> 638b1f60-8095-4dab-9143-d835a0ece16e, storagePoolId =
> 53771658-e350-42bc-b505-22d11dca7678, storageType = ISCSI, connectionList =
> [{ id: 70ca14d2-e488-481f-9f9f-c212b7244e07, connection: 10.35.162.3, iqn:
> iqn.2008-05.com.xtremio:001e675b8ee1, vfsType: null, mountOptions: null,
> nfsVersion: null, nfsRetrans: null, nfsTimeo: null };]), log id: 18c6105c
> 2014-02-11 09:41:31,488 WARN 
> [org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil]
> (org.ovirt.thread.pool-6-thread-14) Executing a command:
> java.util.concurrent.FutureTask , but note that there are 1 tasks in the
> queue.
> 2014-02-11 09:41:31,494 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.ConnectStorageServerVDSCommand]
> (org.ovirt.thread.pool-6-thread-19) [2fed8cf2] START,
> ConnectStorageServerVDSCommand(HostName = orange-vdse, HostId =
> 3cde853b-9059-420c-9e80-54bc169d2e6f, storagePoolId =
> 53771658-e350-42bc-b505-22d11dca7678, storageType = ISCSI, connectionList =
> [{ id: 70ca14d2-e488-481f-9f9f-c212b7244e07, connection: 10.35.162.3, iqn:
> iqn.2008-05.com.xtremio:001e675b8ee1, vfsType: null, mountOptions: null,
> nfsVersion: null, nfsRetrans: null, nfsTimeo: null };]), log id: 1779735b
> 2014-02-11 09:41:31,555 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.ConnectStorageServerVDSCommand]
> (org.ovirt.thread.pool-6-thread-12) [2fed8cf2] FINISH,
> ConnectStorageServerVDSCommand, return:
> {70ca14d2-e488-481f-9f9f-c212b7244e07=0}, log id: 18c6105c
> 2014-02-11 09:41:31,556 INFO 
> [org.ovirt.engine.core.bll.storage.SyncLunsInfoForIscsiStorageDomainCommand]
> (org.ovirt.thread.pool-6-thread-12) [61e541e8] Running command:
> SyncLunsInfoForIscsiStorageDomainCommand internal: true. Entities affected :
> ID: bb179c25-dd30-48ef-81ca-fefd5c5ca094 Type: Storage
> 2014-02-11 09:41:31,560 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand]
> (org.ovirt.thread.pool-6-thread-12) [61e541e8] START,
> GetVGInfoVDSCommand(HostName = orange-vdsf, HostId =
> 638b1f60-8095-4dab-9143-d835a0ece16e,
> VGID=j392UD-hQC2-RYwE-DwAe-cBMi-eacT-rNFJdN), log id: 2214b0b
> 2014-02-11 09:41:31,773 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand]
> (org.ovirt.thread.pool-6-thread-12) [61e541e8] FINISH, GetVGInfoVDSCommand,
> return: [org.ovirt.engine.core.common.businessentities.LUNs@b0087be2], log
> id: 2214b0b
> 2014-02-11 09:41:32,362 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.ConnectStorageServerVDSCommand]
> (org.ovirt.thread.pool-6-thread-19) [2fed8cf2] FINISH,
> ConnectStorageServerVDSCommand, return:
> {70ca14d2-e488-481f-9f9f-c212b7244e07=0}, log id: 1779735b
> 2014-02-11 09:41:32,363 INFO 
> [org.ovirt.engine.core.bll.storage.SyncLunsInfoForIscsiStorageDomainCommand]
> (org.ovirt.thread.pool-6-thread-19) [171aa21a] Running command:
> SyncLunsInfoForIscsiStorageDomainCommand internal: true. Entities affected :
> ID: bb179c25-dd30-48ef-81ca-fefd5c5ca094 Type: Storage
> 2014-02-11 09:41:32,366 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand]
> (org.ovirt.thread.pool-6-thread-19) [171aa21a] START,
> GetVGInfoVDSCommand(HostName = orange-vdse, HostId =
> 3cde853b-9059-420c-9e80-54bc169d2e6f,
> VGID=j392UD-hQC2-RYwE-DwAe-cBMi-eacT-rNFJdN), log id: 2910fc29
> 2014-02-11 09:41:32,518 ERROR
> [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand]
> (org.ovirt.thread.pool-6-thread-19) [171aa21a] Failed in GetVGInfoVDS method
> 2014-02-11 09:41:32,519 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand]
> (org.ovirt.thread.pool-6-thread-19) [171aa21a] Command
> org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand return value 
>  
> OneVGReturnForXmlRpc [mStatus=StatusForXmlRpc [mCode=506, mMessage=Volume
> Group does not exist: ('vg_uuid: j392UD-hQC2-RYwE-DwAe-cBMi-eacT-rNFJdN',)]]
> 
> 2014-02-11 09:41:32,520 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand]
> (org.ovirt.thread.pool-6-thread-19) [171aa21a] HostName = orange-vdse
> 2014-02-11 09:41:32,523 ERROR
> [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand]
> (org.ovirt.thread.pool-6-thread-19) [171aa21a] Command
> GetVGInfoVDSCommand(HostName = orange-vdse, HostId =
> 3cde853b-9059-420c-9e80-54bc169d2e6f,
> VGID=j392UD-hQC2-RYwE-DwAe-cBMi-eacT-rNFJdN) execution failed. Exception:
> VDSErrorException: VDSGenericException: VDSErrorException: Failed to
> GetVGInfoVDS, error = Volume Group does not exist: ('vg_uuid:
> j392UD-hQC2-RYwE-DwAe-cBMi-eacT-rNFJdN',), code = 506
> 2014-02-11 09:41:32,524 INFO 
> [org.ovirt.engine.core.vdsbroker.vdsbroker.GetVGInfoVDSCommand]
> (org.ovirt.thread.pool-6-thread-19) [171aa21a] FINISH, GetVGInfoVDSCommand,
> log id: 2910fc29
> 2014-02-11 09:41:32,524 ERROR
> [org.ovirt.engine.core.bll.storage.SyncLunsInfoForIscsiStorageDomainCommand]
> (org.ovirt.thread.pool-6-thread-19) [171aa21a] Command
> org.ovirt.engine.core.bll.storage.SyncLunsInfoForIscsiStorageDomainCommand
> throw Vdc Bll exception. With error message VdcBLLException:
> org.ovirt.engine.core.vdsbroker.vdsbroker.VDSErrorException:
> VDSGenericException: VDSErrorException: Failed to GetVGInfoVDS, error =
> Volume Group does not exist: ('vg_uuid:
> j392UD-hQC2-RYwE-DwAe-cBMi-eacT-rNFJdN',), code = 506 (Failed with error
> VolumeGroupDoesNotExist and code 506)
> 2014-02-11 09:41:32,529 INFO 
> [org.ovirt.engine.core.vdsbroker.irsbroker.ActivateStorageDomainVDSCommand]
> (ajp--127.0.0.1-8702-4) [2fed8cf2] START, ActivateStorageDomainVDSCommand(
> storagePoolId = 53771658-e350-42bc-b505-22d11dca7678, ignoreFailoverLimit =
> false, storageDomainId = bb179c25-dd30-48ef-81ca-fefd5c5ca094), log id:
> 6855e8f2