Bug 1064042 - vdsm rpm missing sanlock-python dependency
Summary: vdsm rpm missing sanlock-python dependency
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: vdsm
Version: 3.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.5.0
Assignee: Federico Simoncelli
QA Contact: Petr Beňas
URL:
Whiteboard: storage
Depends On:
Blocks: 1076889
TreeView+ depends on / blocked
 
Reported: 2014-02-11 21:21 UTC by Adam Litke
Modified: 2016-02-10 17:24 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-17 12:20:20 UTC
oVirt Team: Storage
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 25173 0 None MERGED spec: add missing requirement for sanlock on el7 Never
oVirt gerrit 25985 0 None MERGED spec: add missing requirement for sanlock on el7 Never

Description Adam Litke 2014-02-11 21:21:06 UTC
Description of problem:
VDSM requires sanlock-python in order to function but the rpm does not list the package as a dependency.

Version-Release number of selected component (if applicable):


How reproducible:
Always.

Steps to Reproduce:
1. sudo yum remove sanlock-python
2. sudo yum install vdsm
3. sudo /usr/share/vdsm/vdsm

Actual results:
Traceback (most recent call last):
  File "/usr/share/vdsm/vdsm", line 31, in <module>
    from storage.hsm import HSM
  File "/usr/share/vdsm/storage/hsm.py", line 42, in <module>
    import sp
  File "/usr/share/vdsm/storage/sp.py", line 32, in <module>
    from imageRepository.formatConverter import DefaultFormatConverter
  File "/usr/share/vdsm/storage/imageRepository/formatConverter.py", line 26, in <module>
    from storage import sd
  File "/usr/share/vdsm/storage/sd.py", line 34, in <module>
    import clusterlock
  File "/usr/share/vdsm/storage/clusterlock.py", line 27, in <module>
    import sanlock
ImportError: No module named sanlock

Expected results:
vdsm starts normally

Additional info:
As a workaround, manually install sanlock-python

Comment 1 Federico Simoncelli 2014-02-27 14:44:10 UTC
Hi Adam, you haven't specified what vdsm version was affected (or from what git hash you built from).
Anyway I spent some time on this (luckily remembering that you did some work on rhel 7) and I believe that only rhel 7 is affected.

Is that correct?

If so we should probably move this to 3.5 (even though I am sending the fix now).

Comment 2 Adam Litke 2014-02-27 17:04:32 UTC
Yeah, 3.5 is fine.  I feel like it can affect any OS but it depends on how you install vdsm.  I started from a minimal install and relied on yum to pull in all of the dependencies and it did not install sanlock-python.  It doesn't seem to be commonly encountered in normal host deploy flows so 3.5 will be most appropriate.

Comment 3 Federico Simoncelli 2014-02-27 22:52:24 UTC
(In reply to Adam Litke from comment #2)
> Yeah, 3.5 is fine.  I feel like it can affect any OS but it depends on how
> you install vdsm.

It was affecting only rhel 7 because of the spec conditionals.

Comment 5 Petr Beňas 2014-05-02 15:00:24 UTC
[root@slot-7 ~]# rpm -qR vdsm | grep sanlock-python
sanlock-python  
[root@slot-7 ~]# rpm -qa vdsm
vdsm-4.14.6-0.1.beta3.el6ev.x86_64

Comment 6 Sandro Bonazzola 2014-10-17 12:20:20 UTC
oVirt 3.5 has been released and should include the fix for this issue.


Note You need to log in before you can comment on or make changes to this bug.