Bug 1064297 - Incorrect validation of rhq-server.properties for oracle
Summary: Incorrect validation of rhq-server.properties for oracle
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: RHQ Project
Classification: Other
Component: Installer
Version: 4.10
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: RHQ Project Maintainer
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-12 11:30 UTC by Filip Brychta
Modified: 2014-02-12 14:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-12 14:39:43 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1019809 0 urgent CLOSED Unable to install rhq server with oracle db 2021-02-22 00:41:40 UTC

Internal Links: 1019809

Description Filip Brychta 2014-02-12 11:30:45 UTC
Description of problem:
According to https://access.redhat.com/site/documentation/en-US/Red_Hat_JBoss_Operations_Network/3.2/pdf/Installation_Guide/Red_Hat_JBoss_Operations_Network-3.2-Installation_Guide-en-US.pdf, Table 2.5. rhq-server.properties Attributes for Server Configuration, following properties:

rhq.server.database.server-name 
rhq.server.database.port 
rhq.server.database.db-name 

are not used for oracle. But when you leave them empty or commented, installation fails with validation error. When you use default values which are:
 
rhq.server.database.server-name=unused
rhq.server.database.port=unused
rhq.server.database.db-name=unused

installation works, but it should work no matter if those properties are set or not.

Version-Release number of selected component (if applicable):
Version :	
4.10.0-SNAPSHOT
Build Number :	
a7d46c9


How reproducible:
Always

Steps to Reproduce:
1. install and set up oracle db according to install manual
2. unzip rhq-server-4.10.0-SNAPSHOT.zip
3. open $RHQ_SERVER_HOME/bin/rhq-server.properties
    a) comment out all properties in PostgreSQL section
    b) uncomment all properties in Oracle section except unused listed in description above
4. run ./rhqctl install and set required properties

Actual results:
06:00:48,140 ERROR [org.rhq.server.control.RHQControl] The rhq-server.properties file is not valid. Installation is canceled: Validation errors:
[rhq.server.database.port] must exist and be set to a number : [null]
[rhq.server.database.db-name] must exist and be set to a valid string value
[rhq.server.database.server-name] must exist and be set to a valid string value

Expected results:
Installation should work ignoring unused properties completely.

Additional info:
This is missed verification scenario from bz 1019809

Comment 1 Jay Shaughnessy 2014-02-12 14:09:56 UTC
This should only be fixed if the documentation in rhq-server.properties is deemed insufficient:  Snippet (see last line in particular):

# These should point to the database that your RHQ Server will use as
# its backend RDBMS storage.
# If you are using Oracle:
#   - comment out the Postgres settings
#   - uncomment the Oracle settings below
#   - adjust the values to match your environment
#   - do not edit the three unused properties, leave as "prop=unused"

Comment 2 Filip Brychta 2014-02-12 14:39:43 UTC
Ok, I didn't noticed that. Our installation script failed because of this (it was using empty values for those unused properties, which worked before the validation was implemented) but it is fixed now and since this is not anything critical, closing as NOTABUG


Note You need to log in before you can comment on or make changes to this bug.