Bug 1064643

*** Bug 1080996 has been marked as a duplicate of this bug. ***

Note: bug 1080996 has some very detailed debugging results.

We need to test at least ide-hd, scsi-hd and virtio-blk.

The RHEL-7 buddy bug 1085232 has a nice reproducer for ide-hd in
comment#2.  I just asked for it to be extended to cover scsi-hd and
virtio-blk.

Can you reproduce the bug on RHEL-6 with it, with all three kinds of
disks?

Correction: ide-drive with media=disk, because RHEL-6 doesn't have ide-hd.

(In reply to Markus Armbruster from comment #6)
> We need to test at least ide-hd, scsi-hd and virtio-blk.
> 
> The RHEL-7 buddy bug 1085232 has a nice reproducer for ide-hd in
> comment#2.  I just asked for it to be extended to cover scsi-hd and
> virtio-blk.
> 
> Can you reproduce the bug on RHEL-6 with it, with all three kinds of
> disks?

Hi Qzhang,

Could you give a test and update the testing result in the bz?

Best Regards,
Junyi

(In reply to Markus Armbruster from comment #6)
> We need to test at least ide-hd, scsi-hd and virtio-blk.
> 
> The RHEL-7 buddy bug 1085232 has a nice reproducer for ide-hd in
> comment#2.  I just asked for it to be extended to cover scsi-hd and
> virtio-blk.
> 
> Can you reproduce the bug on RHEL-6 with it, with all three kinds of
> disks?

We will test the bug and update the result here.

IDE:
---
Steps as followings:
1, boot RHEL-Server-5.8-64 guest with cli:
# /usr/libexec/qemu-kvm -m 2G -enable-kvm -drive file=/home/juli/rhel-6.6-20140603.n.0.raw,if=none,id=img,rerror=stop,werror=stop -device virtio-blk-pci,drive=img,id=sys-img,bootindex=1 -drive file=/home/data-disk.qcow2,if=none,id=ide-img,rerror=stop,werror=stop,media=disk -device ide-drive,drive=ide-img,bus=ide.0,unit=1,id=sys-ide-img -monitor stdio -vnc :1 -boot menu=on -netdev tap,id=tap0,script=/etc/qemu-ifup -device virtio-net-pci,netdev=tap0,id=sys-tap0,mac=24:be:05:14:11:11
-------
2, compile vm_stop.c and run it inside guest.
# cat vm_stop.c 
/*
 *  * program 'vm_stop.c' - compile with 'make vm_stop'
 *   */
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/ioctl.h>
#include <fcntl.h>
#include <stdio.h>
#include <errno.h>
#include <unistd.h>
#include <linux/hdreg.h>

char args[7];

main()
{
    int fd;

    if ((fd = open("/dev/sda", O_RDONLY)) == -1) {
        perror("open");
        _exit(1);
    }

    /*
 *      * lba is 0xfffffff (268435455)
 *           * To reproduce the problem, the size of the virtual disk image
 *                * must be less than 268435455 * 512 = 137438953472 bytes (128G).
 *                     */
    args[6] = 0x4f;     // select : lba bits 24 .. 27
    args[5] = 0xff;     // hcyl   : lba bits 16 .. 23
    args[4] = 0xff;     // lcyl   : lba bits  8 .. 15
    args[3] = 0xff;     // sector : lba bits  0 ..  7
    args[2] = 0x01;     // number of sectors
    args[1] = 0x00;
    args[0] = WIN_READ;

    if (ioctl(fd, HDIO_DRIVE_TASK, args) == -1) {
        perror("ioctl");
        _exit(1);
    }

    if (close(fd) == -1) {
        perror("close");
        _exit(1);
    }
}
---
# make vm_stop
# ./vm_stop
-----------
Results:
After step2, guest will hang.
(qemu) info status 
VM status: paused (io-error)
============================================
scsi-hd:
# /usr/libexec/qemu-kvm -m 2G -enable-kvm -drive file=/home/juli/rhel-6.6-20140603.n.0.raw,if=none,id=img,rerror=stop,werror=stop -device virtio-blk-pci,drive=img,id=sys-img,bootindex=1 -drive file=/home/data-disk.qcow2,if=none,id=ide-img,rerror=stop,werror=stop,media=disk -device virtio-scsi-pci,id=scsi0 -device scsi-hd,drive=ide-img,bus=scsi0.0,id=sys-ide-img -monitor stdio -vnc :1 -boot menu=on -netdev tap,id=tap0,script=/etc/qemu-ifup -device virtio-net-pci,netdev=tap0,id=sys-tap0,mac=24:be:05:14:11:11
---
# ./vm_stop 
ioctl: Invalid argument
=====================================
virtio-blk:
# /usr/libexec/qemu-kvm -m 2G -enable-kvm -drive file=/home/juli/rhel-6.6-20140603.n.0.raw,if=none,id=img,rerror=stop,werror=stop -device virtio-blk-pci,drive=img,id=sys-img,bootindex=1 -drive file=/home/data-disk.qcow2,if=none,id=ide-img,rerror=stop,werror=stop,media=disk -device virtio-blk-pci,drive=ide-img,bus=pci.0,id=sys-ide-img -monitor stdio -vnc :1 -boot menu=on -netdev tap,id=tap0,script=/etc/qemu-ifup -device virtio-net-pci,netdev=tap0,id=sys-tap0,mac=24:be:05:14:11:11
---
# ./vm_stop 
ioctl: Inappropriate ioctl for device
==========================================

As above show, can not use vm_stop.c for scsi-hd and virtio-blk. In my opinion, we should modify ioctl() for scsi-hd and virtio-blk in file vm_stop.c.

Hi Ulrich,

  Could you help to modify vm_stop.c for scsi-hd and virtio-blk. Thx.


Best Regards,
Jun Li

Add components version for comment #22:
qemu-kvm version:
qemu-kvm-0.12.1.2-2.428.el6.x86_64
Host kernel version:
2.6.32-486.el6.x86_64
Guest kernel version:
2.6.32-483.el6.x86_64

Fix included in qemu-kvm-0.12.1.2-2.432.el6

Verify this bz need to verify IDE/virtio-scsi/virtio-blk interface.
===========
IDE:
---
1, boot guest using following cli.
# qemu-img create -f qcow2 /home/data-disk.qcow2 10G
# /usr/libexec/qemu-kvm -m 2G -enable-kvm -drive file=/mnt/linux_img/RHEL-Server-6.6-64-virtio.raw,if=none,id=img,rerror=stop,werror=stop,snapshot=on -device virtio-blk-pci,drive=img,id=sys-img,bootindex=1 -drive file=/home/data-disk.qcow2,if=none,id=ide-img,rerror=stop,werror=stop,media=disk -device ide-drive,drive=ide-img,bus=ide.0,unit=1,id=sys-ide-img -monitor stdio -vnc :1 -boot menu=on -netdev tap,id=tap0,script=/etc/qemu-ifup -device virtio-net-pci,netdev=tap0,id=sys-tap0,mac=24:be:05:14:11:11

2, compile vm_stop.c and run it inside guest.
# cat vm_stop.c 
/*
 *  * program 'vm_stop.c' - compile with 'make vm_stop'
 *   */
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/ioctl.h>
#include <fcntl.h>
#include <stdio.h>
#include <errno.h>
#include <unistd.h>
#include <linux/hdreg.h>

char args[7];

main()
{
    int fd;

    if ((fd = open("/dev/sda", O_RDONLY)) == -1) {
        perror("open");
        _exit(1);
    }

    /*
 *      * lba is 0xfffffff (268435455)
 *           * To reproduce the problem, the size of the virtual disk image
 *                * must be less than 268435455 * 512 = 137438953472 bytes (128G).
 *                     */
    args[6] = 0x4f;     // select : lba bits 24 .. 27
    args[5] = 0xff;     // hcyl   : lba bits 16 .. 23
    args[4] = 0xff;     // lcyl   : lba bits  8 .. 15
    args[3] = 0xff;     // sector : lba bits  0 ..  7
    args[2] = 0x01;     // number of sectors
    args[1] = 0x00;
    args[0] = WIN_READ;

    if (ioctl(fd, HDIO_DRIVE_TASK, args) == -1) {
        perror("ioctl");
        _exit(1);
    }

    if (close(fd) == -1) {
        perror("close");
        _exit(1);
    }
}
---
# make vm_stop
# ./vm_stop
-----------
Results:
After step2, guest and qemu-kvm works well, no error in guest dmesg, guest cli will give as following info:
# ./vm_stop 
ioctl: Input/output error
(qemu) info status 
VM status: running
==================
virtio scsi:
---
1, boot guest with following cli:
# /usr/libexec/qemu-kvm -m 2G -enable-kvm -drive file=/mnt/linux_img/RHEL-Server-6.6-64-virtio.raw,if=none,id=img,rerror=stop,werror=stop,snapshot=on -device virtio-blk-pci,drive=img,id=sys-img,bootindex=1 -drive file=/home/data-disk.qcow2,if=none,id=ide-img,rerror=stop,werror=stop,media=disk -device virtio-scsi-pci,id=scsi0 -device scsi-hd,drive=ide-img,bus=scsi0.0,id=sys-ide-img -monitor stdio -vnc :1 -boot menu=on -netdev tap,id=tap0,script=/etc/qemu-ifup -device virtio-net-pci,netdev=tap0,id=sys-tap0,mac=24:be:05:14:11:11
---
2, Build the modified 'sg_simple16' program, ref https://bugzilla.redhat.com/attachment.cgi?id=907758.
----
3, Run the modified 'sg_simple16' program in the guest.
# dmesg |grep sda
sd 2:0:0:0: [sda] 20971520 512-byte logical blocks: (10.7 GB/10.0 GiB)
...
# ./sg_simple16 /dev/sg1 20971520
READ_16 command error: SCSI status: Check Condition 
 Fixed format, current;  Sense key: Illegal Request
 Additional sense: Invalid field in cdb
 Raw sense data (in hex):
        70 00 05 00 00 00 00 0a  00 00 00 00 24 00 00 00    
        00 00  
---
Results:
After step3, guest and qemu-kvm works well, no error in guest dmesg.
(qemu) info status 
VM status: running
=============================
virtio block:
Cli:
# /usr/libexec/qemu-kvm -m 2G -enable-kvm -drive file=/mnt/linux_img/RHEL-Server-6.6-64-virtio.raw,if=none,id=img,rerror=stop,werror=stop,snapshot=on -device virtio-blk-pci,drive=img,id=sys-img,bootindex=1 -drive file=/home/juli/rhel6-data.img,if=none,id=drive-virtio-disk1,format=raw,cache=none,werror=stop,rerror=stop -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x9,drive=drive-virtio-disk1,id=virtio-disk1 -monitor stdio -vnc :1 -boot menu=on -netdev tap,id=tap0,script=/etc/qemu-ifup -device virtio-net-pci,netdev=tap0,id=sys-tap0,mac=24:be:05:14:11:11
----
Create a virtual disk with 130M.
# qemu-img create -f raw /home/juli/rhel6-data.img 130M
---
Steps as attachment 912144 [details] show. 
---
Run following cli inside guest(As 270336/2/1024=132M):
# dd iflag=direct if=/dev/vdb of=/dev/null bs=512 count=1 skip=270336
---
Then, guest works well, no error in guest dmesg. When execute "dd" inside guest, will get following info:
# dd iflag=direct if=/dev/vdb of=/dev/null bs=512 count=1 skip=270336
dd: reading `/dev/vdb': Input/output error
0+0 records in
0+0 records out
0 bytes (0 B) copied, 0.0017959 s, 0.0 kB/s
---
(qemu) info status 
VM status: running
=========================
Based on above testing, all works well for ide-hd, scsi-hd and virtio-blk interface disks.

Version of qemu:
qemu-kvm-0.12.1.2-2.435.el6.x86_64

Setting to VERIFIED according to comment 31.

Upstream needed the followup-fix "ide: only constrain read/write requests to drive size, not other types".
https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg02005.html

Background: http://bugs.debian.org/757927

RHEL-6 doesn't need it, because we can DMA only read and write: we don't have commit 4e1e005.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1490.html