Bug 1064840 - Regression: create data center with specific storage type (nfs in this case) creates data center without storage type
Summary: Regression: create data center with specific storage type (nfs in this case) ...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-api
Version: 3.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.4.0
Assignee: Juan Hernández
QA Contact: bugs@ovirt.org
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-13 12:04 UTC by Ilia Meerovich
Modified: 2016-07-05 00:06 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-13 14:35:30 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)

Description Ilia Meerovich 2014-02-13 12:04:03 UTC
data center now:
    <data_center href="/api/datacenters/00000002-0002-0002-0002-000000000002" id="00000002-0002-0002-0002-000000000002">
        <name>Default</name>
        <description>The default Data Center</description>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/storagedomains" rel="storagedomains"/>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/clusters" rel="clusters"/>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/networks" rel="networks"/>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/permissions" rel="permissions"/>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/quotas" rel="quotas"/>
        <local>false</local>
        <version major="3" minor="4"/>
        <supported_versions>
            <version major="3" minor="4"/>
        </supported_versions>
        <status>
            <state>uninitialized</state>
        </status>
    </data_center>

data center in previous version:
<data_center href="/api/datacenters/00000002-0002-0002-0002-000000000002" id="00000002-0002-0002-0002-000000000002">
        <name>Default</name>
        <description>The default Data Center</description>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/storagedomains" rel="storagedomains"/>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/clusters" rel="clusters"/>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/networks" rel="networks"/>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/permissions" rel="permissions"/>
        <link href="/api/datacenters/00000002-0002-0002-0002-000000000002/quotas" rel="quotas"/>
        <storage_type>nfs</storage_type>
        <version major="3" minor="4"/>
        <supported_versions>
            <version major="3" minor="4"/>
        </supported_versions>
        <status>
            <state>uninitialized</state>
        </status>
    </data_center>

Comment 1 Ilia Meerovich 2014-02-13 12:06:38 UTC
engine version: ovirt-engine.noarch 0:3.4.0-0.7.beta2.el6
because of this 'Search for data centers by storage type' test fails

Comment 2 Juan Hernández 2014-02-13 14:35:30 UTC
In 3.4 the concept of a type of storage assigned to a data center has been removed. It has been replaced by the concept of shared and local storage, which is what the <local>false|true</local> indicates.

The testing framework will need to be updated to cope with this.

Comment 3 Ilia Meerovich 2014-02-13 14:42:55 UTC
Juan,

So we are not backward compatible?
What about customers that already wrote some infrastructure using ovirt/rhevm APIs?
Customer's infra will be broken too...

Comment 4 Juan Hernández 2014-02-13 14:55:47 UTC
Yes, in this particular case it has been decided to be a bit backwards incompatible, because we can't report back the storage_type as it no longer exists. This incompatibility has been accepted under the assumption that no user is actually using the storage_type element returned. Turns out that our testing framework is actually checking it, but this is probably too strict.

Take into account that we are still backwards compatible in the sense that the input storage_type is taken into account, and the data center is actually created correctly.

Tal, comments?

Comment 5 Tal Nisan 2014-02-13 15:03:04 UTC
Exactly, as discussed with Ilia, there is a slight backwards incompatibility but in very slight and rare cases, in any way it will be wrong to have a data center created as shared and still hold the old storage type value of NFS/iSCSI.. since the data center can support all times and thus does not have this limitation anymore


Note You need to log in before you can comment on or make changes to this bug.