Created attachment 863241 [details] user DataSources patch Description of problem: collection.conf expects the "users" data series to have DataSources set to "users", but what collectd produces has it set to "value" instead. This prevents collectd-web from producing a users graph. Version-Release number of selected component (if applicable): collectd-web-5.4.1-1.fc20.x86_64 How reproducible: Always. Steps to Reproduce: 1. Turn on collectd "users" plugin. 2. Collect some data. 3. Try to graph it with collectd-web. Actual results: No graph. Expected results: A graph of logged in users over time. Additional info: The attached patch fixes the problem.
Hi Joel, Collectd 5 changed the datasources, and collection.conf is actually right. See https://github.com/raimue/collectd/commit/6c1415d and https://collectd.org/wiki/index.php/V4_to_v5_migration_guide I expect you need to migrate your files from V4 to V5 format.
What you're saying here looks like the opposite of what the link says: > The convention was and is that data sets with only one data source should use > the name "value" for this data source. This has been fixed for the following > types: > > ... > > users That is, v4 had the users plugin producing a data set called "users", and this has been corrected to be "value" in v5. This is exactly what the patch I attached does for collection.conf. I contend that my patch is correct, and the link supports this. If I'm misreading, please show me how I'm misreading.
Additionally, the commit you've linked to on github makes the same changes to to DataSources in collection.conf as the patches I submitted.
My apologies, I didn't notice that collection.conf in the collectd rpm is a Fedora specific file and differs from upstream. I haven't used collection3 before, what do you think, would using the upstream config file (https://github.com/collectd/collectd/blob/collectd-5.4/contrib/collection3/etc/collection.conf) work?
(In reply to Ruben Kerkhof from comment #4) > I haven't used collection3 before, what do you think, would using the > upstream config file > (https://github.com/collectd/collectd/blob/collectd-5.4/contrib/collection3/ > etc/collection.conf) work? It looks like 6c1415d has half of the changes my patches made (fixing DataSources), and 147690b has the other half (fixing DSName). There are a few additional changes in the upstream config. I'll test out the upstream config file tomorrow to see if anything needs modifying and report back.
Created attachment 870331 [details] Patch for Color attributes The upstream collection.conf works fine for me, with the exception that the v4 -> v5 migration of which 6c1415d and 147690b were a part still missed updating the Color attributes for five of the graph types. I've attached a patch to fix that and also sent a pull request upstream (https://github.com/collectd/collectd/pull/568).
Hi Joel, Thanks for the patch, I took it from the upstream 5.3 branch. Would you mind giving the following scratch build a try and see if I didn't overlook something? http://koji.fedoraproject.org/koji/taskinfo?taskID=6923901
collectd-5.4.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/collectd-5.4.1-2.fc20
Package collectd-5.4.1-2.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing collectd-5.4.1-2.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-7130/collectd-5.4.1-2.fc20 then log in and leave karma (feedback).
collectd-5.4.1-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
I didn't have time earlier, but I had a look just now and the updated build looks ok to me.