RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1065422 - Tests in tests/format_test/misc_test.LabelingAsRootTestCase have ERRORs
Summary: Tests in tests/format_test/misc_test.LabelingAsRootTestCase have ERRORs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: python-blivet
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: mulhern
QA Contact: Release Test Team
URL:
Whiteboard:
Depends On:
Blocks: 1064895
TreeView+ depends on / blocked
 
Reported: 2014-02-14 16:02 UTC by mulhern
Modified: 2021-09-03 14:10 UTC (History)
4 users (show)

Fixed In Version: python-blivet-0.18.26-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1079440 (view as bug list)
Environment:
Last Closed: 2014-06-13 13:05:00 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description mulhern 2014-02-14 16:02:59 UTC 
Description of problem:

Tests in tests/format_test/misc_test.py in class LabelingAsRootTestCase will have errors if the underlying command-line utilities are not provided. These tests should be guarded against running in such an environment and skipped with an informative message where appropriate. Possibly utils.run_program should be beefed up so that it gives a more informative message than "No such file or directory", but not too intrusively.

Version-Release number of selected component (if applicable):

python-blivet 0.18.24

How reproducible:

Wherever there is an environment where required utilities are missing.

Steps to Reproduce:

Find an an environment in which mkfs.xfs is missing, run tests, notice that a bunch of test*XFS methods have ERRORs.

Actual results:

Could be a bunch of ERRORs for tests defined in LabelingAsRootTestCase methods.

Expected results:

No ERRORs.

Additional info:
Comment 2 mulhern 2014-02-15 14:00:36 UTC 
In Python 3 the OSError that subprocess.Popen throws back has been enhanced so that it actually tells you the name of the file that you are missing, which should make this kind of situation a whole lot clearer.

No such file or directory: 'mkfs.xfs'

is so much more informative than

No such file or directory
Comment 3 mulhern 2014-02-18 16:32:06 UTC 
Post again.
Comment 4 mulhern 2014-02-18 19:30:41 UTC 
acked.
Comment 5 mulhern 2014-02-19 15:29:42 UTC 
Fixed In Version: python-blivet-0.18.26-1
Comment 8 Jan Stodola 2014-03-21 14:19:21 UTC 
Moving back to ASSIGNED, mulhern confirmed via IRC that testing is valid and additional fix is needed.
Comment 9 Jan Stodola 2014-03-21 15:14:46 UTC 
Moving back to ON_QA to retest the issue described in comment 0. The other import errors will be fixed in bugs 1075561 and 1079440.
Comment 10 Jan Stodola 2014-03-24 11:30:06 UTC 
Retested with python-blivet-0.18.33-1.el7, tests that do not have cmdline utilities are skipped:

...
testCreating (formats_test.labeling_test.HFSTestCase)
Create the filesystem when passing a valid label ... skipped 'utilities unavailable for filesystem hfs'
testCreatingEmpty (formats_test.labeling_test.HFSTestCase)
Create the filesystem when passing the empty label. ... skipped 'utilities unavailable for filesystem hfs'
testCreatingNone (formats_test.labeling_test.HFSTestCase)
Create the filesystem when passing None ... skipped 'utilities unavailable for filesystem hfs'
testLabeling (formats_test.labeling_test.HFSTestCase)
A sequence of tests of filesystem labeling. ... skipped 'utilities unavailable for filesystem hfs'
testLabels (formats_test.labeling_test.InitializationTestCase)
Initialize some filesystems with valid and invalid labels. ... ok
testCreating (formats_test.labeling_test.JFSTestCase)
Create the filesystem when passing a valid label ... skipped 'utilities unavailable for filesystem jfs'
testCreatingEmpty (formats_test.labeling_test.JFSTestCase)
Create the filesystem when passing the empty label. ... skipped 'utilities unavailable for filesystem jfs'
testCreatingNone (formats_test.labeling_test.JFSTestCase)
Create the filesystem when passing None ... skipped 'utilities unavailable for filesystem jfs'
testLabeling (formats_test.labeling_test.JFSTestCase)
A sequence of tests of filesystem labeling. ... skipped 'utilities unavailable for filesystem jfs'
testCreatingSwapSpaceEmpty (formats_test.labeling_test.LabelingSwapSpaceTestCase) ... ok
testCreatingSwapSpaceNone (formats_test.labeling_test.LabelingSwapSpaceTestCase) ... ok
testLabeling (formats_test.labeling_test.LabelingSwapSpaceTestCase) ... ok
testGetLabelArgs (formats_test.labeling_test.MethodsTestCase) ... ok
testCreating (formats_test.labeling_test.ReiserFSTestCase)
Create the filesystem when passing a valid label ... skipped 'utilities unavailable for filesystem reiserfs'
testCreatingEmpty (formats_test.labeling_test.ReiserFSTestCase)
Create the filesystem when passing the empty label. ... skipped 'utilities unavailable for filesystem reiserfs'
testCreatingNone (formats_test.labeling_test.ReiserFSTestCase)
Create the filesystem when passing None ... skipped 'utilities unavailable for filesystem reiserfs'
testLabeling (formats_test.labeling_test.ReiserFSTestCase)
A sequence of tests of filesystem labeling. ... skipped 'utilities unavailable for filesystem reiserfs'
testCreating (formats_test.labeling_test.XFSTestCase)
Create the filesystem when passing a valid label. ... skipped 'utilities unavailable for filesystem xfs'
testCreatingEmpty (formats_test.labeling_test.XFSTestCase)
Create a filesystem with an empty label. ... skipped 'utilities unavailable for filesystem xfs'
testCreatingNone (formats_test.labeling_test.XFSTestCase)
Create a filesystem with the label None. ... skipped 'utilities unavailable for filesystem xfs'
testLabeling (formats_test.labeling_test.XFSTestCase)
A sequence of tests of filesystem labeling. ... skipped 'utilities unavailable for filesystem xfs'
...

Moving to VERIFIED.
Comment 11 Ludek Smid 2014-06-13 13:05:00 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.