Red Hat Bugzilla – Bug 106569
Spec file fixes and improvements
Last modified: 2007-11-30 17:10:32 EST
Attached are some fixes and improvements to the spec file for Rhythmbox. Some
things were plain wrong, like the category, the description or the %post
scriptlet not working because of a typo. Some others could be improved, like the
build dependencies (gstreamer, vorbis are clearly needed!) or obsolete things.
I'll attach the new spec file, as well as a diff from the old one for those
interested in seeing the changes in a glance.
I've also added some defines for libid3tag and flac. Those can be removed if
they don't go with the current guidelines.
Version-Release number of selected component :
Created attachment 95019 [details]
rhythmbox 0.5.3-3 proposed spec file
Created attachment 95020 [details]
rhythmbox 0.5.3-2 to proposed 0.5.3-3 patch
Mostly reasonable changes, and I'm embarassed about SCHEMES. I didn't see a
reason to make it ExclusiveArch i386, though.
I didn't add the ExclusiveArch, it was already there. Maybe something someone
slipped in between 0.5.3-1 (your last %changelog entry) and 0.5.3-2 (the current
rawhide version) without you noticing.
AFAIR, I did get rhythmbox to recompile on ppc just fine, so maybe excluding
explicitely the non-working archs (s390? ia64?) would be better indeed.
Beats me when it was added/removed. It's not in CVS now, so I'll keep it that
way. Note that I had to do the libtoolize/aclocal/automake/autoconf dance in
order to get this to build on x86-64.