Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1065694

Summary: enhance spec file to depend on libcgroup and update /etc/cgrules.conf
Product: Red Hat Enterprise Linux 7 Reporter: Neil Horman <nhorman>
Component: cgdcbxdAssignee: Neil Horman <nhorman>
Status: CLOSED CURRENTRELEASE QA Contact: Jan Ščotka <jscotka>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 7.0CC: dmach, jamorgan, jane.lv, john.r.fastabend, jscotka, jvillalo, jwilleford, marcus.g.koontz, nhorman, robert.w.love, ruwang, sct, xiaolong.wang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 10:21:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1061838    
Bug Blocks: 719684, 1053198    
Attachments:
Description Flags
test build for intel none

Description Neil Horman 2014-02-15 22:21:36 UTC
once cgrulesegd is re-instated, cgdcbxd needs to correct a spec file bug to depend on it (so we don't loose it without warning in the future).

We also need to update the cgdcbxd spec file with trigger scripts for services so that we can update /etc/cgrules.conf when those services are installed or removed.

Comment 1 Neil Horman 2014-03-03 19:42:52 UTC
Created attachment 870085 [details]
test build for intel

Comment 3 Neil Horman 2014-03-04 11:54:54 UTC
*** Bug 1072322 has been marked as a duplicate of this bug. ***

Comment 5 Neil Horman 2014-03-07 13:58:39 UTC
Its ok, yes.  The default cgrules.conf file has no reference to iscsi, so if there is any (even a comment), it indicates that the user has modified it, and I don't want to overrule that.

Comment 7 Marcus Koontz 2014-03-11 23:53:33 UTC
I have tested cgdcbxd-1.0.2-4.el7 attachment 870085 [details]

1. it adds "*:iscsid net_prio cgdcb-4-3260" in /etc/cgrules.conf however it does not remove this line on uninstalling cgdcbxd

2. Also the dependencies seem to be incorrect: 
 rpm -ivf /tmp/cgdcbxd-1.0.2-4.el7.x86_64.rpm
error: Failed dependencies:
        /usr/sbin/usr/sbin/cgrulesengd is needed by cgdcbxd-1.0.2-4.el7.x86_64
 rpm -ivf /tmp/cgdcbxd-1.0.2-4.el7.x86_64.rpm --nodeps
Preparing packages...
cgdcbxd-1.0.2-4.el7.x86_64

the path for cgrulesengd appears to be duplicated:
/usr/sbin/usr/sbin/cgrulesengd
instead of:
/usr/sbin/cgrulesengd

I see that there was a bug filed on num. 2 already: bug 1072322

What snap will cgdcbxd-1.0.2-4.el7 be in (assuming the things above are fixed)?

I see version cgdcbxd-1.0.2-3.el7 in snap9 (it does not add "*:iscsid net_prio cgdcb-4-3260" in /etc/cgrules.conf)

Comment 8 Stephen Tweedie 2014-03-12 11:12:37 UTC
(In reply to Marcus Koontz from comment #7)
> I have tested cgdcbxd-1.0.2-4.el7 attachment 870085 [details]

Aside from the issues you found, were you able to verify functioning DCB management?

> the path for cgrulesengd appears to be duplicated:
> /usr/sbin/usr/sbin/cgrulesengd
> instead of:
> /usr/sbin/cgrulesengd
> 
> I see that there was a bug filed on num. 2 already: bug 1072322

Yes, this was fixed in cgdcbxd-1.0.2-5.el7.

> What snap will cgdcbxd-1.0.2-4.el7 be in (assuming the things above are
> fixed)?

cgdcbxd-1.0.2-5.el7 should be in the compose as of snap10.

> I see version cgdcbxd-1.0.2-3.el7 in snap9 (it does not add "*:iscsid
> net_prio cgdcb-4-3260" in /etc/cgrules.conf)

Right, that was added in 1.0.2-4.

Thanks
, Stephen

Comment 9 Marcus Koontz 2014-03-12 18:11:28 UTC
(In reply to Stephen Tweedie from comment #8)
> (In reply to Marcus Koontz from comment #7)
> > I have tested cgdcbxd-1.0.2-4.el7 attachment 870085 [details]
> 
> Aside from the issues you found, were you able to verify functioning DCB
> management?

Yes I can verify that this had functioning DCB Management. cgdcbxd creates the appropriate cgroups under net_prio cgroup and changes the priority according to DCB priority info from the switch. A trace of running IO shows the priority following DCB changes based on values updated by cgdcbxd.
> 
> > the path for cgrulesengd appears to be duplicated:
> > /usr/sbin/usr/sbin/cgrulesengd
> > instead of:
> > /usr/sbin/cgrulesengd
> > 
> > I see that there was a bug filed on num. 2 already: bug 1072322
> 
> Yes, this was fixed in cgdcbxd-1.0.2-5.el7.
> 
> > What snap will cgdcbxd-1.0.2-4.el7 be in (assuming the things above are
> > fixed)?
> 
> cgdcbxd-1.0.2-5.el7 should be in the compose as of snap10.
> 
> > I see version cgdcbxd-1.0.2-3.el7 in snap9 (it does not add "*:iscsid
> > net_prio cgdcb-4-3260" in /etc/cgrules.conf)
> 
> Right, that was added in 1.0.2-4.
> 
> Thanks
> , Stephen

Comment 10 Marcus Koontz 2014-03-12 18:12:24 UTC
We will test and mark verified by Intel once we see it and test in snap 10.

Comment 11 Neil Horman 2014-03-25 17:46:02 UTC
*** Bug 1061846 has been marked as a duplicate of this bug. ***

Comment 12 Ludek Smid 2014-06-13 10:21:22 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.