Bug 1066385 - Gluster's "make glusterrpms" fails on EL7, Fedora 19, and Fedora 20
Summary: Gluster's "make glusterrpms" fails on EL7, Fedora 19, and Fedora 20
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaushal
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-18 10:13 UTC by Kaushal
Modified: 2014-11-11 08:28 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-11 08:28:00 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaushal 2014-02-18 10:13:17 UTC
Building rpms off the master branch fail on epel7, fedora 19 and fedora 20. This happens since change 58d7ef2f76 (build: CFLAGS was being polluted by python flags).

This happens because the hardened flags passed by rpmbuild on epel7 and f{19,20} were being discarded in the configure script.

This was also reported in the review page by Justin Clift, http://review.gluster.org/6957

Comment 1 Anand Avati 2014-02-18 10:25:21 UTC
REVIEW: http://review.gluster.org/7029 (build: Don't discard CFLAGS to configure) posted (#1) for review on master by Kaushal M (kaushal)

Comment 2 Anand Avati 2014-02-18 10:37:33 UTC
REVIEW: http://review.gluster.org/7029 (build: Don't discard CFLAGS in configure) posted (#2) for review on master by Kaushal M (kaushal)

Comment 3 Anand Avati 2014-02-20 16:38:17 UTC
COMMIT: http://review.gluster.org/7029 committed in master by Vijay Bellur (vbellur) 
------
commit f1f91f8016e468718df9c581662f8417a1fb999c
Author: Kaushal M <kaushal>
Date:   Tue Feb 18 15:44:56 2014 +0530

    build: Don't discard CFLAGS in configure
    
    The configure script was discarding the passed CFLAGS inadvertently.
    This caused failures while building rpms on epel7 and fedora-{19,20}, as
    the hardened CFLAGS passed by rpmbuild on these distros were discarded
    which lead to the failure of rpmbuild.
    
    Thanks to Neils de Vos for helping track this down.
    
    Change-Id: I5b2aa5d449d13bf67df6c19cda178bddfe6c3652
    BUG: 1066385
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/7029
    Reviewed-by: Justin Clift <jclift>
    Tested-by: Justin Clift <jclift>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Niels de Vos 2014-09-22 12:36:06 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-11-11 08:28:00 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.