Description of problem: Editing a template requires new data for "Use custom migration downtime" Version-Release number of selected component (if applicable): 3.4 How reproducible: 100% Steps to Reproduce: 1. Create a Template 2. Edit the Template 3. Click OK so save (there weren't modifications) Actual results: The screen does not close, it requires data for "Use custom migration downtime" Expected results: Two possibilities: 1. Field be optional: Screen closes and save data. 2. The field "Use custom migration downtime" filled with default value when opening it: Screen closes and save data. Additional info:
Setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc.
This is an automated message. Re-targeting all non-blocker bugs still open on 3.4.0 to 3.4.1.
where's a fix in master branch?
@Michal, we verified the branch master, but this bug only exist in the branch 3.4
As far as I can tell it is missing in master. How did you verify? That specific piece of code is missing and there are no real differences between master and 3.4 yet...
@Michal, in this two changes: http://gerrit.ovirt.org/23613 (branch: ovirt-engine-3.4) http://gerrit.ovirt.org/23328 (branch: master) The file TemplateVmModelBehavior.java has different modifications: http://gerrit.ovirt.org/#/c/23613/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java (ovirt-engine-3.4) http://gerrit.ovirt.org/#/c/23328/20/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java (master) The first one (ovirt-engine-3.4) remove the line #173: getModel().setSelectedMigrationDowntime(this.template.getMigrationDowntime()); And the other (master) keep the line #173.
ah, so it's an incorrect backport of template versions. Omer, please doublecheck
right, thanks! i also verified this fix works
*** Bug 1072846 has been marked as a duplicate of this bug. ***
this is a basic functionality we need to get working in 3.4 GA
*** Bug 1075186 has been marked as a duplicate of this bug. ***
*** Bug 1074253 has been marked as a duplicate of this bug. ***
I can confirm this issue is resolved in downstream RHEVM av3 (rhevm-3.4.0-0.5.master.el6ev). Verified by automation and also manually.
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released