Spec URL: http://www.cora.nwra.com/~orion/fedora/octave-netcdf.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/octave-netcdf-1.0.2-1.fc20.src.rpm Description: A MATLAB compatible NetCDF interface for Octave. Fedora Account System Username: orion
I think for this part, we need to update the guideline: %dir %{octpkgdir} %{octpkgdir}/*.m Just %{octpkgdir}/ Looking forward to your opinion. Thanks.
Well, I think the original concern was to not list %doc %{octpkgdir}/doc-cache twice - but I don't think it really matters. Just tested on F20 and EL6 and it seems to work. Also, some of the items in packinfo used to be marked %doc as well, but octave complains if they are removed so the are not really %doc. Simplifying to %{octpkgdir}/ is probably good at this point.
Spec URL: http://www.cora.nwra.com/~orion/fedora/octave-netcdf.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/octave-netcdf-1.0.2-2.fc20.src.rpm * Thu Feb 20 2014 Orion Poplawski <orion.com> 1.0.2-2 - Simplify files
(In reply to Orion Poplawski from comment #3) > Spec URL: http://www.cora.nwra.com/~orion/fedora/octave-netcdf.spec > SRPM URL: > http://www.cora.nwra.com/~orion/fedora/octave-netcdf-1.0.2-2.fc20.src.rpm > > * Thu Feb 20 2014 Orion Poplawski <orion.com> 1.0.2-2 > - Simplify files Do we need to update the guideline, any better ways of octave packaging or minor issues need to be take care so far?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/octave/packages/netcdf-1.0.2 /doc-cache See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck: GPL (v2 or later) ----------------- netcdf/inst/nccreate.m netcdf/inst/ncdisp.m netcdf/inst/ncinfo.m netcdf/inst/ncread.m netcdf/inst/ncreadatt.m netcdf/inst/ncwrite.m netcdf/inst/ncwriteatt.m netcdf/inst/ncwriteschema.m netcdf/inst/private/format2mode.m netcdf/inst/private/nc2octtype.m netcdf/inst/private/ncloc.m netcdf/inst/private/ncvarid.m netcdf/inst/private/oct2nctype.m netcdf/inst/private/test_netcdf_attributes.m netcdf/inst/private/test_netcdf_constant.m netcdf/inst/private/test_netcdf_create.m netcdf/inst/private/test_netcdf_datatypes.m netcdf/inst/private/test_netcdf_high_level_interface.m netcdf/inst/private/test_netcdf_low_level_interface.m netcdf/inst/private/test_netcdf_ncwriteschema.m netcdf/inst/private/test_netcdf_ncwriteschema_chunking.m netcdf/inst/private/test_netcdf_ncwriteschema_group.m netcdf/inst/private/test_netcdf_ncwriteschema_unlim.m netcdf/inst/private/test_netcdf_scalar_variable.m netcdf/inst/private/test_scalar_variable.m netcdf/inst/test_netcdf.m netcdf/src/__netcdf__.cc Unknown or generated -------------------- netcdf/inst/import_netcdf.m netcdf/inst/private/test_netcdf_type.m netcdf/src/PKG_ADD.sh netcdf/src/autogen.sh netcdf/src/netcdf_constants.h [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: octave-netcdf-1.0.2-2.fc21.i686.rpm octave-netcdf-1.0.2-2.fc21.src.rpm octave-netcdf.i686: W: invalid-url URL: http://octave.sourceforge.net/netcdf/ <urlopen error timed out> octave-netcdf.i686: W: dangerous-command-in-%preun rm octave-netcdf.src: W: invalid-url URL: http://octave.sourceforge.net/netcdf/ <urlopen error timed out> 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint octave-netcdf octave-netcdf.i686: W: invalid-url URL: http://octave.sourceforge.net/netcdf/ <urlopen error timed out> octave-netcdf.i686: W: dangerous-command-in-%preun rm 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- octave-netcdf (rpmlib, GLIBC filtered): /bin/sh libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libnetcdf.so.7 liboctave.so.2 liboctinterp.so.2 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) octave octave(api) rtld(GNU_HASH) Provides -------- octave-netcdf: octave-netcdf octave-netcdf(x86-32) Source checksums ---------------- http://downloads.sourceforge.net/octave/netcdf-1.0.2.tar.gz : CHECKSUM(SHA256) this package : 7cbd0b81c8a84d998d62523e67e3cd838c2b31fc047386f5755739c33bb4d1f2 CHECKSUM(SHA256) upstream package : 7cbd0b81c8a84d998d62523e67e3cd838c2b31fc047386f5755739c33bb4d1f2 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn octave-netcdf-1.0.2-2.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------------- For issue 1, do you have any idea(my bad :))? For issue 2, is it allowed(not a blocker though)? Others are fine.
- Duplicate files - that is why it was done the way it was. - COPYING gets installed to: /usr/share/octave/packages/netcdf-1.0.2/packinfo/COPYING not the normal location - but it is there and no need to duplicate it. So at this point I would just go with the -1 version.
PACKAGE APPROVED.
New Package SCM Request ======================= Package Name: octave-netcdf Short Description: A MATLAB compatible NetCDF interface for Octave Owners: orion Branches: f20 f19 epel7 el6 InitialCC:
Git done (by process-git-requests).
Checked in and built. Thanks everyone.