Bug 1066778 - Make AFR changelog attributes persistent and independent of brick position
Summary: Make AFR changelog attributes persistent and independent of brick position
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-19 05:43 UTC by Ravishankar N
Modified: 2014-11-11 08:28 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-11 08:28:04 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2014-02-19 05:43:30 UTC
Description of problem:
Detailed here:

https://www.gluster.org/community/documentation/index.php/Features/persistent-AFR-changelog-xattributes

Comment 1 Anand Avati 2014-02-19 05:44:33 UTC
REVIEW: http://review.gluster.org/7122 (glusterd: op-version check for brickops.) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 2 Anand Avati 2014-02-25 11:55:31 UTC
REVIEW: http://review.gluster.org/7122 (glusterd: op-version check for brickops.) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 3 Anand Avati 2014-02-25 11:55:48 UTC
REVIEW: http://review.gluster.org/7155 (glusterd: persistent client xlator/ afr changelog names) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 4 Anand Avati 2014-02-26 10:17:37 UTC
REVIEW: http://review.gluster.org/7122 (glusterd: op-version check for brickops.) posted (#3) for review on master by Ravishankar N (ravishankar)

Comment 5 Anand Avati 2014-02-26 10:53:54 UTC
REVIEW: http://review.gluster.org/7155 (glusterd: persistent client xlator/ afr changelog names) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 6 Anand Avati 2014-02-26 11:24:06 UTC
REVIEW: http://review.gluster.org/7155 (glusterd: persistent client xlator/ afr changelog names) posted (#3) for review on master by Ravishankar N (ravishankar)

Comment 7 Anand Avati 2014-02-27 09:11:13 UTC
REVIEW: http://review.gluster.org/7122 (glusterd: op-version check for brickops.) posted (#4) for review on master by Ravishankar N (ravishankar)

Comment 8 Anand Avati 2014-03-05 09:50:24 UTC
REVIEW: http://review.gluster.org/7155 (glusterd: persistent client xlator/ afr changelog names) posted (#4) for review on master by Ravishankar N (ravishankar)

Comment 9 Anand Avati 2014-03-10 05:31:46 UTC
REVIEW: http://review.gluster.org/7155 (glusterd: persistent client xlator/ afr changelog names) posted (#5) for review on master by Ravishankar N (ravishankar)

Comment 10 Anand Avati 2014-03-11 12:18:15 UTC
REVIEW: http://review.gluster.org/7122 (glusterd: op-version check for brickops.) posted (#5) for review on master by Ravishankar N (ravishankar)

Comment 11 Anand Avati 2014-03-11 12:18:20 UTC
REVIEW: http://review.gluster.org/7155 (glusterd: persistent client xlator/ afr changelog names) posted (#6) for review on master by Ravishankar N (ravishankar)

Comment 12 Anand Avati 2014-03-17 04:07:54 UTC
REVIEW: http://review.gluster.org/7122 (glusterd: op-version check for brickops.) posted (#6) for review on master by Ravishankar N (ravishankar)

Comment 13 Anand Avati 2014-03-24 11:36:26 UTC
COMMIT: http://review.gluster.org/7155 committed in master by Vijay Bellur (vbellur) 
------
commit 17454dfea9f3c4d47fcf0b5370a6155f639c8aeb
Author: Ravishankar N <ravishankar>
Date:   Tue Feb 25 09:17:18 2014 +0530

    glusterd: persistent client xlator/ afr changelog names
    
    -Add a unique brick-id field to glusterd_brickinfo_t
    -Persist the id to the brickinfo file
    -Use the brick-id as the client xlator name during vol create, add-brick and
     replace-brick operations.
    -For older volumes,generate the id in-memory during glusterd restore but defer
     writing it to the brickinfo file until the next volume set operation.
    -send and receive the brick-ids during peer probe.
    
    Feature page:
    www.gluster.org/community/documentation/index.php/Features/persistent-AFR-changelog-xattributes
    
    Related patch:
    http://review.gluster.org/#/c/7122
    
    Change-Id: Ib7f1570004e33f4144476410eec2b84df4e41448
    BUG: 1066778
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/7155
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Kaushal M <kaushal>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 14 Anand Avati 2014-03-24 17:23:46 UTC
COMMIT: http://review.gluster.org/7122 committed in master by Vijay Bellur (vbellur) 
------
commit a8b03479af1cd23baddd373a4d52f366b49c2398
Author: Ravishankar N <ravishankar>
Date:   Thu Feb 27 08:23:33 2014 +0000

    glusterd: op-version check for brickops.
    
    cluster op-version must be atleast 4 for add/remove brick to proceed.
    This change is required for the new afr-changelog xattr changes that
    will be done for glusterFS 3.6 (http://review.gluster.org/#/c/7155/).
    
    In add-brick, the check is done only when replica count is increased
    because only that will affect the AFR xattrs.
    
    In remove-brick, the check is unconditional failing which there will be
    inconsistencies in the client xlator names amongst the volfiles of
    different peers.
    
    Change-Id: If981da2f33899aed585ab70bb11c09a093c9d8e6
    BUG: 1066778
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/7122
    Reviewed-by: Kaushal M <kaushal>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 15 Anand Avati 2014-04-14 16:00:32 UTC
REVIEW: http://review.gluster.org/7477 (snapshot: use volume's brick_ids for the snaps) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 16 Anand Avati 2014-04-15 09:02:40 UTC
REVIEW: http://review.gluster.org/7477 (snapshot: use volume's brick_ids for the snaps) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 17 Anand Avati 2014-04-22 01:59:03 UTC
COMMIT: http://review.gluster.org/7477 committed in master by Vijay Bellur (vbellur) 
------
commit 99bfc2a2a1689da1e173cb2f8ef54d2b09ef3a5d
Author: Ravishankar N <ravishankar>
Date:   Mon Apr 14 12:39:36 2014 +0000

    snapshot: use volume's brick_ids for the snaps
    
    brickinfo->brick_id was introduced to establish persistence of client xlator
    names and AFR chanelog attributes (http://review.gluster.org/7155). The
    snapshot volumes must also use the same IDs during snapshot create and
    restore to maintain persistence.
    
    Change-Id: I13d66d19b63520061ba9ec5f0ce661cf3b9eeafe
    BUG: 1066778
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/7477
    Reviewed-by: Vijaikumar Mallikarjuna <vmallika>
    Reviewed-by: Avra Sengupta <asengupt>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 18 Niels de Vos 2014-09-22 12:36:11 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 19 Niels de Vos 2014-11-11 08:28:04 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.