There are some serious log messages which don't support localization: jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/PatchArtifact.java 102 ctx.getErrorHandler().error("Failed to load identity info for patch " + patch.getPatchId(), e); 116 ctx.getErrorHandler().error("Failed to load previous patch", e); jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/XmlFileState.java 51 ctx.getErrorHandler().error("File doesn't exist: " + file.getAbsolutePath()); 56 ctx.getErrorHandler().error("Failed to parse file: " + file.getAbsolutePath(), e); jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/PatchElementProviderArtifact.java 84 ctx.getErrorHandler().error("Layer not found: " + metadata.getName()); jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/runner/IdentityPatchContext.java 435 PatchLogger.ROOT_LOGGER.warnf(e, "failed to undo change (%s)", modification);
The validation classes are not used yet. However the last one does need i18n for sure. Thanks
After a discussion with Emanuel, we agreed to remove the logs even though they are not used.
To simplify the verification process, I explicitly marked the messages which don't require i18n in the source code with: no i18n needed. Unfortunately those messages cannot be easily removed, since the tests are relying on that logic to verify the functionality.
Verified with EAP 6.3.0 ER2