Bug 1067181 - Brightness keys stopped working between kernel 3.12.10-300 and 3.13.3-201 on Asus EEE PC
Summary: Brightness keys stopped working between kernel 3.12.10-300 and 3.13.3-201 on ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 20
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-19 22:18 UTC by lou.cardone
Modified: 2014-05-21 23:21 UTC (History)
7 users (show)

Fixed In Version: kernel-3.14.4-100.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-10 03:19:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Output of dmesg without acpi_osi=Linux in the kernel command line (61.40 KB, text/plain)
2014-05-03 14:42 UTC, lou.cardone
no flags Details
Brightness up/down keys and evemu (2.31 KB, text/plain)
2014-05-03 14:43 UTC, lou.cardone
no flags Details

Description lou.cardone 2014-02-19 22:18:41 UTC
User-Agent:       Mozilla/5.0 (X11; Linux) AppleWebKit/538.1 (KHTML, like Gecko) Chrome/18.0.1025.133 Safari/538.1 Midori/0.5
Build Identifier: 

Apologies that this is very similar to other "brightness Fn keys not working" bugs.

I recently did a fresh install of 20 on my netbook (Asus 1015PX), and posted about the steps I needed to take to get the brightness Fn keys working at http://forums.fedoraforum.org/showthread.php?t=297271

A kernel update has since stopped them working: in 3.12.10-300.fc20.x86_64 I have no problems, but in 3.13.3-201.fc20.x86_64 they don't work.

I've checked and the `eeepc_laptop` module which is needed for this functionality does appear in 3.13.

Reproducible: Always

Steps to Reproduce:
1. Boot into 3.12, Fn keys work
2. Boot into 3.13, Fn keys don't!
3.

Comment 1 lou.cardone 2014-02-27 17:30:42 UTC
Still not working in 3.13.4-200.

Comment 2 lou.cardone 2014-04-16 08:30:46 UTC
Still not working in any kernel up to and including 3.13.9.

Is there anybody out there? I realise this is a very minor bug so if there is a better place to find assistance I'd like to hear it. I'm happy to do some of the work myself but I have no experience with the kernel or modules.

Comment 3 Hans de Goede 2014-04-30 10:17:12 UTC
Hi Lou,

I've been researching backlight issues for the last few days and I think I'm starting to get a handle on them, or at least to some degree.

Can you try with the latest fedora kernel:
http://koji.fedoraproject.org/koji/buildinfo?buildID=513888

And see if that works (download the rpm for your arch, and install it with "rpm -ivh kernel...rpm") ?

If it does not work, then try booting with "acpi_backlight=vendor" on the kernel cmdline
(press esc at the grub screen to stop grub from booting, then e to edit the entry for the latest kernel, then go the line starting with linux, and add the end of that line add a space and then acpi_backlight=vendor).

Also try with "video.use_native_backlight=1" instead of "acpi_backlight=vendor". 

For each attempt please run:

ls /sys/class/backlight

And copy and paste the out here, as well as make a note of if the kernel cmdline option helps to fix the backlight brightness control.

Also please run the following command (once):

grep '.*' /sys/class/dmi/id/*_* 2> /dev/null

And copy and paste the output here.

Thanks,

Hans

Comment 4 poma 2014-04-30 19:00:48 UTC
ACPI / video: Add systems that should favour native backlight interface
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/acpi/blacklist.c?id=0e9f81d

Comment 5 poma 2014-04-30 19:15:01 UTC
Possible duplicates - Brightness related:

Brightness adjustment FN keys doesn't work
https://bugzilla.redhat.com/show_bug.cgi?id=702352

Brightness/backlight keys (fn+F8, fn+F9) does not work on lenovo T530 out of the box
https://bugzilla.redhat.com/show_bug.cgi?id=947976

Acer Aspire V5-171-9620 display brightness doesn't change using keyboard Fn keys (but onscreen slider moves)
https://bugzilla.redhat.com/show_bug.cgi?id=983342

Dell brightness keys register multiple times
https://bugzilla.redhat.com/show_bug.cgi?id=986653

unable to adjust monitor brightness with nouveua, Toshiba, and 3.11.0 kernel
https://bugzilla.redhat.com/show_bug.cgi?id=999684

Cannot adjust brightness anymore using Fn keys with F19 x86_64
https://bugzilla.redhat.com/show_bug.cgi?id=1012674

Brightness does not change on Intel graphics (using keys or slider) since about 3.9 kernels
https://bugzilla.redhat.com/show_bug.cgi?id=1025690

T530: Unsupported brightness interface
https://bugzilla.redhat.com/show_bug.cgi?id=1089545

Can't change display brightness on HP EliteBook 8470p
https://bugzilla.redhat.com/show_bug.cgi?id=1093120

Comment 6 lou.cardone 2014-05-02 08:25:54 UTC
Hi Hans,

Thanks very much for your suggestions.

$ grep '.*' /sys/class/dmi/id/*_* 2> /dev/null
/sys/class/dmi/id/bios_date:08/30/2011
/sys/class/dmi/id/bios_vendor:American Megatrends Inc.
/sys/class/dmi/id/bios_version:1401   
/sys/class/dmi/id/board_asset_tag:To Be Filled By O.E.M.
/sys/class/dmi/id/board_name:1015PE
/sys/class/dmi/id/board_vendor:ASUSTeK Computer INC.
/sys/class/dmi/id/board_version:x.xx
/sys/class/dmi/id/chassis_asset_tag:0x00000000
/sys/class/dmi/id/chassis_type:10
/sys/class/dmi/id/chassis_vendor:ASUSTeK Computer INC.
/sys/class/dmi/id/chassis_version:x.x
/sys/class/dmi/id/product_name:1015PX
/sys/class/dmi/id/product_version:x.x
/sys/class/dmi/id/sys_vendor:ASUSTeK Computer INC.

Before (3.13.9)
$ ls /sys/class/backlight/
acpi_video0  intel_backlight

With 3.14.2-200 the backlight buttons are working, with no modification to the grub command line (other than "acpi_osi=Linux" as mentioned above)! The contents of /sys/class/backlight are the same.

If there's anything else I can do please say.

Comment 7 Hans de Goede 2014-05-02 10:10:51 UTC
Hi Lou,

Can you please try the following kernel options. Note please only try *one* each time, so remove
the acpi_osi=Linux you currently have and then try one of these. For each please do ls /sys/class/backlight and check it the backlight works.

video.use_native_backlight=1

acpi_backlight=vendor

acpi_osi=!Windows 2012

acpi_osi=!Windows 2009

Thanks,

Hans

Comment 8 Hans de Goede 2014-05-02 11:59:41 UTC
(In reply to Hans de Goede from comment #7)

Note these 2 need quotes, sorry about writing them down wrong the first time:

acpi_osi="!Windows 2012"
 
acpi_osi="!Windows 2009"

Comment 9 lou.cardone 2014-05-03 13:14:59 UTC
Hi Hans,

I've tried all four of those strings in isolation, and none of them resulted in working brightness buttons. In the order that you wrote them, that `ls` command printed:

acpi_video0
intel_backlight

eeepc-wmi
intel_backlight

acpi_video0
intel_backlight

acpi_video0
intel_backlight

For your information, for all four cases `lsmod | grep eee` produced 

eeepc_wmi              13151  0 
asus_wmi               23974  1 eeepc_wmi

When the buttons work (with `acpi_osi=Linux`), it prints

eeepc_laptop           19740  0 
sparse_keymap          13584  2 eeepc_laptop,asus_wmi
rfkill                 21979  6 cfg80211,eeepc_laptop,bluetooth,asus_wmi

Again, anything else just ask.

Comment 10 Hans de Goede 2014-05-03 14:11:39 UTC
Hi Lou,

Thanks for the info. We really would  like to avoid people using acpi_osi=Linux, so I'm reluctant to send a patch upstream to make that the default for your laptop model.

I think I'm getting somewhere wrt understanding the problem, can you try 4 more things for me:

boot without the acpi_osi=Linux on the kernel cmdine and do:

1) ls /sys/class/backlight, copy and paste the output here

2) Press brightness up / down then do "dmesg > dmesg.log" and attach dmesg.log here.

3) install evemu ("yum install evemu") then do "sudo evemu-record, and select the first device listed by typing 0 <enter> and then press the brightness up/down keys and see if they cause any events. Then press CTRL+c to stop evemu-record, start it again, select device 1, etc. Repeat this until you've a device which causes events (or run out of devices to try). When you've found one which causes events write down which one it is and which events it generates.

Reboot into your normal setup (so with acpi_osi=Linux on the kernel cmdine) and repeat 3.

Thanks,

Hans

Comment 11 lou.cardone 2014-05-03 14:42:13 UTC
Created attachment 892146 [details]
Output of dmesg without acpi_osi=Linux in the kernel command line

Comment 12 lou.cardone 2014-05-03 14:43:49 UTC
Created attachment 892147 [details]
Brightness up/down keys and evemu

Comment 13 lou.cardone 2014-05-03 14:56:47 UTC
1) Just good old acpi_video0 and intel_backlight.

2) Attached dmesg.log.

3) Attached evemu.txt.

For your information, without acpi_osi=Linux my wifi is no longer behaving normally. Before I restarted I had disabled it by the switch. Now it's off, and the wifi switch toggles it between either "disabled" or "disabled by hardware switch" (it should be working or "disabled").

With acpi_osi=Linux, none of the devices generate events, not even 6 (but the brightness is adjusted on screen).

Cheers

Comment 14 Hans de Goede 2014-05-05 12:42:35 UTC
Hi,

I've send a kernel patch upstream to make acpi_osi=Linux the default for your model laptop. I've also started a kernel scratch build with this patch:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6814175

Currently it is still building, it would be great if you could download it and verify that it works on your laptop without specifying any backlight / acpi options on the kernel commandline.

Thanks & Regards,

Hans

Comment 15 lou.cardone 2014-05-06 14:39:07 UTC
Hi Hans,

I downloaded and installed kernel-3.14.2-200.rhbz1067181.fc20.x86_64.rpm and booted it without acpi_osi on the command line, and all seems normal.

Can I ask what changed between 3.13 and 3.14 to bring the buttons back to life?

Thanks

Comment 16 Hans de Goede 2014-05-06 14:43:31 UTC
Hi,

(In reply to lou.cardone from comment #15)
> Hi Hans,
> 
> Can I ask what changed between 3.13 and 3.14 to bring the buttons back to
> life?

Nothing changed, I added a patch to make acpi_osi=Linux the default when the kernel sees your model laptop (as identified by its dmi strings). The purpose of quirks like this is to have things work out of the box when people install Linux.

Regards,

Hans

Comment 17 lou.cardone 2014-05-06 14:51:07 UTC
(In reply to Hans de Goede from comment #16)
> Nothing changed, I added a patch to make acpi_osi=Linux the default when the
> kernel sees your model laptop (as identified by its dmi strings). The
> purpose of quirks like this is to have things work out of the box when
> people install Linux.

Surely it did - I still have a few flavours of 3.13 installed, and if I boot into them, even with acpi_osi=Linux, the brightness buttons don't work. In 3.14.2 all is good.

Comment 18 Hans de Goede 2014-05-06 16:19:28 UTC
Hi,

(In reply to lou.cardone from comment #17)
> (In reply to Hans de Goede from comment #16)
> > Nothing changed, I added a patch to make acpi_osi=Linux the default when the
> > kernel sees your model laptop (as identified by its dmi strings). The
> > purpose of quirks like this is to have things work out of the box when
> > people install Linux.
> 
> Surely it did - I still have a few flavours of 3.13 installed, and if I boot
> into them, even with acpi_osi=Linux, the brightness buttons don't work. In
> 3.14.2 all is good.

Ah, now I see what you mean, but we already discovered that earlier, see your own comment 8. So yes 3.14 has the regression in 3.13, which caused things to fail even with acpi_osi=Linux, fixed. No idea what exactly got fixed though.

Comment 19 Fedora Update System 2014-05-07 20:52:44 UTC
kernel-3.14.3-200.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/kernel-3.14.3-200.fc20

Comment 20 Fedora Update System 2014-05-08 10:10:53 UTC
Package kernel-3.14.3-200.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing kernel-3.14.3-200.fc20'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-6122/kernel-3.14.3-200.fc20
then log in and leave karma (feedback).

Comment 21 Fedora Update System 2014-05-10 03:19:25 UTC
kernel-3.14.3-200.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2014-05-13 12:16:46 UTC
kernel-3.14.3-100.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/FEDORA-2014-6167/kernel-3.14.3-100.fc19

Comment 23 Fedora Update System 2014-05-13 22:11:54 UTC
kernel-3.14.4-100.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/kernel-3.14.4-100.fc19

Comment 24 Fedora Update System 2014-05-21 23:21:27 UTC
kernel-3.14.4-100.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.