Bug 1067308 - Consistently use "Deleted" in REST responses
Summary: Consistently use "Deleted" in REST responses
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Master
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Luke Meyer
QA Contact: libra bugs
URL:
Whiteboard:
Depends On: 1060834
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-20 07:43 UTC by Ma xiaoqiang
Modified: 2017-03-08 17:38 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1060834
Environment:
Last Closed: 2014-02-20 14:04:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Ma xiaoqiang 2014-02-20 07:43:28 UTC
This problem exists on puddle[2.0.3/2014-02-12.1]
+++ This bug was initially created as a clone of Bug #1060834 +++

Description of problem:
We should use the similar output messages for actions of the same kind. For example, when I delete an ssh key via REST, it tells me "Deleted SSH key", 
When I delete the authorization token, it says "Authorization <%token_id%> is revoked", when I delete an alias, it says: "Removed alias.com from application"
Let's put some consistency to the REST responses
 
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Dan McPherson on 2014-02-06 14:26:58 EST ---

I disagree that everything should be deleted.  Consistency within a type if important.  We don't want to use both delete and destroy and remove for one type of object.  But revoke is a better word for auth.  I actually like removed better for alias and I would prefer removed for ssh key.  The reason why is because remove implies the app is still there and you have taken something away from it.  You aren't actually deleting the key.  It still exists.  It's just not a part of the app.  I went ahead and changed it for ssh key.


https://github.com/openshift/origin-server/pull/4676

--- Additional comment from openshift-github-bot on 2014-02-06 15:29:20 EST ---

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/778abb6623737875b162d2dbb700fb2ab6c00416
Bug 1060834

--- Additional comment from Hou Jianwei on 2014-02-07 00:21:18 EST ---

Verified on devenv_4341, the RESTAPI messages have been improved when an sshkey is deleted.

{"api_version":1.6,"data":null,"messages":[{"exit_code":0,"field":null,"index":null,"severity":"info","text":"Removed SSH key default"}],"status":"ok","supported_api_versions":[1.0,1.1,1.2,1.3,1.4,1.5,1.6],"type":null,"version":"1.6"}

Comment 2 Aleksandar Kostadinov 2014-02-20 08:42:11 UTC
related to consistency isn't it also inconsistent to use rhc delete for an application but remove for cartridge, ssh keys and other elements?


Note You need to log in before you can comment on or make changes to this bug.