Description of problem: When choosing Network interfaces subtab for specific Host there is a Refresh interval icon. It appears and disappears once in several seconds Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Choose specific Host under Hosts on UI 2. Pick for that Host Network Interfaces subtab 3. Check for a refresh button Actual results: After several seconds the refresh button disappears and comes back only after you move to another tab and come back to Network Interfaces subtab ( and then it disappears again) Expected results: The refresh button should be presented all the time Additional info:
this is a straight forward bug, no input/advice from the RHEV User Experience stakeholders is required -> removing the UserExperience Keyword.
I believe the problem lies in SubTabHostInterfacePresenter.java: line 76: getView().setRefreshButtonVisibility(!getModelProvider().getModel().getTimer().isActive()); Should be: getView().setRefreshButtonVisibility(getModelProvider().getModel().getTimer().isActive()); You will notice part of the refresh button shown in 3.1 DC hosts, while it not be there at all for > 3.1 DC hosts.
(In reply to Alexander Wels from comment #2) > I believe the problem lies in SubTabHostInterfacePresenter.java: > > line 76: > getView().setRefreshButtonVisibility(!getModelProvider().getModel(). > getTimer().isActive()); > > Should be: > > getView().setRefreshButtonVisibility(getModelProvider().getModel(). > getTimer().isActive()); > > You will notice part of the refresh button shown in 3.1 DC hosts, while it > not be there at all for > 3.1 DC hosts. This is for 3.4. In 3.5 the refresh sync patch seems to affect this a little more, there is a patch http://gerrit.ovirt.org/#/c/24796 for 3.5 to solve this issue.
(In reply to Alexander Wels from comment #2) > I believe the problem lies in SubTabHostInterfacePresenter.java: > > line 76: > getView().setRefreshButtonVisibility(!getModelProvider().getModel(). > getTimer().isActive()); > > Should be: > > getView().setRefreshButtonVisibility(getModelProvider().getModel(). > getTimer().isActive()); > Logic was put there on purpose, if I remember correctly following comment by derez on the patch (on master branch) fixing Bug 1027597. For newer hosts the subtab is refreshed periodically so there's no need for the button, for older hosts it can't be refreshed periodically so the button is shown. This appears to be another regression due to the grid timer synchronization patch, therefore reverting that patch on the 3.4 branch should fix it for 3.4. However, if that patch isn't reverted on master, this bug should probably be cloned for 3.5.
This is an automated message. This BZ should be fixed in oVirt 3.4.0 RC repository, assignee please update the status of the bug to ON_QA once you've verified that the change is included in the build.
Verified in av2
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released