Bug 1067740 - RFE: API Documentation
Summary: RFE: API Documentation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Data Grid 6
Classification: JBoss
Component: Documentation
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 6.3.0
Assignee: Misha H. Ali
QA Contact:
URL:
Whiteboard:
Depends On: 1067724
Blocks: 1104639
TreeView+ depends on / blocked
 
Reported: 2014-02-21 00:24 UTC by Misha H. Ali
Modified: 2014-07-21 02:14 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1108441 (view as bug list)
Environment:
Last Closed: 2014-07-21 02:14:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
API diffs (3.62 MB, application/zip)
2014-07-01 13:53 UTC, Tristan Tarrant
no flags Details

Description Misha H. Ali 2014-02-21 00:24:52 UTC
New API Docs for 6.3

Comment 2 Misha H. Ali 2014-03-26 01:26:53 UTC
Created skeleton for new API document in SVN, updated with beta requirements.

Comment 3 gsheldon 2014-06-12 06:37:36 UTC
From BZ#1104796:

Title: Limitations of Map Methods

Describe the issue:
ISPN-761 (an undocumented major API change in JDG 6.2) changed the way the
size(), values(), keySet() and entrySet() calls work.
These now include entries in the cache store by default, which can have
a *huge* impact on performance.

Comment 4 Misha H. Ali 2014-06-25 04:16:13 UTC
Tristan, any ETA on the final diff for new, changed and removed packages for the API Docs?

Comment 5 Tristan Tarrant 2014-07-01 13:53:36 UTC
Created attachment 913768 [details]
API diffs

Comment 7 Misha H. Ali 2014-07-03 00:09:51 UTC
Additional requirement: Add C# docs into the API Docs wrapper. Misha is looking into this now.

Comment 13 Misha H. Ali 2014-07-03 01:53:26 UTC
I'll set this to ON_QA once we have the final version of the api docs for all three in this. For now, Martin, could I ask you to verify the package addition and changes listed please.

Comment 14 Martin Gencur 2014-07-03 10:31:18 UTC
I checked the docs and have a few comments:

* change "Red hat JBoss Data Grid Javadocs" to "Red Hat JBoss Data Grid Javadocs"

* for the C++ docs we can include just the first sentence (including the one link):
    "Click the link to view the Red Hat JBoss Data Grid C++ Hot Rod Client documentation."

  The rest is IMO redundant.

* for the C# client documentation I'd use the same approach as described above for C++, the other links are available through the root link and are redundant.

Since JDG 6.2.1, only these packages have been added:

* org.infinispan.objectfilter
* org.infinispan.persistence.jpa
* org.infinispan.persistence.jpa.configuration

I think we did not remove any packages.
Regarding changed packages, this information is hard to get and if we really want it, it's up to engineering to provide it. Personally,
I don't think this information is useful. We keep backward compatibility and so this list of changed packages does not make much sense.

I'll wait for the final version including docs for CR2.

Comment 15 Misha H. Ali 2014-07-04 01:26:02 UTC
Thanks, Martin. Comments inline:

(In reply to Martin Gencur from comment #14)
> I checked the docs and have a few comments:
> 
> * change "Red hat JBoss Data Grid Javadocs" to "Red Hat JBoss Data Grid
> Javadocs"

Fixed.
 
> * for the C++ docs we can include just the first sentence (including the one
> link):
>     "Click the link to view the Red Hat JBoss Data Grid C++ Hot Rod Client
> documentation."
> 
>   The rest is IMO redundant.

Sure. I added those initially because the main page is a little empty. Reverted to just the main link now.

> * for the C# client documentation I'd use the same approach as described
> above for C++, the other links are available through the root link and are
> redundant.

Done, same as C++

> Since JDG 6.2.1, only these packages have been added:
> 
> * org.infinispan.objectfilter
> * org.infinispan.persistence.jpa
> * org.infinispan.persistence.jpa.configuration

Hm, so none of these were in the diff from Tristan. I'm not sure which list we should have here for new packages. Tristan, can you help clarify this please?

> I think we did not remove any packages.
> Regarding changed packages, this information is hard to get and if we really
> want it, it's up to engineering to provide it. Personally,
> I don't think this information is useful. We keep backward compatibility and
> so this list of changed packages does not make much sense.

OK. Tristan, do you also agree that the list of changed packages is not very useful? If we have an agreement, I'll just get rid of it.

> I'll wait for the final version including docs for CR2.

I'll flag you for QA when we have the final api docs included. Thanks, Martin!

Comment 17 Tristan Tarrant 2014-07-04 07:01:54 UTC
Yes, get rid of the package diff.

Comment 18 Tristan Tarrant 2014-07-04 07:53:24 UTC
Sorry, you're right, added packages are important, changed packages can be removed

Comment 19 Misha H. Ali 2014-07-04 07:55:40 UTC
Thanks, Tristan. I'll remove those then. However, we still seem to have two different sets of new packages: those from your diff, which are now in the API Docs staged at the moment and the ones Martin has identified in comment #14. I'd like your input on which one is the more accurate one since there doesn't seem to be any overlap, which is rather odd.

Comment 20 Martin Gencur 2014-07-04 08:00:09 UTC
Just to clarify how I got the package set. I opened API docs for 6.2.1 and 6.3 side-by-side and looked which packages have been added. The org.infinispan.commons was already there in 6.2.1 so this is not new.

Comment 21 Misha H. Ali 2014-07-07 04:27:02 UTC
So is Tristan already on PTO from today? If so, is there anyone else who can clarify which added packages list we should go with, or if we should just amalgamate the two we have, or drop this information altogether till later?

Comment 22 Misha H. Ali 2014-07-08 03:18:36 UTC
CR2 is out, updating all three api docs and publishing shortly.

Comment 24 Misha H. Ali 2014-07-08 06:53:19 UTC
Clarified new packages list with Martin and now changing it to the list in comment #14. Link soon.

Comment 25 Misha H. Ali 2014-07-08 07:18:09 UTC
Time for me to head off, so the updated api docs should be available shortly (within the next hour) at the same link as in comment #23.

I'm setting this to ON_QA since Martin's team is currently testing CR2. Assuming the api docs included in that package are OK, we should be OK with this bug as well.

Comment 27 Martin Gencur 2014-07-08 12:49:32 UTC
org.infinispan.security package will need to be added as a new package. We will also need to update the link to the JavaDocs after CR3 is released.

Comment 29 Misha H. Ali 2014-07-08 23:14:54 UTC
* Added org.infinispan.security to list of new packages.

Waiting for CR3 to update all api docs within the wrapper. Setting to POST till CR3 is out.

Comment 30 Misha H. Ali 2014-07-10 06:41:45 UTC
Updated with CR3 api docs, hot rod docs.

Publishing to stage. I'll post the review link here when it is available.

Comment 32 Martin Gencur 2014-07-10 07:38:07 UTC
This looks OK to me.

Comment 33 Misha H. Ali 2014-07-21 02:14:41 UTC
Now available on access.redhat.com under the JBoss Data Grid 6.3 documentation label.


Note You need to log in before you can comment on or make changes to this bug.