Spec URL: http://psabata.fedorapeople.org/pkgs/perl-Digest-xxHash/perl-Digest-xxHash.spec SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-Digest-xxHash/perl-Digest-xxHash-1.02-1.fc20.src.rpm Description: This module provides both a functional and an OO interface to xxHash functions. xxHash is an extremely fast algorithm that claims to work at speeds close to RAM limits. Fedora Account System Username: psabata
URL and Source0 are usable. Ok. Sources are original (SHA-256: 74ef29441500494bc26a8a7a7fdbadb3ee38b0ff1fb76f64e743f6c1fcee867d). Summary verified from lib/Digest/xxHash.pm. Ok. Description verified from lib/Digest/xxHash.pm. Ok. TODO: Expand the `OO' abbreviation in the description. FIX: Unbundle the xxHash sources <http://code.google.com/p/xxhash/source/browse/trunk>, or acquire FPC exception. All tests pass. Ok. $ rpmlint perl-Digest-xxHash.spec ../SRPMS/perl-Digest-xxHash-1.02-1.fc21.src.rpm ../RPMS/x86_64/perl-Digest-xxHash-* perl-Digest-xxHash.src: W: summary-not-capitalized C xxHash Implementation For Perl perl-Digest-xxHash.x86_64: W: summary-not-capitalized C xxHash Implementation For Perl 3 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Digest-xxHash-1.02-1.fc21.x86_64.rpm drwxr-xr-x 2 root root 0 Feb 24 13:54 /usr/lib64/perl5/vendor_perl/Digest -rw-r--r-- 1 root root 3230 Feb 24 13:54 /usr/lib64/perl5/vendor_perl/Digest/xxHash.pm drwxr-xr-x 2 root root 0 Feb 24 13:54 /usr/lib64/perl5/vendor_perl/auto/Digest drwxr-xr-x 2 root root 0 Feb 24 13:54 /usr/lib64/perl5/vendor_perl/auto/Digest/xxHash -rwxr-xr-x 1 root root 15368 Feb 24 13:54 /usr/lib64/perl5/vendor_perl/auto/Digest/xxHash/xxHash.so drwxr-xr-x 2 root root 0 Feb 24 13:54 /usr/share/doc/perl-Digest-xxHash -rw-r--r-- 1 root root 289 Feb 24 13:54 /usr/share/doc/perl-Digest-xxHash/Changes -rw-r--r-- 1 root root 1585 Feb 24 13:54 /usr/share/doc/perl-Digest-xxHash/LICENSE -rw-r--r-- 1 root root 2758 Feb 24 13:54 /usr/share/doc/perl-Digest-xxHash/README -rw-r--r-- 1 root root 20 Nov 25 18:30 /usr/share/doc/perl-Digest-xxHash/TODO -rw-r--r-- 1 root root 3097 Feb 24 13:54 /usr/share/man/man3/Digest::xxHash.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Digest-xxHash-1.02-1.fc21.x86_64.rpm | sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.18()(64bit) 1 perl(base) 1 perl(Config) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(strict) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Digest-xxHash-1.02-1.fc21.x86_64.rpm | sort | uniq -c 1 perl(Digest::xxHash) = 1.02 1 perl-Digest-xxHash = 1.02-1.fc21 1 perl-Digest-xxHash(x86-64) = 1.02-1.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Digest-xxHash-1.02-1.fc21.x86_64.rpm Binary dependencies resolvable. Ok. Package build in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6564412). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide new specfile. Resolution: Package NOT approved.
I don't think it's possible to `unbundle' xxHash here; the package is basically re-implementing the algorithm in XS. It's hard to tell on which version it's even based on. The original xxHash has undergone some changes and this module's upstream didn't incorporate them; the author explicitly states they don't care about this wrapper. I don't wish to maintain this `fork' on my own. Thanks for the review, however, I'm not interested in this package after all.