Spec URL: http://jamielinux.fedorapeople.org/nodejs/nodejs-css-parse.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs/SRPMS/nodejs-css-parse-1.7.0-1.fc21.src.rpm Fedora Account System Username: jamielinux Description: A JavaScript CSS parser for Node.js and the browser.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-css-parse-1.7.0-1.fc21.noarch.rpm nodejs-css-parse-1.7.0-1.fc21.src.rpm nodejs-css-parse.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-css-parse.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-css-parse.noarch: W: only-non-binary-in-usr-lib nodejs-css-parse.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-css-parse.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-css-parse nodejs-css-parse.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-css-parse.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-css-parse.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-css-parse (rpmlib, GLIBC filtered): nodejs(engine) Provides -------- nodejs-css-parse: nodejs-css-parse npm(css-parse) Source checksums ---------------- https://github.com/reworkcss/css-parse/archive/212d7d4b5f049e31d30907ee73ac767329db92e1/nodejs-css-parse-1.7.0.tar.gz : CHECKSUM(SHA256) this package : 2d848ed528dd3a40a751d98fe74c8c9b83f7f8d5eb8fe5bf904b4759580730e3 CHECKSUM(SHA256) upstream package : 2d848ed528dd3a40a751d98fe74c8c9b83f7f8d5eb8fe5bf904b4759580730e3 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1068990 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
I think the URL should be updated to point at the reworkcss URL instead of the visionmedia one, which just seems to redirect to the reworkcss one anyway. What's the idea behind using github as the source instead of the NPM registry? Is that so that the tests are included?
(In reply to Tom Hughes from comment #2) > I think the URL should be updated to point at the reworkcss URL instead of > the visionmedia one, which just seems to redirect to the reworkcss one > anyway. Oops. Thanks. Fixed. > What's the idea behind using github as the source instead of the NPM > registry? Is that so that the tests are included? I decided it made more sense to just use github as they have stripped some useful things from the NPM tarball, tests, examples, History.md. Spec URL: http://jamielinux.fedorapeople.org/nodejs/nodejs-css-parse.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs/SRPMS/nodejs-css-parse-1.7.0-2.fc21.src.rpm * Sun Feb 23 2014 Jamie Nguyen <jamielinux> - 1.7.0-2 - update URL tag
Sounds good. Package approved.
New Package SCM Request ======================= Package Name: nodejs-css-parse Short Description: A JavaScript CSS parser for Node.js and the browser Owners: jamielinux patches Branches: f19 f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
nodejs-css-parse-1.7.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-css-parse-1.7.0-2.fc20
nodejs-css-parse-1.7.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-css-parse-1.7.0-2.fc19
nodejs-css-parse-1.7.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-css-parse-1.7.0-2.el6
nodejs-css-parse-1.7.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
nodejs-stylus-0.42.2-1.fc19, nodejs-css-parse-1.7.0-2.fc19 has been pushed to the Fedora 19 stable repository.
nodejs-stylus-0.42.2-1.fc20, nodejs-css-parse-1.7.0-2.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-stylus-0.42.2-1.el6, nodejs-css-parse-1.7.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.