SPEC: http://kashyapc.fedorapeople.org/spec-files/gerritlib.spec SRPM: http://kashyapc.fedorapeople.org/srpms/gerritlib-0.3.0-1.fc20.src.rpm Description: A Python library for interacting with Gerrit Fedora Account System Username: kashyapc
Successful Koji scratch build: $ koji build --scratch rawhide ../SRPMS/gerritlib-0.3.0-1.fc20.src.rpm Uploading srpm: ../SRPMS/gerritlib-0.3.0-1.fc20.src.rpm [====================================] 100% 00:00:01 14.66 KiB 8.31 KiB/sec Created task: 6564128 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6564128 Watching tasks (this may be safely interrupted)... 6564128 build (rawhide, gerritlib-0.3.0-1.fc20.src.rpm): open (buildvm-12.phx2.fedoraproject.org) 6564129 buildArch (gerritlib-0.3.0-1.fc20.src.rpm, armv7hl): open (arm02-builder23.arm.fedoraproject.org) 6564131 buildArch (gerritlib-0.3.0-1.fc20.src.rpm, i686): open (buildvm-06.phx2.fedoraproject.org) 6564130 buildArch (gerritlib-0.3.0-1.fc20.src.rpm, x86_64): open (buildvm-17.phx2.fedoraproject.org) 6564130 buildArch (gerritlib-0.3.0-1.fc20.src.rpm, x86_64): open (buildvm-17.phx2.fedoraproject.org) -> closed 0 free 3 open 1 done 0 failed 6564131 buildArch (gerritlib-0.3.0-1.fc20.src.rpm, i686): open (buildvm-06.phx2.fedoraproject.org) -> closed 0 free 2 open 2 done 0 failed 6564129 buildArch (gerritlib-0.3.0-1.fc20.src.rpm, armv7hl): open (arm02-builder23.arm.fedoraproject.org) -> closed 0 free 1 open 3 done 0 failed 6564128 build (rawhide, gerritlib-0.3.0-1.fc20.src.rpm): open (buildvm-12.phx2.fedoraproject.org) -> closed 0 free 0 open 4 done 0 failed 6564128 build (rawhide, gerritlib-0.3.0-1.fc20.src.rpm) completed successfully
[rpmlint from AUTOMATED REVIEW TOOL OUTPUT] $ fedora-review -m fedora-rawhide-x86_64 --rpm-spec \ -n ../SRPMS/gerritlib-0.3.0-1.fc20.src.rpm [. . .] Rpmlint ------- Checking: gerritlib-0.3.0-1.fc21.x86_64.rpm gerritlib-0.3.0-1.fc21.src.rpm gerritlib.x86_64: E: no-binary gerritlib.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/gerritlib/LICENSE 2 packages and 0 specfiles checked; 1 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gerritlib gerritlib.x86_64: E: no-binary gerritlib.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/gerritlib/LICENSE 1 packages and 0 specfiles checked; 1 errors, 1 warnings. # echo 'rpmlint-done:' [. . .]
Created attachment 866926 [details] fedora-review tool un-edited output
Assigning to Parag as he kindly agreed, on IRC, to review.
1) This is a noarch package. Add following in spec BuildArch: noarch 2) Fix the wrong-file-end-of-line-encoding for LICENSE file by using in %prep sed -i 's/\r//' LICENSE 3) source is a python module, package name should start with python- prefix. python-gerritlib
Thanks, Parag. Addressed all three points from comment #5: SPEC: http://kashyapc.fedorapeople.org/spec-files/python-gerritlib.spec SRPM: http://kashyapc.fedorapeople.org/srpms/python-gerritlib-0.3.0-1.fc20.src.rpm Successful koji scratch build, with the renamed package ------------------------------------------------------- $ koji build --scratch rawhide ../SRPMS/python-gerritlib-0.3.0-1.fc20.src.rpm Uploading srpm: ../SRPMS/python-gerritlib-0.3.0-1.fc20.src.rpm [====================================] 100% 00:00:01 14.73 KiB 9.90 KiB/sec Created task: 6567780 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6567780 Watching tasks (this may be safely interrupted)... 6567780 build (rawhide, python-gerritlib-0.3.0-1.fc20.src.rpm): open (buildvm-21.phx2.fedoraproject.org) 6567781 buildArch (python-gerritlib-0.3.0-1.fc20.src.rpm, noarch): open (buildvm-16.phx2.fedoraproject.org) 6567781 buildArch (python-gerritlib-0.3.0-1.fc20.src.rpm, noarch): open (buildvm-16.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 6567780 build (rawhide, python-gerritlib-0.3.0-1.fc20.src.rpm): open (buildvm-21.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 6567780 build (rawhide, python-gerritlib-0.3.0-1.fc20.src.rpm) completed successfully rpmlint -------- $ rpmlint python-gerritlib.spec \ ../SRPMS/python-gerritlib-0.3.0-1.fc20.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings.
Looks like python2 macro usage is not used. See https://fedoraproject.org/wiki/Packaging:Python#Macros
(In reply to Parag AN(पराग) from comment #7) > Looks like python2 macro usage is not used. See > https://fedoraproject.org/wiki/Packaging:Python#Macros Addressed, re-spun SRPM. Same URLs as of Comment #8
(In reply to Kashyap Chamarthy from comment #8) > (In reply to Parag AN(पराग) from comment #7) > > Looks like python2 macro usage is not used. See > > https://fedoraproject.org/wiki/Packaging:Python#Macros > > Addressed, re-spun SRPM. Same URLs as of Comment #8 Sorry, I meant - Comment #6
Okay. Looks good now. APPROVED.
Thanks Parag. Here's SPEC and SRPM (with Python2 macros defined for EPEL): http://kashyapc.fedorapeople.org/spec-files/python-gerritlib.spec http://kashyapc.fedorapeople.org/srpms/python-gerritlib-0.3.0-3.fc20.src.rpm
Successful scratch build with SRPM from Comment #11 $ koji build --scratch rawhide ../SRPMS/python-gerritlib-0.3.0-3.fc20.src.rpm Uploading srpm: ../SRPMS/python-gerritlib-0.3.0-3.fc20.src.rpm [====================================] 100% 00:00:01 15.20 KiB 9.26 KiB/sec Created task: 6567963 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6567963 Watching tasks (this may be safely interrupted)... 6567963 build (rawhide, python-gerritlib-0.3.0-3.fc20.src.rpm): open (buildvm-18.phx2.fedoraproject.org) 6567964 buildArch (python-gerritlib-0.3.0-3.fc20.src.rpm, noarch): open (buildvm-08.phx2.fedoraproject.org) 6567964 buildArch (python-gerritlib-0.3.0-3.fc20.src.rpm, noarch): open (buildvm-08.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 6567963 build (rawhide, python-gerritlib-0.3.0-3.fc20.src.rpm): open (buildvm-18.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 6567963 build (rawhide, python-gerritlib-0.3.0-3.fc20.src.rpm) completed successfully
Looks good again for EPEL additions.
New Package SCM Request ======================= Package Name: python-gerritlib Short Description: Client library for accessing Gerrit Owners: kashyapc Branches: f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
Can this be closed?
Yes, sorry for the delay in response, was away on vacation.
ping is this built already?
Yes, it is (that's what I implied in my previous commment): $ koji latest-build f21 python-gerritlib Build Tag Built by ---------------------------------------- -------------------- ---------------- python-gerritlib-0.3.0-4.fc21 f21 ausil
any plans for el6 and epel7 builds?
Parag, no plans for EL6 or EPEL7 unless someone requests for it.
Thanks. I will close this review then as this package is already built for required branches.