Bug 1069568 - Variable instance history REST operations are at wrong path
Summary: Variable instance history REST operations are at wrong path
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.0.1
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ER2
: 6.0.1
Assignee: Marco Rietveld
QA Contact: Ivo Bek
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-25 10:08 UTC by Ivo Bek
Modified: 2016-09-20 05:05 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-08-06 20:02:20 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ivo Bek 2014-02-25 10:08:05 UTC
Description of problem:

Two of the history operations are at wrong path. The methods are called "variable_varId_instances" and "variable_varId_value_valueVal_instances". See their paths containing "/history" before "/variable", so the real full path is "/history/history/variable/..."

https://github.com/droolsjbpm/droolsjbpm-integration/blob/6.0.x/kie-remote/kie-services-remote/src/main/java/org/kie/services/remote/rest/HistoryResource.java#L221

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Ivo Bek 2014-02-25 12:33:03 UTC
Marco, within this BZ please fix also the @PathParam("procId") variableId for variable_varId_value_valueVal_instances

https://github.com/droolsjbpm/droolsjbpm-integration/blob/6.0.x/kie-remote/kie-services-remote/src/main/java/org/kie/services/remote/rest/HistoryResource.java#L237

Thank you

Comment 2 Marco Rietveld 2014-02-26 11:04:41 UTC
Fixed. Commits: 

6.0.x: 
https://github.com/droolsjbpm/droolsjbpm-integration/commit/21da70e3

master: 
https://github.com/droolsjbpm/droolsjbpm-integration/commit/a24dfc24

Apologies for the sloppy coding.. :( And thank you for saving my butt, Ivo!

Comment 3 Ivo Bek 2014-02-26 12:06:02 UTC
Not a problem ;) ... have you noticed the comment 1? I worry because I miss a fix for the variableId in the commits.

Comment 4 Marco Rietveld 2014-02-28 04:38:01 UTC
Oops, just saw that (commit 1). Fixed. Commits: 

6.0.x: 
https://github.com/droolsjbpm/droolsjbpm-integration/commit/2953399b

master:
https://github.com/droolsjbpm/droolsjbpm-integration/commit/b4b2a5ff

Comment 5 Ivo Bek 2014-03-06 15:49:16 UTC
Verified in BPMS 6.0.1.ER2


Note You need to log in before you can comment on or make changes to this bug.