Created attachment 867938 [details]
quick fix

Comment on attachment 867938 [details]
quick fix

ACK.  It looks correct, and I've verified that it fixes the problem.

the pre-3.3 behavior from RHEV is to always send admin_console==true (whereas in 3.3 the behavior is to send true for webadmin and false for user portal)

The relevant piece of code from xpi plugin does the following:

SendValue(CONTROLLER_FULL_SCREEN,
     (m_fullscreen == PR_TRUE ? CONTROLLER_SET_FULL_SCREEN : 0) |
     (m_admin_console == PR_FALSE ? CONTROLLER_AUTO_DISPLAY_RES : 0));

as confirmed with Jonathon it should be fine for RHEV 3.3 client and upstream SPICE client to again always send admin_console==true (fixes the bug for rhev client, and on upstream spice client the auto_display_res part is being ignored anyway)

This should be verified on all client variations...just to be sure:)

alright, tested the behavior with Marian it doesn't seem as an option anymore

The problem is that by reverting the above change the feature of fullscreen opening on multiple displays breaks.

to summarize the behavior:
REHV 3.3/oVirt, current RHEL/Fedora or Win client:
current - UP - opens on 2 screen, resize doesn't change resolution (this bug)
          WA - opens on 1 screen, resize works
proposed - essentially UP would behave as WA


RHEV 3.3/oVirt, testing scratch build client:
current - UP - opens on 2 screen, resize works
          WA - opens on 1 screen, resize works


So it seems the proposed change would cause another regression and the only option is to ship/release the fixed client by Marc-Andre

(In reply to Michal Skrivanek from comment #17)
> alright, tested the behavior with Marian it doesn't seem as an option anymore
> 
> The problem is that by reverting the above change the feature of fullscreen
> opening on multiple displays breaks.
> 
> to summarize the behavior:
> REHV 3.3/oVirt, current RHEL/Fedora or Win client:
> current - UP - opens on 2 screen, resize doesn't change resolution (this bug)

This is exactly how it was in rhevm 3.2, and we should should keep it this way. 

>           WA - opens on 1 screen, resize works
> proposed - essentially UP would behave as WA
> 
> 
> RHEV 3.3/oVirt, testing scratch build client:
> current - UP - opens on 2 screen, resize works
>           WA - opens on 1 screen, resize works
> 
> 
> So it seems the proposed change would cause another regression and the only
> option is to ship/release the fixed client by Marc-Andre

We want exact the same behavior connecting to both rhevm 3.2 and rhevm 3.3.
No regressions, no improvements.

mingw-virt-viewer-0.5.6-20.el6_5 ready, now needs .cab update

*** Bug 1038727 has been marked as a duplicate of this bug. ***

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0644.html