Hide Forgot
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Module-Extract-Namespaces/branches/fedora/perl-Module-Extract-Namespaces.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-Module-Extract-Namespaces/perl-Module-Extract-Namespaces-1.02-2.fc21.src.rpm Description: This module extracts package declarations from Perl code without running the code. It does not extract: * Packages declared dynamically (e.g. in eval) * Packages created as part of a fully qualified variable name Fedora Account System Username: pghmcfc
take this review.
Review:- + Package build successfully in rawhide mock + Source verified with upstream as (sha256sum) srpm tarball : bdc36e64462f7436fc52b33651a6f9a17df35511916acbe1845a13005cc65e22 upstream tarball : bdc36e64462f7436fc52b33651a6f9a17df35511916acbe1845a13005cc65e22 + rpmlint on generated rpms gave output perl-Module-Extract-Namespaces.noarch: W: spelling-error %description -l en_US eval -> veal, vela, val perl-Module-Extract-Namespaces.src: W: spelling-error %description -l en_US eval -> veal, vela, val 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + License of this package is GPL+ or Artistic which is given in source header. + %check is present and tests are run successfully. Suggestions: 1) Group tag is optional so you can remove it if this package is only for Fedora. 2) See http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment APPROVED.
New Package SCM Request ======================= Package Name: perl-Module-Extract-Namespaces Short Description: Extract the package declarations from a module Owners: pghmcfc Branches: f19 f20 el6 epel7 InitialCC: perl-sig > Group tag is optional so you can remove it if this package is only for Fedora. Thanks, I forgot about that when I stripped out EL-5 support (PPI in EPEL-5 is too old for this package). > See http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment This is a downstream-only patch (hiding a private module from rpm's dependency generator) and would serve no purpose upstream; there's a comment about the patch where it's applied in %prep. Thanks for the review.
(In reply to Paul Howarth from comment #3) > > > See http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > > This is a downstream-only patch (hiding a private module from rpm's > dependency generator) and would serve no purpose upstream; there's a comment > about the patch where it's applied in %prep. Thanks. I missed that comment.
Git done (by process-git-requests).
perl-Module-Extract-Namespaces-1.02-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Module-Extract-Namespaces-1.02-3.fc19
perl-Module-Extract-Namespaces-1.02-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Module-Extract-Namespaces-1.02-3.el6
perl-Module-Extract-Namespaces-1.02-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Module-Extract-Namespaces-1.02-3.fc20
perl-Module-Extract-Namespaces-1.02-3.fc19 has been pushed to the Fedora 19 stable repository.
perl-Module-Extract-Namespaces-1.02-3.fc20 has been pushed to the Fedora 20 stable repository.
perl-Module-Extract-Namespaces-1.02-3.el6 has been pushed to the Fedora EPEL 6 stable repository.