Spec URL: ftp://ftp.nohats.ca/getdns/getdns.spec SRPM URL: ftp://ftp.nohats.ca/getdns/getdns-0.1.0-1.fc19.src.rpm Description: Modern asynchronous API to the DNS Fedora Account System Username: pwouters
I will review this
ping? :)
You can use the name macro for the patch filenames. /var/lib can be put as %{_sharedstatedir}. rm -rf %{buildroot} is not necessary. Instead of %dir %{_includedir}/getdns %{_includedir}/getdns/*.h you can just make it: %{_includedir}/getdns/ You might also want to make %{_libdir}/libgetdns*so could become %{_libdir}/libgetdns*.so
Spec URL: ftp://ftp.nohats.ca/getdns/getdns.spec SRPM URL: ftp://ftp.nohats.ca/getdns/getdns-0.1.0-2.fc19.src.rpm * Fri Mar 21 2014 Paul Wouters <pwouters> - 0.1.0-2 - Remove cleaning in install - Simplify files section and use macro instead of /var/lib I didn't use the name macro for the patch files names. I like being able to select the file name with a double click of my mouse. Your other suggestions have been incorporated. Thanks.
Spec URL: ftp://ftp.nohats.ca/getdns/getdns.spec SRPM URL: ftp://ftp.nohats.ca/getdns/getdns-0.1.1-1.fc19.src.rpm %changelog * Wed Mar 26 2014 Paul Wouters <pwouters> - 0.1.1-1 - Updated to 0.1.1
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff also shows differences See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: getdns-0.1.1-1.fc20.x86_64.rpm getdns-devel-0.1.1-1.fc20.x86_64.rpm getdns-0.1.1-1.fc20.src.rpm getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_dns_root_servers.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_context_update_callback.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_timeout.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_general.3.gz 83: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_dns_transport.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_service.3.gz 75: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_limit_outstanding_queries.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_free_sync_request_memory.3.gz 51: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_namespaces.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_convert_fqdn_to_dns_name.3.gz 78: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_create.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_convert.3.gz 78: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_hostname.3.gz 83: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_create_with_extended_memory_functions.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_service_sync.3.gz 75: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_general_sync.3.gz 83: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_create_with_memory_functions.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_address_sync.3.gz 75: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_address.3.gz 75: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_append_name.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_destroy.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_hostname_sync.3.gz 83: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_follow_redirects.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_convert_dns_name_to_fqdn.3.gz 78: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/libgetdns.3.gz 36: warning: macro `Lb' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/libgetdns.3.gz 141: warning: macro `Bd' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/libgetdns.3.gz 155: warning: macro `Ed' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/libgetdns.3.gz 533: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_resolution_type.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_cancel_callback.3.gz 60: warning: macro `RP' not defined getdns.src: W: file-size-mismatch getdns-0.1.1.tar.gz = 678580, http://www.getdnsapi.net/dist/getdns-0.1.1.tar.gz = 507047 3 packages and 0 specfiles checked; 0 errors, 33 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint getdns-devel getdns getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_dns_root_servers.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_context_update_callback.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_timeout.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_general.3.gz 83: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_dns_transport.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_service.3.gz 75: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_limit_outstanding_queries.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_free_sync_request_memory.3.gz 51: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_namespaces.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_convert_fqdn_to_dns_name.3.gz 78: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_create.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_convert.3.gz 78: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_hostname.3.gz 83: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_create_with_extended_memory_functions.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_service_sync.3.gz 75: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_general_sync.3.gz 83: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_create_with_memory_functions.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_address_sync.3.gz 75: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_address.3.gz 75: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_append_name.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_destroy.3.gz 130: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_hostname_sync.3.gz 83: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_follow_redirects.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_convert_dns_name_to_fqdn.3.gz 78: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/libgetdns.3.gz 36: warning: macro `Lb' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/libgetdns.3.gz 141: warning: macro `Bd' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/libgetdns.3.gz 155: warning: macro `Ed' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/libgetdns.3.gz 533: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_context_set_resolution_type.3.gz 168: warning: macro `RP' not defined getdns-devel.x86_64: W: manual-page-warning /usr/share/man/man3/getdns_cancel_callback.3.gz 60: warning: macro `RP' not defined 2 packages and 0 specfiles checked; 0 errors, 32 warnings. # echo 'rpmlint-done:' Requires -------- getdns-devel (rpmlib, GLIBC filtered): getdns(x86-64) libgetdns-0.1.1.so.0()(64bit) getdns (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libidn.so.11()(64bit) libidn.so.11(LIBIDN_1.0)(64bit) libldns.so.1()(64bit) libunbound.so.2()(64bit) rtld(GNU_HASH) Provides -------- getdns-devel: getdns-devel getdns-devel(x86-64) getdns: getdns getdns(x86-64) libgetdns-0.1.1.so.0()(64bit) Source checksums ---------------- http://www.getdnsapi.net/dist/getdns-0.1.1.tar.gz : CHECKSUM(SHA256) this package : b35168b97100b029b567054c51421295d783e8ccea177eabcd3b2864c75efd7d CHECKSUM(SHA256) upstream package : abb46178de79600c826a438db7e31b2741f7bc9b0bad3707e4323e92a5f37022 diff -r also reports differences Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1070510 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
New SRPM: ftp://ftp.nohats.ca/getdns/getdns-0.1.1-1.el6.src.rpm Spec unchanged. Found the URL through browsing your FTP server, thanks for rebuilding with correct upstream tarball. PACKAGE APPROVED
*** Bug 1090501 has been marked as a duplicate of this bug. ***
New Package SCM Request ======================= Package Name: getdns Short Description: Modern asynchronous API to the DNS Owners: pwouters pavlix Branches: f20 el6 epel7 InitialCC: pavlix
Paul, you forgot to request the fedora-cvs flag.
oops. set now
Git done (by process-git-requests).
getdns-0.1.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/getdns-0.1.1-1.fc20
getdns-0.1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/getdns-0.1.1-1.el6
getdns-0.1.1-1.fc20 has been pushed to the Fedora 20 testing repository.
getdns-0.1.1-1.fc20 has been pushed to the Fedora 20 stable repository.
getdns-0.1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.