Bug 1070544 - spacewalk-setup-postgresql-2.0.1 rpm should require lsof.
Summary: spacewalk-setup-postgresql-2.0.1 rpm should require lsof.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Spacewalk
Classification: Community
Component: Installation
Version: 2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Milan Zázrivec
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On:
Blocks: space22
TreeView+ depends on / blocked
 
Reported: 2014-02-27 04:14 UTC by Mark
Modified: 2014-07-17 08:41 UTC (History)
0 users

Fixed In Version: spacewalk-setup-postgresql-2.2.1-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-17 08:41:13 UTC
Embargoed:


Attachments (Terms of Use)

Description Mark 2014-02-27 04:14:29 UTC
Description of problem:

spacewalk-setup-postgresql-2.0.1-1.el6.noarch 


spacewalk-setup-postgresql requires /usr/sbin/lsof on line 135, but the rpm doesn't require it. 

rpm -q --requires spacewalk-setup-postgresql-2.0.1-1.el6.noarch 
/bin/bash  
postgresql-contrib >= 8.4
postgresql-pltcl  
postgresql-server > 8.4
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1




Version-Release number of selected component (if applicable):
spacewalk-setup-postgresql-2.0.1-1.el6.noarch 

How reproducible:
easy, remove lsof and run the script ?

Steps to Reproduce:
1.setup a el5 or el6 minimal install of some sorts that doesn't already have lsof
2. pacewalk-setup-postgresql create --db spaceschema  --user spaceuser  --password superpassword

Actual results:
/usr/bin/spacewalk-setup-postgresql: line 135: /usr/sbin/lsof: No such file or directory


Expected results:
the script to do it's thing. or at least not fail for missing lsof

Additional info:

Comment 1 Mark 2014-02-27 05:44:45 UTC
since I wasn't going to figure out the DAV locking issue with git over http....


here is a diff for a patch. it or something like it could work. 




diff spacewalk/spacewalk-setup-postgresql/spacewalk-setup-postgresql.spec spacewalk/spacewalk-setup-postgresql/spacewalk-setup-postgresql.spec.new 
3c3
< Release:        1%{?dist}
---
> Release:        2%{?dist}
14a15
> Requires:       lsof
17a19
> Requires:	lsof
52a55,59
> 
> * Wed Feb 26 2014 Mark Sloan <mark.a.slaon> 2.1.4-2
> - 1070544 - Add requires for lsof
> 
>

Comment 2 Milan Zázrivec 2014-02-27 09:32:31 UTC
Fixed in 8a86a13e7976d845c8ee0af13cf72ee03582d462

Comment 3 Milan Zázrivec 2014-07-17 08:41:13 UTC
Spacewalk 2.2 has been released:

    https://fedorahosted.org/spacewalk/wiki/ReleaseNotes22


Note You need to log in before you can comment on or make changes to this bug.