Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-Kwalitee-Extra/branches/fedora/perl-Test-Kwalitee-Extra.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-Kwalitee-Extra/perl-Test-Kwalitee-Extra-0.2.0-2.fc21.src.rpm Description: CPANTS checks Kwalitee indicators, which is not quality but automatically-measurable indicators of how good your distribution is. Module::CPANTS::Analyse calculates Kwalitee but it is not directly applicable to your module test. CPAN has already had Test::Kwalitee for the test module of Kwalitee. It is, however, impossible to calculate prereq_matches_use indicator, because dependent module Module::CPANTS::Analyse itself cannot calculate prereq_matches_use indicator. It is marked as needs_db, but only limited information is needed to calculate the indicator. This module calculates prereq_matches_use by querying needed information from MetaCPAN. Fedora Account System Username: pghmcfc
I can take this but I have not done a package review involving perl yet. So, this would involve me reading up quite a bit and hence probably longer than what it would take someone who already knows ... :) If that is fine with you, I can take the package for review.
It's fine with me, I'm not in a hurry for this. If there's anything you want explaining, feel free to ask; I've done a large number of perl packages.
(In reply to Paul Howarth from comment #2) > If there's anything you want > explaining, feel free to ask; I've done a large number of perl packages. Thanks! I saw that on pkgdb and was the main reason for my question. :) I will take this for review.
Ok, now that I have done some reading - koji scratch build looks good. I think I need one clarification - please see below - Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/mukundan/personal/pkgs/reviews/1070671-perl-Test- Kwalitee-Extra/licensecheck.txt ---> No issues. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Test(perl-Test-Harness), /usr/share/perl5/vendor_perl/Test/Kwalitee(perl-Test-Kwalitee) ***** Based on this (https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function), I think the ownership looks fine unless perl-Test-Kwalitee is required. Is this the case? If not, I can approve the package. ***** [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. ---> From the build.log - "All tests successful." [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Test-Kwalitee-Extra-0.2.0-2.fc21.noarch.rpm perl-Test-Kwalitee-Extra-0.2.0-2.fc21.src.rpm perl-Test-Kwalitee-Extra.noarch: W: spelling-error %description -l en_US Analyse -> Analyses, Analyst, Analyze perl-Test-Kwalitee-Extra.noarch: W: spelling-error %description -l en_US prereq -> prequel perl-Test-Kwalitee-Extra.src: W: spelling-error %description -l en_US Analyse -> Analyses, Analyst, Analyze perl-Test-Kwalitee-Extra.src: W: spelling-error %description -l en_US prereq -> prequel 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint perl-Test-Kwalitee-Extra perl-Test-Kwalitee-Extra.noarch: W: spelling-error %description -l en_US Analyse -> Analyses, Analyst, Analyze perl-Test-Kwalitee-Extra.noarch: W: spelling-error %description -l en_US prereq -> prequel 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- perl-Test-Kwalitee-Extra (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.18.2) perl(Carp) perl(Cwd) perl(File::Find) perl(File::Spec) perl(MetaCPAN::API::Tiny) perl(Module::CPANTS::Analyse) perl(Module::CPANTS::Kwalitee::Prereq) perl(Module::CoreList) perl(Module::Extract::Namespaces) perl(Test::Builder) perl(strict) perl(version) perl(warnings) Provides -------- perl-Test-Kwalitee-Extra: perl(Test::Kwalitee::Extra) perl-Test-Kwalitee-Extra Source checksums ---------------- http://search.cpan.org/CPAN/authors/id/Y/YA/YAKEX/Test-Kwalitee-Extra-v0.2.0.tar.gz : CHECKSUM(SHA256) this package : da13ccc0fcf0318dd72ac6bf32c603c0e81fcb08d0c20441d6aa459de291657a CHECKSUM(SHA256) upstream package : da13ccc0fcf0318dd72ac6bf32c603c0e81fcb08d0c20441d6aa459de291657a Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1070671 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Forgot to include this - https://koji.fedoraproject.org/koji/taskinfo?taskID=6580119
(In reply to Mukundan Ragavan from comment #4) > Based on this > (https://fedoraproject.org/wiki/Packaging: > Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your > _package_to_function), I think the ownership looks fine unless > perl-Test-Kwalitee is required. > > Is this the case? If not, I can approve the package. Well, as you can see from the Requires list, perl-Test-Kwalitee is not required. However, even if it did, the directory ownership shouldn't change - see https://fedoraproject.org/wiki/Packaging:Perl#Directory_Ownership The reason for this is that perl packages can either be arch-specific or arch-independent, and the modules get installed to different directories dependent on which type of module they are. Perl modules also sometimes change between arch-specific and arch-independent, so even if in this case perl-Test-Kwalitee was required, you wouldn't be sure that it would provide the necessary parent directory (the arch-independent one in this case), because an update to perl-Test-Kwalitee might change it to be arch-specific, and hence own a different set of directories. So the perl ecosystem just shares the module directories between all modules that use them.
Thanks for the clarification! Much appreciated! Pakcage APPROVED.
New Package SCM Request ======================= Package Name: perl-Test-Kwalitee-Extra Short Description: Run Kwalitee tests including optional indicators Owners: pghmcfc Branches: f19 f20 epel7 InitialCC: perl-sig Thanks for the review Mukundan.
My pleasure! Thanks for answering my doubts.
Git done (by process-git-requests).
perl-Test-Kwalitee-Extra-0.2.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Test-Kwalitee-Extra-0.2.0-2.fc20
perl-Test-Kwalitee-Extra-0.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Test-Kwalitee-Extra-0.2.0-2.fc19
perl-Test-Kwalitee-Extra-0.2.0-2.fc19 has been pushed to the Fedora 19 stable repository.
perl-Test-Kwalitee-Extra-0.2.0-2.fc20 has been pushed to the Fedora 20 stable repository.