Bug 1070835 - Editing VM clears the VNIC profiles
Summary: Editing VM clears the VNIC profiles
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: 3.4.0
Assignee: Lior Vernia
QA Contact: Martin Pavlik
URL:
Whiteboard: network
: 1075119 (view as bug list)
Depends On: 1075119
Blocks: 1078215 rhev3.4snapshot2
TreeView+ depends on / blocked
 
Reported: 2014-02-27 14:54 UTC by Pablo Iranzo Gómez
Modified: 2019-04-28 09:12 UTC (History)
14 users (show)

Fixed In Version: av6
Doc Type: Known Issue
Doc Text:
Previously, editing a virtual machine in a non-default cluster without network attachment reset the VNIC (virtual network interface card) profiles. This happened because the cluster could potentially be called twice in the initialization of the dialog. Now, the correct cluster is properly selected the first time to prevent dual sets of backend queries, and the VNIC profile is not cleared.
Clone Of:
: 1075119 1078215 (view as bug list)
Environment:
Last Closed: 2014-06-09 15:04:55 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 737723 0 None None None Never
Red Hat Product Errata RHSA-2014:0506 0 normal SHIPPED_LIVE Moderate: Red Hat Enterprise Virtualization Manager 3.4.0 update 2014-06-09 18:55:38 UTC
oVirt gerrit 25652 0 None None None Never
oVirt gerrit 26232 0 None None None Never

Description Pablo Iranzo Gómez 2014-02-27 14:54:46 UTC
Description of problem:
- On 3.3 rhevm-webadmin-portal-3.3.0-0.46.el6ev.noarch when clicking on a VM for editing, for example VM name, or VM Ram, nic profiles are empty, so clicking OK, removes the nic profile


Version-Release number of selected component (if applicable):

rhevm-webadmin-portal-3.3.0-0.46.el6ev.noarch
How reproducible:


Steps to Reproduce:
1. Shutdown VM
2. Edit VM name or RAM
3. Click OK
4. VM network profile gets emptied

Actual results:

VM Network gets emptied

Expected results:

VM Network should be prefilled and not emptied

Additional info:

Comment 4 Lior Vernia 2014-02-27 15:06:34 UTC
This sounds like something I've fixed in the past, which as far as I remember should be in RHEV-3.3. I'll try to reproduce on a clean deployment and see if I can pin-point the problem.

Comment 5 Pablo Iranzo Gómez 2014-03-04 11:05:29 UTC
Lior,
Did you had the chance to test on your side? 

It would be nice to have an estimate for a fix.

Thanks!

Comment 6 Lior Vernia 2014-03-04 13:32:48 UTC
Hi Pablo,

Yes, on a clean deployment I couldn't reproduce this behavior. Does it happen with all VMs? With some of them? Does it only happen once a VM has been run and stopped, or does it happen on freshly-created VMs? Any additional information could prove helpful.

Yours, Lior.

Comment 7 Lior Vernia 2014-03-04 15:14:27 UTC
Also, is it possible that the customer is running some beta version (apologies, the stated rpm version tells me nothing), i.e. that my test took place on a different version than theirs?

Comment 8 Pablo Iranzo Gómez 2014-03-04 17:23:56 UTC
Lior,
I was able to reproduce on one of my machines with RHEVMdbviewer, that machine was installed using the official channels (no beta there), and after restoring customer database we ran into this issue.

I've just tried with the one that was stopped in that database snapshot, but as per their last update, this is happening with more than one vm, as they usually change parameters like vlan and ram assigned to them.

Do you want me to make the db available somewhere for testing?

Thanks,
Pablo

Comment 9 Lior Vernia 2014-03-05 10:35:13 UTC
Hi Pablo,

What about when using the same machine with another DB? I'm just trying to establish that this issue is related to the state of their DB (which wouldn't have been my first guess). In which case, an excerpt from the engine log following opening the "Edit VM" dialog would be helpful.

All VMs, or just more than one? What about when creating a new VM from scratch with a couple of interfaces, then editing that?

Thanks!
Lior.

Comment 10 Pablo Iranzo Gómez 2014-03-05 12:00:45 UTC
(In reply to Lior Vernia from comment #9)
> Hi Pablo,
> 
> What about when using the same machine with another DB? I'm just trying to
> establish that this issue is related to the state of their DB (which
> wouldn't have been my first guess). In which case, an excerpt from the
> engine log following opening the "Edit VM" dialog would be helpful.
> 
> All VMs, or just more than one? What about when creating a new VM from
> scratch with a couple of interfaces, then editing that?
> 
> Thanks!
> Lior.

Lior, I'm attaching the engine.log with the following marks in it:

###
ssh to RHEV-M
echo "START VM EDIT" >> /var/log/ovirt-engine/engine.log
###

Then, using RHEV-M UI, click on edit on an existing vm, edit ram, etc, and click ok to reproduce the issue in the logs.

###
ssh to RHEV-M
echo "STOP VM EDIT" >> /var/log/ovirt-engine/engine.log
###


###
ssh to RHEV-M
echo "START VM CREATE" >> /var/log/ovirt-engine/engine.log
###

Then, on RHEV-M UI, create a new VM, defining everything needed (ram, disks, etc)
###
ssh to RHEV-M
echo "STOP VM CREATE" >> /var/log/ovirt-engine/engine.log
###

###
ssh to RHEV-M
echo "START NEW-VM EDIT" >> /var/log/ovirt-engine/engine.log
###

Then, on RHEV-M edit the newly crated VM and check if the nic profile is filled in during the dialog, change ram for example, and click ok for saving

###
ssh to RHEV-M
echo "STOP NEW-VM EDIT" >> /var/log/ovirt-engine/engine.log
###


I'm seeing:
2014-03-05 12:31:27,288 INFO  [org.ovirt.engine.core.bll.MultipleActionsRunner] (ajp-/127.0.0.1:8702-9) MultipleActionsRunner of type AddVmInterface invoked with no actions
2014-03-05 12:31:27,356 INFO  [org.ovirt.engine.core.bll.network.vm.UpdateVmInterfaceCommand] (pool-4-thread-48) [5f3ad88c] Running command: UpdateVmInterfaceCommand internal: false. Entities affected :  ID: fd136a67-8dbf-4760-97c6-04be9fd73514 Type: VM
2014-03-05 12:31:27,370 INFO  [org.ovirt.engine.core.bll.MultipleActionsRunner] (ajp-/127.0.0.1:8702-11) MultipleActionsRunner of type RemoveVmInterface invoked with no actions
2014-03-05 12:31:27,370 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (pool-4-thread-48) [5f3ad88c] Correlation ID: 5f3ad88c, Call Stack: null, Custom Event ID: -1, Message: Interface nic1 (VirtIO) was updated for VM testvm.   (User: admin@internal)


I'm, checking the behaviour on the 'UI' side from customer and update later.

Let me know if I should check anything else.
Pablo

Comment 12 Pablo Iranzo Gómez 2014-03-05 14:09:19 UTC
Hi, The issue appeared on both the old and the new VM.

What should be the next steps for further diagnosing this?

Thanks,

Comment 13 Lior Vernia 2014-03-06 13:06:24 UTC
Since I can't see much wrong in the engine log, I'm assuming it is something wrong in the GUI code itself, that is somehow dependent on the state of the deployment (as it doesn't seem to happen on a clean one).

I will probably need to recreate the customer's DB on my environment to debug this properly.

Comment 17 Lior Vernia 2014-03-11 14:17:44 UTC
Hi Pablo,

I found the problem. There were actually two bugs, one more common and easier to fix, another less common and more difficult to understand. I have fixes pending for both, just need to get them merged on other branches before they can be merged for 3.3.z, I'm estimating it might take about a week to merge them everywhere.

Nir, I think this might be a 3.3.2 blocker, what do you think?

Lior.

Comment 18 Pablo Iranzo Gómez 2014-03-11 14:29:43 UTC
Thanks Lior,
Let me know when we've further progress so I can report to customer.

Thanks,
Pablo

PD: If you've the gerrit commits for the fixes, it would be great!

Comment 19 Lior Vernia 2014-03-11 14:52:30 UTC
Added trackers (of course patches might still change until they're merged).

Comment 20 Nir Yechiel 2014-03-11 15:27:53 UTC
*** Bug 1075119 has been marked as a duplicate of this bug. ***

Comment 21 Nir Yechiel 2014-03-11 15:54:09 UTC
This is too late for 3.3.2. I am changing the target version to 3.4.0 and we will include it in the next z-stream release which is 3.3.3.

As there is a workaround for that, we can report that as a known issue. Lior, can you please fill in the Doc Text info?

Thanks,
Nir

Comment 23 Lior Vernia 2014-04-02 09:18:51 UTC
See Doc Text field to understand exactly under what conditions this occurs.

Comment 25 Martin Pavlik 2014-04-07 08:36:00 UTC
verified av6

Comment 26 errata-xmlrpc 2014-06-09 15:04:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2014-0506.html


Note You need to log in before you can comment on or make changes to this bug.