Bug 1070917 - Quartz field in database is MUCH too short
Summary: Quartz field in database is MUCH too short
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Spacewalk
Classification: Community
Component: Server
Version: 2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Michael Mráka
QA Contact: Red Hat Satellite QA List
Tomas Lestach
URL:
Whiteboard:
Depends On:
Blocks: space22
TreeView+ depends on / blocked
 
Reported: 2014-02-27 17:48 UTC by matthew patton
Modified: 2014-07-17 08:41 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-17 08:41:43 UTC
Embargoed:


Attachments (Terms of Use)

Description matthew patton 2014-02-27 17:48:31 UTC
Description of problem:
The database field for Quartz schedule is only 20 chars wide. Any trivial schedule can easily overflow this limit.

Version-Release number of selected component (if applicable):
2.0

How reproducible:
every time

Steps to Reproduce:
1. set quartz schedule to anything over 20 char (eg. '* * 12,18 ? MON-FRI *') 

Actual results:
INFO   | jvm 3    | 2014/02/26 20:16:25 | 2014-02-26 20:16:25,129 [Thread-13] ERROR org.hibernate.util.JDBCExceptionReporter - ERROR
: value too long for type character varying(20)
...
INFO   | jvm 3    | 2014/02/26 20:16:25 | Caused by: org.postgresql.util.PSQLException: ERROR: value too long for type character varying(20)
...
INFO   | jvm 3    | 2014/02/26 20:16:25 | WARNING: org.hibernate.exception.DataException: could not insert: [com.redhat.rhn.taskomatic.TaskoSchedule]

Expected results:
successful record insertion

Additional info:

Comment 1 Tomas Lestach 2014-02-28 14:35:21 UTC
Taking ...

Comment 2 Tomas Lestach 2014-02-28 15:15:27 UTC
extending the cron_expr column to 50 ...

spacewalk.git: facabbe66d5e811913fef328dcdde00df08c9623

Comment 3 matthew patton 2014-02-28 15:41:11 UTC
Not to be pedantic but...

0 5,18,42,50 3,5,9,12,15,20,22 ? MON,TUES,FRI,SAT JAN,FEB,MAY,JUN,SEP,DEC *

Is WAY more than 50 chars too. I'd say 100 chars is more like it.

Comment 4 matthew patton 2014-02-28 15:42:51 UTC
I also should mention that the WebUI needs to be adjusted too.

Comment 5 Tomas Lestach 2014-03-11 09:46:42 UTC
All right, extending the cron_expr column to 120, however I doubt anybody would use it ...

spacewalk.git: bb84025adea49359eac62e1ddb3277ba20aeb0c3


Note that the cron expression for Comment#3 isn't valid.

Comment 6 Milan Zázrivec 2014-07-17 08:41:43 UTC
Spacewalk 2.2 has been released:

    https://fedorahosted.org/spacewalk/wiki/ReleaseNotes22


Note You need to log in before you can comment on or make changes to this bug.