Bug 1071291 - no-data-available metric values for storage node metrics
Summary: no-data-available metric values for storage node metrics
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: UI
Version: JON 3.2.1
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ER02
: JON 3.3.0
Assignee: Jay Shaughnessy
QA Contact: Armine Hovsepyan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-28 12:53 UTC by Armine Hovsepyan
Modified: 2015-09-03 00:02 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-11 14:00:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
no-data-available (158.01 KB, image/png)
2014-02-28 12:53 UTC, Armine Hovsepyan
no flags Details
storage_metrics (190.24 KB, application/octet-stream)
2014-09-04 13:46 UTC, Armine Hovsepyan
no flags Details

Description Armine Hovsepyan 2014-02-28 12:53:44 UTC
Created attachment 869045 [details]
no-data-available

Description of problem:
no-data-available metric values for storage node merics

Version-Release number of selected component (if applicable):
jon 3.2.1 dr1

How reproducible:
always

Steps to Reproduce:
1. Uninventory platform with storage
2. As soon as platform and storage are auto-inventoried back -> Navigate to Administration -> Storage Nodes
3. Click on storage endpoint address link

Actual results:
metrics with no-data-available values as well as NaN values are visible

Expected results:
not collected metrics should have NaN values, no no-data-available value should be visible


Additional info:
screenshot attache

Comment 1 Jay Shaughnessy 2014-08-27 20:39:35 UTC
Master commit 536f7ec548a95c0ae573bf86ce8fdbd0dcafbea0
Author: Jay Shaughnessy <jshaughn>
Date:   Wed Aug 27 16:30:52 2014 -0400

 The --no-data-available-- is our standard text formatting when a Double is
 either null or NaN (using MeasumenentConvertClient).  So I couldn't just change
 that across the board.  But in this instance I agree the table looked
 odd and inconsistent.  So, now using "NaN" in this scenario.  As for the
 missing metric entry, certain metrics are simply not able to be reported
 immediately.  For the one in question I made sure it is there, if possible,
 with "NaN" values.

 But understand that it is possible to actually get no metrics for a very
 brief period after import. Also, it is possible the metric set may lack a
 metroc or two for a brief period.  The fix covers things as best as
 possible. Remember that this entire issue goes away very quickly, as soon
 as metrics are initially reported.

 Probably more important than the BZ changes were some fixes I found along
 the way:
 - limit the StorageNode.QUERY_FIND_UNACKED_ALERTS_COUNTS query to committed
   storage node resources, otherwise it can report incorrectly. (sorry for the
   file reformat)
 - Fix the AVAILABILITY column handling, use our more common approach to
   avoid some issues. It was working a bit by luck.
 - Fix the STATUS field record value, it should be a string.
 - Change some formatting to allow more space both for the metrics table
   as a whole (in the detail view) and also the metric name column.
 - Fix clusterStatusItem value, it should be a String.
 - Fix messageItem value, it should be a String.
 - Protect against a potential bad widget ID
 - Apply CellFormatters prior to setting ListGridFields, and Fix == to be
   equals() to ensure proper CellFormatter is applied


Release/jon3.3.x commit ee7abdce0d41b3797ea36e961067699b632858eb
Author: Jay Shaughnessy <jshaughn>
Date:   Wed Aug 27 16:30:52 2014 -0400

    (cherry picked from commit 536f7ec548a95c0ae573bf86ce8fdbd0dcafbea0)
    Signed-off-by: Jay Shaughnessy <jshaughn>

Comment 2 Simeon Pinder 2014-09-03 20:31:50 UTC
Moving to ON_QA as available for test with the following brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=381194

Comment 3 Armine Hovsepyan 2014-09-04 13:46:40 UTC
Created attachment 934440 [details]
storage_metrics

Comment 4 Armine Hovsepyan 2014-09-04 13:47:19 UTC
verified in JON 3.3 ER02
screen-shot attached


Note You need to log in before you can comment on or make changes to this bug.