Bug 1071534 - Typo in codasrv.service start script
Summary: Typo in codasrv.service start script
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: coda
Version: 20
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Neil Horman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-01 11:59 UTC by Andrew Wasielewski
Modified: 2015-06-30 01:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-30 01:34:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Andrew Wasielewski 2014-03-01 11:59:31 UTC
Description of problem:
Line #3 in /usr/lib/systemd/system/codasrv.service reads 
   "ConditionPathExists=|/vice/srv/CRASH"
when I think it should be
   "ConditionPathExists=!/vice/srv/CRASH"
(i.e. "!" instead of "|" character)


Version-Release number of selected component (if applicable):
coda-server-6.9.5-11.fc20.x86_64

How reproducible:
Enable and start codasrv using original package files.

Steps to Reproduce:
1. Enable codasrv service with "systemctl enable codasrv.service"
2. Using original package file run "systemctl start codasrv.service"
3.

Actual results:

"systemctl status codasrv.service" claims to have started service but in fact fails due to trigger conditions not met.  Service does not start.

codasrv.service - Coda File Server
   Loaded: loaded (/usr/lib/systemd/system/codasrv.service; enabled)
   Active: inactive (dead) since Sat 2014-03-01 11:52:12 GMT; 11s ago
           start condition failed at Sat 2014-03-01 11:52:19 GMT; 4s ago
           none of the trigger conditions were met
 Main PID: 31954 (code=exited, status=0/SUCCESS)

Mar 01 11:52:19 server.wasielewski systemd[1]: Started Coda File Server.

Expected results:

Normal startup with events logged to /vice/srv/SrvLog

codasrv.service - Coda File Server
   Loaded: loaded (/usr/lib/systemd/system/codasrv.service; enabled)
   Active: active (running) since Sat 2014-03-01 11:55:14 GMT; 4s ago
  Process: 32137 ExecStart=/usr/sbin/startserver (code=exited, status=0/SUCCESS)
 Main PID: 32176 (codasrv)
   CGroup: /system.slice/codasrv.service
           └─32176 /usr/sbin/codasrv

Mar 01 11:55:14 server.wasielewski systemd[1]: Started Coda File Server.

Additional info:

It looks like a zero-length file /vice/srv/CRASH is created as a flag when there is an unmanaged shutdown.  The service start script checks that this *doesn't* exist, but due the typo it doesn't start the service.  You can work around this by manually touching the CRASH file before starting the service.

Comment 1 Fedora Update System 2014-03-03 17:21:48 UTC
coda-6.9.5-12.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/coda-6.9.5-12.fc20

Comment 2 lnie 2014-03-04 03:24:30 UTC
codasrv.service still failed to start in coda-6.9.5-12.fc20

Comment 3 Fedora Update System 2014-03-04 06:47:31 UTC
Package coda-6.9.5-12.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing coda-6.9.5-12.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-3411/coda-6.9.5-12.fc20
then log in and leave karma (feedback).

Comment 4 Fedora End Of Life 2015-05-29 11:06:30 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2015-06-30 01:34:59 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.