Spec URL: http://kwizart.fedorapeople.org/review/kmscon.spec SRPM URL: http://kwizart.fedorapeople.org/review/kmscon-8-2.fc20.src.rpm Description: KMS/DRM based System Console Fedora Account System Username: kwizart Depends on libtsm
1. Missing: checking for docbook manpages stylesheet... no --> docbook-xsl 2. renderer_pixman_enabled=no, any details? 3. %description: "See kmscon(1) man-page for usage information." You can drop this IMO. 4. Drop this: rm -rf $RPM_BUILD_ROOT 5. BuildRequires: systemd-units --> BuildRequires: systemd 6. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' 7. Silent build, please append V=1 or --disable-silent-rules to %configure. 8. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' --> find $RPM_BUILD_ROOT -name '*.la' -delete -print Therefore it will be easier to track which file has been deleted. 9. cpio: gcc-4.8.2-20140120/libgcc/config/i386/crtfastmath.c: Cannot stat: No such file or directory cpio: gcc-4.8.2-20140120/obj-i686-redhat-linux/gcc/include/cpuid.h: Cannot stat: No such file or directory cpio: gcc-4.8.2-20140120/obj-i686-redhat-linux/i686-redhat-linux/libgcc: Cannot stat: No such file or directory Suspicious. debuginfo related maybe. ------------------------- Please fix all above and provide me the new SPEC & SRPM.
Thank you for packaging this. (In reply to Christopher Meng from comment #1) > 3. %description: > > "See kmscon(1) man-page for usage information." > > You can drop this IMO. Yeah. Ironically, you don't even ship the manual since you're missing the style sheets. Please add the following: +BuildRequires: docbook-style-xsl ... %files ... +%{_mandir}/man1/kmscon.1*
Spec URL: http://kwizart.fedorapeople.org/review/kmscon.spec SRPM URL: http://kwizart.fedorapeople.org/review/kmscon-8-3.fc20.src.rpm Description: KMS/DRM based System Console Changelog: - Add man page - Spec file clean-up - Enable pixman as a renderer Koji scratch build for f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6608832 About 2/ It was not enabled by default by upstream despite all dependencies was already available, this scratch build has it enabled and I will test. About 8/ .la files are not used in fedora, so sorting out which ones are removed is not important either. I've added the manpage, thx for the fix.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck: GPL (v2 or later) ----------------- kmscon-8/build-aux/ltmain.sh MIT/X11 (BSD like) ------------------ kmscon-8/src/conf.c kmscon-8/src/conf.h kmscon-8/src/eloop.c kmscon-8/src/eloop.h kmscon-8/src/font.c kmscon-8/src/font.h kmscon-8/src/font_8x16.c kmscon-8/src/font_pango.c kmscon-8/src/font_unifont.c kmscon-8/src/genshader.c kmscon-8/src/genunifont.c kmscon-8/src/kmscon_conf.c kmscon-8/src/kmscon_conf.h kmscon-8/src/kmscon_dummy.c kmscon-8/src/kmscon_dummy.h kmscon-8/src/kmscon_main.c kmscon-8/src/kmscon_mod_bbulk.c kmscon-8/src/kmscon_mod_gltex.c kmscon-8/src/kmscon_mod_pango.c kmscon-8/src/kmscon_mod_pixman.c kmscon-8/src/kmscon_mod_unifont.c kmscon-8/src/kmscon_module.c kmscon-8/src/kmscon_module.h kmscon-8/src/kmscon_module_interface.h kmscon-8/src/kmscon_seat.c kmscon-8/src/kmscon_seat.h kmscon-8/src/kmscon_terminal.c kmscon-8/src/kmscon_terminal.h kmscon-8/src/pty.c kmscon-8/src/pty.h kmscon-8/src/shl_array.h kmscon-8/src/shl_dlist.h kmscon-8/src/shl_flagset.h kmscon-8/src/shl_githead.h kmscon-8/src/shl_hashtable.h kmscon-8/src/shl_hook.h kmscon-8/src/shl_misc.h kmscon-8/src/shl_register.h kmscon-8/src/shl_ring.h kmscon-8/src/shl_timer.h kmscon-8/src/static_gl.h kmscon-8/src/static_gl_math.c kmscon-8/src/static_gl_shader.c kmscon-8/src/text.c kmscon-8/src/text.h kmscon-8/src/text_bblit.c kmscon-8/src/text_bbulk.c kmscon-8/src/text_gltex.c kmscon-8/src/text_pixman.c kmscon-8/src/uterm_drm2d_internal.h kmscon-8/src/uterm_drm2d_render.c kmscon-8/src/uterm_drm2d_video.c kmscon-8/src/uterm_drm3d_internal.h kmscon-8/src/uterm_drm3d_render.c kmscon-8/src/uterm_drm3d_video.c kmscon-8/src/uterm_drm_shared.c kmscon-8/src/uterm_drm_shared_internal.h kmscon-8/src/uterm_fbdev_internal.h kmscon-8/src/uterm_fbdev_render.c kmscon-8/src/uterm_fbdev_video.c kmscon-8/src/uterm_input.c kmscon-8/src/uterm_input.h kmscon-8/src/uterm_input_internal.h kmscon-8/src/uterm_input_uxkb.c kmscon-8/src/uterm_monitor.c kmscon-8/src/uterm_monitor.h kmscon-8/src/uterm_systemd.c kmscon-8/src/uterm_systemd_internal.h kmscon-8/src/uterm_video.c kmscon-8/src/uterm_video.h kmscon-8/src/uterm_video_internal.h kmscon-8/src/uterm_vt.c kmscon-8/src/uterm_vt.h kmscon-8/tests/test_include.h kmscon-8/tests/test_input.c kmscon-8/tests/test_key.c kmscon-8/tests/test_output.c kmscon-8/tests/test_vt.c Unknown or generated -------------------- kmscon-8/external/htable.c kmscon-8/external/htable.h kmscon-8/src/genversion.sh kmscon-8/src/shl_githead.c kmscon-8/src/shl_llog.h kmscon-8/src/shl_log.c kmscon-8/src/shl_log.h [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Sources can be downloaded from URI in Source: tag [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: kmscon-8-3.fc21.i686.rpm kmscon-8-3.fc21.src.rpm kmscon.i686: W: spelling-error %description -l en_US linux -> Linux kmscon.i686: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace kmscon.i686: W: executable-stack /usr/lib/kmscon/mod-unifont.so kmscon.src: W: spelling-error %description -l en_US linux -> Linux kmscon.src: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace kmscon.src: W: invalid-url Source0: http://freedesktop.org/software/kmscon/releases/kmscon-8.tar.xz timed out 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint kmscon kmscon.i686: W: spelling-error %description -l en_US linux -> Linux kmscon.i686: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace kmscon.i686: W: invalid-url URL: http://www.freedesktop.org/wiki/Software/kmscon/ <urlopen error timed out> kmscon.i686: W: executable-stack /usr/lib/kmscon/mod-unifont.so 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- kmscon (rpmlib, GLIBC filtered): /bin/sh libEGL.so.1 libGLESv2.so.2 libc.so.6 libdl.so.2 libdrm.so.2 libfontconfig.so.1 libfreetype.so.6 libgbm.so.1 libglib-2.0.so.0 libgobject-2.0.so.0 libpango-1.0.so.0 libpangoft2-1.0.so.0 libpixman-1.so.0 libpthread.so.0 libsystemd.so.0 libsystemd.so.0(LIBSYSTEMD_209) libtsm.so.3 libtsm.so.3(LIBTSM_1) libtsm.so.3(LIBTSM_2) libtsm.so.3(LIBTSM_3) libudev.so.1 libudev.so.1(LIBUDEV_183) libxkbcommon.so.0 rtld(GNU_HASH) systemd Provides -------- kmscon: kmscon kmscon(x86-32) Unversioned so-files -------------------- kmscon: /usr/lib/kmscon/mod-bbulk.so kmscon: /usr/lib/kmscon/mod-gltex.so kmscon: /usr/lib/kmscon/mod-pango.so kmscon: /usr/lib/kmscon/mod-pixman.so kmscon: /usr/lib/kmscon/mod-unifont.so Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn kmscon-8-3.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ---------------------------- 1. Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.UOos1E + umask 022 + cd /builddir/build/BUILD + cd kmscon-8 + make check Making check in . make --no-print-directory test_output test_vt test_input test_key CC src/test_output-conf.o CC tests/test_output-test_output.o CCLD test_output CC src/test_vt-conf.o CC tests/test_vt-test_vt.o CCLD test_vt CC src/test_input-conf.o CC tests/test_input-test_input.o tests/test_input.c: In function 'main': tests/test_input.c:229:8: warning: ignoring return value of 'system', declared with attribute warn_unused_result [-Wunused-result] system("stty -echo"); ^ tests/test_input.c:232:8: warning: ignoring return value of 'system', declared with attribute warn_unused_result [-Wunused-result] system("stty echo"); ^ CCLD test_input CC src/test_key-conf.o CC tests/test_key-test_key.o CCLD test_key + exit 0 Test section still use silent build, please append V=1 to make check. 2. kmscon.i686: W: executable-stack /usr/lib/kmscon/mod-unifont.so Well, this is a very interesting issue, please solve it.
The execstack issue: https://bugs.freedesktop.org/show_bug.cgi?id=76289 Alternatively, you could just turn off the executable stack bit with execstack -c utility from prelink package.
Ping?
According to the report, the execstack issue should be fixed with recent binutils but is not available even in rawhide. Is there anythin left to fix beyond the make check verbosity ?
I will check with fc20 i686 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6718769 I don't have a f19 i686 at hand
I believe it's fine as it is. I believe you need an approval from the assigned reviewer though. Christopher: Ping? Is this one good to go?
(In reply to Lubomir Rintel from comment #9) > I believe it's fine as it is. I believe you need an approval from the > assigned reviewer though. > > Christopher: Ping? Is this one good to go? Instead of that stack issue, still 2 left. I'd like to see the new SPEC + SRPM, then will approve it.
Nicolas: Ping :)
Spec URL: http://kwizart.fedorapeople.org/review/kmscon.spec SRPM URL: http://kwizart.fedorapeople.org/review/kmscon-8-4.fc20.src.rpm Description: KMS/DRM based System Console Changelog: - Clear execstack - Add verbose check and fix description Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6816175
Upstream has fixed the bug, I think it's better now.(You may drop the hack IMO, right? Nick has fixed it.) PACKAGE APPROVED.
New Package SCM Request ======================= Package Name: kmscon Short Description: KMS/DRM based System Console Owners: foo bar Branches: f20 epel7 InitialCC: kwizart
WARNING: "foo" is not in the packager group. WARNING: "bar" is not a valid FAS account.
New Package SCM Request ======================= Package Name: kmscon Short Description: KMS/DRM based System Console Owners: kwizart Branches: f20 epel7 InitialCC:
Git done (by process-git-requests).